From: Wolfram Sang <wsa@the-dreams.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-rockchip@lists.infradead.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: [PATCH v2 2/9] i2c: add generic routine to parse DT for timing information
Date: Tue, 8 Dec 2015 22:51:03 +0100 [thread overview]
Message-ID: <20151208215103.GA1601@katana> (raw)
In-Reply-To: <20151208130323.GB3359@katana>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Tue, Dec 08, 2015 at 02:03:23PM +0100, Wolfram Sang wrote:
>
> > Too many && use_defaults. What about
> >
> > memset(t, 0, sizeof(*t));
> >
> > device_property_read_u32(dev, "i2c-scl-internal-delay-ns", &t-
> > >scl_int_delay_ns);
> >
> > if (!use_defaults)
> > return;
>
> I like this! Thanks for the input.
Oops, too enthusiastic. This skips parsing all the other properties...
The defaults should only be applied if reading the properties fails.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-rockchip@lists.infradead.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: [PATCH v2 2/9] i2c: add generic routine to parse DT for timing information
Date: Tue, 08 Dec 2015 21:51:03 +0000 [thread overview]
Message-ID: <20151208215103.GA1601@katana> (raw)
In-Reply-To: <20151208130323.GB3359@katana>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Tue, Dec 08, 2015 at 02:03:23PM +0100, Wolfram Sang wrote:
>
> > Too many && use_defaults. What about
> >
> > memset(t, 0, sizeof(*t));
> >
> > device_property_read_u32(dev, "i2c-scl-internal-delay-ns", &t-
> > >scl_int_delay_ns);
> >
> > if (!use_defaults)
> > return;
>
> I like this! Thanks for the input.
Oops, too enthusiastic. This skips parsing all the other properties...
The defaults should only be applied if reading the properties fails.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-08 21:54 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 9:37 [PATCH v2 0/9] i2c: add generic support for timing parameters in DT Wolfram Sang
2015-12-08 9:37 ` Wolfram Sang
2015-12-08 9:37 ` [PATCH v2 1/9] i2c: document generic DT bindings for timing parameters Wolfram Sang
2015-12-08 9:37 ` Wolfram Sang
2015-12-08 9:37 ` [PATCH v2 2/9] i2c: add generic routine to parse DT for timing information Wolfram Sang
2015-12-08 9:37 ` Wolfram Sang
2015-12-08 10:54 ` Andy Shevchenko
2015-12-08 10:54 ` Andy Shevchenko
2015-12-08 13:03 ` Wolfram Sang
2015-12-08 13:03 ` Wolfram Sang
2015-12-08 21:51 ` Wolfram Sang [this message]
2015-12-08 21:51 ` Wolfram Sang
2015-12-09 12:12 ` Andy Shevchenko
2015-12-09 12:12 ` Andy Shevchenko
2015-12-14 9:49 ` Wolfram Sang
2015-12-14 9:49 ` Wolfram Sang
2015-12-08 11:09 ` Mika Westerberg
2015-12-08 11:09 ` Mika Westerberg
2015-12-08 12:53 ` Wolfram Sang
2015-12-08 12:53 ` Wolfram Sang
2015-12-08 13:03 ` Mika Westerberg
2015-12-08 13:03 ` Mika Westerberg
2015-12-08 9:37 ` [PATCH v2 3/9] i2c: rcar: refactor probe function a little Wolfram Sang
2015-12-08 9:37 ` Wolfram Sang
2015-12-08 9:37 ` [PATCH v2 4/9] i2c: rcar: switch to i2c generic dt parsing Wolfram Sang
2015-12-08 9:37 ` Wolfram Sang
2015-12-08 10:59 ` Andy Shevchenko
2015-12-08 10:59 ` Andy Shevchenko
2015-12-08 11:00 ` Shevchenko, Andriy
2015-12-08 11:00 ` Shevchenko, Andriy
2015-12-08 9:37 ` [PATCH v2 5/9] i2c: rcar: honor additional i2c timings from DT Wolfram Sang
2015-12-08 9:37 ` Wolfram Sang
2015-12-08 9:37 ` [PATCH v2 6/9] ARM: shmobile: r8a7790: dtsi: add internal delay for i2c IPs Wolfram Sang
2015-12-08 9:37 ` Wolfram Sang
2015-12-08 9:37 ` [PATCH v2 7/9] ARM: shmobile: r8a7791: " Wolfram Sang
2015-12-08 9:37 ` Wolfram Sang
2015-12-08 9:37 ` [PATCH v2 8/9] ARM: shmobile: r8a7794: " Wolfram Sang
2015-12-08 9:37 ` Wolfram Sang
2015-12-08 9:37 ` [PATCH v2 9/9] arm64: renesas: r8a7795: " Wolfram Sang
2015-12-08 9:37 ` Wolfram Sang
2015-12-10 5:00 ` [PATCH v2 0/9] i2c: add generic support for timing parameters in DT Simon Horman
2015-12-10 5:00 ` Simon Horman
2015-12-14 10:00 ` Wolfram Sang
2015-12-14 10:00 ` Wolfram Sang
2015-12-15 4:14 ` Simon Horman
2015-12-15 4:14 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208215103.GA1601@katana \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=jarkko.nikula@linux.intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.