* libnetfilter_conntrack: set_attr_dnat_ipv4
@ 2015-12-08 22:35 Sargun Dhillon
2015-12-08 22:37 ` Florian Westphal
0 siblings, 1 reply; 3+ messages in thread
From: Sargun Dhillon @ 2015-12-08 22:35 UTC (permalink / raw)
To: netfilter-devel
I'm curious, I'm looking at the libnetfilter_conntrack code, and I see
the following function definition:
static void
set_attr_dnat_ipv4(struct nf_conntrack *ct, const void *value, size_t len)
{
ct->dnat.min_ip = ct->snat.max_ip = *((u_int32_t *) value);
}
Why does setting the DNAT_IPV4 attribute touch the snat.max_ip struct member?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: libnetfilter_conntrack: set_attr_dnat_ipv4
2015-12-08 22:35 libnetfilter_conntrack: set_attr_dnat_ipv4 Sargun Dhillon
@ 2015-12-08 22:37 ` Florian Westphal
0 siblings, 0 replies; 3+ messages in thread
From: Florian Westphal @ 2015-12-08 22:37 UTC (permalink / raw)
To: Sargun Dhillon; +Cc: netfilter-devel
Sargun Dhillon <sargun@sargun.me> wrote:
> I'm curious, I'm looking at the libnetfilter_conntrack code, and I see
> the following function definition:
>
> static void
> set_attr_dnat_ipv4(struct nf_conntrack *ct, const void *value, size_t len)
> {
> ct->dnat.min_ip = ct->snat.max_ip = *((u_int32_t *) value);
> }
Sure looks like a copy & paste bug...
^ permalink raw reply [flat|nested] 3+ messages in thread
* libnetfilter_conntrack: set_attr_dnat_ipv4
@ 2015-12-16 17:19 Sargun Dhillon
0 siblings, 0 replies; 3+ messages in thread
From: Sargun Dhillon @ 2015-12-16 17:19 UTC (permalink / raw)
To: netfilter
I'm curious, I'm looking at the libnetfilter_conntrack code, and I see
the following function definition:
static void
set_attr_dnat_ipv4(struct nf_conntrack *ct, const void *value, size_t len)
{
ct->dnat.min_ip = ct->snat.max_ip = *((u_int32_t *) value);
}
Why does setting the DNAT_IPV4 attribute touch the snat.max_ip struct member?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-16 17:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-08 22:35 libnetfilter_conntrack: set_attr_dnat_ipv4 Sargun Dhillon
2015-12-08 22:37 ` Florian Westphal
-- strict thread matches above, loose matches on Subject: below --
2015-12-16 17:19 Sargun Dhillon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.