* [PATCH] sh64: fix __NR_fgetxattr
@ 2015-12-09 3:16 ` Dmitry V. Levin
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry V. Levin @ 2015-12-09 3:16 UTC (permalink / raw)
To: linux-sh; +Cc: linux-kernel
According to arch/sh/kernel/syscalls_64.S and common sense,
__NR_fgetxattr has to be defined to 259, but it doesn't.
Instead, it's defined to 269, which is of course used
by another syscall, __NR_sched_setaffinity in this case.
This bug was found by strace test suite.
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Cc: stable@vger.kernel.org
---
arch/sh/include/uapi/asm/unistd_64.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sh/include/uapi/asm/unistd_64.h b/arch/sh/include/uapi/asm/unistd_64.h
index e6820c8..47ebd5b 100644
--- a/arch/sh/include/uapi/asm/unistd_64.h
+++ b/arch/sh/include/uapi/asm/unistd_64.h
@@ -278,7 +278,7 @@
#define __NR_fsetxattr 256
#define __NR_getxattr 257
#define __NR_lgetxattr 258
-#define __NR_fgetxattr 269
+#define __NR_fgetxattr 259
#define __NR_listxattr 260
#define __NR_llistxattr 261
#define __NR_flistxattr 262
--
ldv
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] sh64: fix __NR_fgetxattr
@ 2015-12-09 3:16 ` Dmitry V. Levin
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry V. Levin @ 2015-12-09 3:16 UTC (permalink / raw)
To: linux-sh; +Cc: linux-kernel
According to arch/sh/kernel/syscalls_64.S and common sense,
__NR_fgetxattr has to be defined to 259, but it doesn't.
Instead, it's defined to 269, which is of course used
by another syscall, __NR_sched_setaffinity in this case.
This bug was found by strace test suite.
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Cc: stable@vger.kernel.org
---
arch/sh/include/uapi/asm/unistd_64.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sh/include/uapi/asm/unistd_64.h b/arch/sh/include/uapi/asm/unistd_64.h
index e6820c8..47ebd5b 100644
--- a/arch/sh/include/uapi/asm/unistd_64.h
+++ b/arch/sh/include/uapi/asm/unistd_64.h
@@ -278,7 +278,7 @@
#define __NR_fsetxattr 256
#define __NR_getxattr 257
#define __NR_lgetxattr 258
-#define __NR_fgetxattr 269
+#define __NR_fgetxattr 259
#define __NR_listxattr 260
#define __NR_llistxattr 261
#define __NR_flistxattr 262
--
ldv
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sh64: fix __NR_fgetxattr
2015-12-09 3:16 ` Dmitry V. Levin
@ 2015-12-09 8:24 ` Geert Uytterhoeven
-1 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2015-12-09 8:24 UTC (permalink / raw)
To: Dmitry V. Levin
Cc: Linux-sh list, linux-kernel@vger.kernel.org, Andrew Morton
CC akpm
On Wed, Dec 9, 2015 at 4:16 AM, Dmitry V. Levin <ldv@altlinux.org> wrote:
> According to arch/sh/kernel/syscalls_64.S and common sense,
> __NR_fgetxattr has to be defined to 259, but it doesn't.
> Instead, it's defined to 269, which is of course used
> by another syscall, __NR_sched_setaffinity in this case.
>
> This bug was found by strace test suite.
>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> Cc: stable@vger.kernel.org
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> arch/sh/include/uapi/asm/unistd_64.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sh/include/uapi/asm/unistd_64.h b/arch/sh/include/uapi/asm/unistd_64.h
> index e6820c8..47ebd5b 100644
> --- a/arch/sh/include/uapi/asm/unistd_64.h
> +++ b/arch/sh/include/uapi/asm/unistd_64.h
> @@ -278,7 +278,7 @@
> #define __NR_fsetxattr 256
> #define __NR_getxattr 257
> #define __NR_lgetxattr 258
> -#define __NR_fgetxattr 269
> +#define __NR_fgetxattr 259
> #define __NR_listxattr 260
> #define __NR_llistxattr 261
> #define __NR_flistxattr 262
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sh64: fix __NR_fgetxattr
@ 2015-12-09 8:24 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2015-12-09 8:24 UTC (permalink / raw)
To: Dmitry V. Levin
Cc: Linux-sh list, linux-kernel@vger.kernel.org, Andrew Morton
CC akpm
On Wed, Dec 9, 2015 at 4:16 AM, Dmitry V. Levin <ldv@altlinux.org> wrote:
> According to arch/sh/kernel/syscalls_64.S and common sense,
> __NR_fgetxattr has to be defined to 259, but it doesn't.
> Instead, it's defined to 269, which is of course used
> by another syscall, __NR_sched_setaffinity in this case.
>
> This bug was found by strace test suite.
>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> Cc: stable@vger.kernel.org
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> arch/sh/include/uapi/asm/unistd_64.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sh/include/uapi/asm/unistd_64.h b/arch/sh/include/uapi/asm/unistd_64.h
> index e6820c8..47ebd5b 100644
> --- a/arch/sh/include/uapi/asm/unistd_64.h
> +++ b/arch/sh/include/uapi/asm/unistd_64.h
> @@ -278,7 +278,7 @@
> #define __NR_fsetxattr 256
> #define __NR_getxattr 257
> #define __NR_lgetxattr 258
> -#define __NR_fgetxattr 269
> +#define __NR_fgetxattr 259
> #define __NR_listxattr 260
> #define __NR_llistxattr 261
> #define __NR_flistxattr 262
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-09 8:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-09 3:16 [PATCH] sh64: fix __NR_fgetxattr Dmitry V. Levin
2015-12-09 3:16 ` Dmitry V. Levin
2015-12-09 8:24 ` Geert Uytterhoeven
2015-12-09 8:24 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.