From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-qt5][PATCH] cmake_qt5.bbclass: add DEPENDS to qtbase
Date: Wed, 9 Dec 2015 10:19:09 +0100 [thread overview]
Message-ID: <20151209091909.GC2246@jama> (raw)
In-Reply-To: <1449651204-16080-1-git-send-email-mikko.rapeli@bmw.de>
[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]
On Wed, Dec 09, 2015 at 10:53:24AM +0200, Mikko Rapeli wrote:
> All packages using this class need it and it is too easy for developers
> to miss and leave race conditions into builds.
>
> Change-Id: I713ffdf26e821b8ab12c2d53f9a1e6679d26a4b1
You don't need Change-Id.
> Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de>
> ---
> classes/cmake_qt5.bbclass | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/classes/cmake_qt5.bbclass b/classes/cmake_qt5.bbclass
> index 94a60dc..10b0312 100644
> --- a/classes/cmake_qt5.bbclass
> +++ b/classes/cmake_qt5.bbclass
> @@ -1,6 +1,8 @@
> inherit cmake
> inherit qmake5_paths
>
> +DEPENDS_prepend = " qtbase "
You don't need leading space in prepend, only the trailing one.
> +
> EXTRA_OECMAKE += " \
> -DOE_QMAKE_PATH_PREFIX=${OE_QMAKE_PATH_PREFIX} \
> -DOE_QMAKE_PATH_HEADERS=${OE_QMAKE_PATH_HEADERS} \
> --
> 2.6.2
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
next prev parent reply other threads:[~2015-12-09 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 8:53 [meta-qt5][PATCH] cmake_qt5.bbclass: add DEPENDS to qtbase Mikko Rapeli
2015-12-09 9:19 ` Martin Jansa [this message]
2015-12-09 9:24 ` Mikko.Rapeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209091909.GC2246@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.