[meta-qt5][PATCH] cmake_qt5.bbclass: add DEPENDS to qtbase

[meta-qt5][PATCH] cmake_qt5.bbclass: add DEPENDS to qtbase

[Mikko Rapeli]

All packages using this class need it and it is too easy for developers
to miss and leave race conditions into builds.

Change-Id: I713ffdf26e821b8ab12c2d53f9a1e6679d26a4b1
Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de>
---
 classes/cmake_qt5.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/classes/cmake_qt5.bbclass b/classes/cmake_qt5.bbclass
index 94a60dc..10b0312 100644
--- a/classes/cmake_qt5.bbclass
+++ b/classes/cmake_qt5.bbclass
@@ -1,6 +1,8 @@
 inherit cmake
 inherit qmake5_paths
 
+DEPENDS_prepend = " qtbase "
+
 EXTRA_OECMAKE += " \
     -DOE_QMAKE_PATH_PREFIX=${OE_QMAKE_PATH_PREFIX} \
     -DOE_QMAKE_PATH_HEADERS=${OE_QMAKE_PATH_HEADERS} \
-- 
2.6.2

Re: [meta-qt5][PATCH] cmake_qt5.bbclass: add DEPENDS to qtbase

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

On Wed, Dec 09, 2015 at 10:53:24AM +0200, Mikko Rapeli wrote:
> All packages using this class need it and it is too easy for developers
> to miss and leave race conditions into builds.
> 
> Change-Id: I713ffdf26e821b8ab12c2d53f9a1e6679d26a4b1

You don't need Change-Id.

> Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de>
> ---
>  classes/cmake_qt5.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/classes/cmake_qt5.bbclass b/classes/cmake_qt5.bbclass
> index 94a60dc..10b0312 100644
> --- a/classes/cmake_qt5.bbclass
> +++ b/classes/cmake_qt5.bbclass
> @@ -1,6 +1,8 @@
>  inherit cmake
>  inherit qmake5_paths
>  
> +DEPENDS_prepend = " qtbase "

You don't need leading space in prepend, only the trailing one.

> +
>  EXTRA_OECMAKE += " \
>      -DOE_QMAKE_PATH_PREFIX=${OE_QMAKE_PATH_PREFIX} \
>      -DOE_QMAKE_PATH_HEADERS=${OE_QMAKE_PATH_HEADERS} \
> -- 
> 2.6.2
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-qt5][PATCH] cmake_qt5.bbclass: add DEPENDS to qtbase

[Mikko.Rapeli]

On Wed, Dec 09, 2015 at 10:19:09AM +0100, Martin Jansa wrote:
> On Wed, Dec 09, 2015 at 10:53:24AM +0200, Mikko Rapeli wrote:
> > All packages using this class need it and it is too easy for developers
> > to miss and leave race conditions into builds.
> > 
> > Change-Id: I713ffdf26e821b8ab12c2d53f9a1e6679d26a4b1
> 
> You don't need Change-Id.

Ok, removing.

> > Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de>
> > ---
> >  classes/cmake_qt5.bbclass | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/classes/cmake_qt5.bbclass b/classes/cmake_qt5.bbclass
> > index 94a60dc..10b0312 100644
> > --- a/classes/cmake_qt5.bbclass
> > +++ b/classes/cmake_qt5.bbclass
> > @@ -1,6 +1,8 @@
> >  inherit cmake
> >  inherit qmake5_paths
> >  
> > +DEPENDS_prepend = " qtbase "
> 
> You don't need leading space in prepend, only the trailing one.

I did at some point on dizzy but will remove.

-Mikko