All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-qt5][PATCH v2] cmake_qt5.bbclass: add DEPENDS to qtbase
@ 2015-12-09  9:26 Mikko Rapeli
  2015-12-09  9:38 ` Mikko.Rapeli
  0 siblings, 1 reply; 2+ messages in thread
From: Mikko Rapeli @ 2015-12-09  9:26 UTC (permalink / raw)
  To: openembedded-devel

All packages using this class need it and it is too easy for developers
to miss and leave race conditions into builds.

Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de>
---
 classes/cmake_qt5.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/classes/cmake_qt5.bbclass b/classes/cmake_qt5.bbclass
index 94a60dc..f63be3c 100644
--- a/classes/cmake_qt5.bbclass
+++ b/classes/cmake_qt5.bbclass
@@ -1,6 +1,8 @@
 inherit cmake
 inherit qmake5_paths
 
+DEPENDS_prepend = "qtbase"
+
 EXTRA_OECMAKE += " \
     -DOE_QMAKE_PATH_PREFIX=${OE_QMAKE_PATH_PREFIX} \
     -DOE_QMAKE_PATH_HEADERS=${OE_QMAKE_PATH_HEADERS} \
-- 
2.6.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [meta-qt5][PATCH v2] cmake_qt5.bbclass: add DEPENDS to qtbase
  2015-12-09  9:26 [meta-qt5][PATCH v2] cmake_qt5.bbclass: add DEPENDS to qtbase Mikko Rapeli
@ 2015-12-09  9:38 ` Mikko.Rapeli
  0 siblings, 0 replies; 2+ messages in thread
From: Mikko.Rapeli @ 2015-12-09  9:38 UTC (permalink / raw)
  To: openembedded-devel

On Wed, Dec 09, 2015 at 11:26:27AM +0200, Mikko Rapeli wrote:
> All packages using this class need it and it is too easy for developers
> to miss and leave race conditions into builds.
> 
> Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de>
> ---
>  classes/cmake_qt5.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/classes/cmake_qt5.bbclass b/classes/cmake_qt5.bbclass
> index 94a60dc..f63be3c 100644
> --- a/classes/cmake_qt5.bbclass
> +++ b/classes/cmake_qt5.bbclass
> @@ -1,6 +1,8 @@
>  inherit cmake
>  inherit qmake5_paths
>  
> +DEPENDS_prepend = "qtbase"

Scrap this, leading space only was not needed. Sorry.

-Mikko

> +
>  EXTRA_OECMAKE += " \
>      -DOE_QMAKE_PATH_PREFIX=${OE_QMAKE_PATH_PREFIX} \
>      -DOE_QMAKE_PATH_HEADERS=${OE_QMAKE_PATH_HEADERS} \
> -- 
> 2.6.2
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-09  9:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-09  9:26 [meta-qt5][PATCH v2] cmake_qt5.bbclass: add DEPENDS to qtbase Mikko Rapeli
2015-12-09  9:38 ` Mikko.Rapeli

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.