* [patch -next] mlxsw: core: remove an unneeded condition
@ 2015-12-09 10:41 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-12-09 10:41 UTC (permalink / raw)
To: Jiri Pirko; +Cc: Ido Schimmel, netdev, kernel-janitors
We already know "err" is zero so there is no need to check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c b/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
index 4dad146..913106d 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
@@ -169,7 +169,7 @@ static ssize_t mlxsw_hwmon_pwm_store(struct device *dev,
dev_err(mlxsw_hwmon->bus_info->dev, "Failed to write PWM\n");
return err;
}
- return err ? err : len;
+ return len;
}
enum mlxsw_hwmon_attr_type {
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch -next] mlxsw: core: remove an unneeded condition
@ 2015-12-09 10:41 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-12-09 10:41 UTC (permalink / raw)
To: Jiri Pirko; +Cc: Ido Schimmel, netdev, kernel-janitors
We already know "err" is zero so there is no need to check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c b/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
index 4dad146..913106d 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
@@ -169,7 +169,7 @@ static ssize_t mlxsw_hwmon_pwm_store(struct device *dev,
dev_err(mlxsw_hwmon->bus_info->dev, "Failed to write PWM\n");
return err;
}
- return err ? err : len;
+ return len;
}
enum mlxsw_hwmon_attr_type {
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch -next] mlxsw: core: remove an unneeded condition
2015-12-09 10:41 ` Dan Carpenter
@ 2015-12-09 10:47 ` Jiri Pirko
-1 siblings, 0 replies; 6+ messages in thread
From: Jiri Pirko @ 2015-12-09 10:47 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jiri Pirko, Ido Schimmel, netdev, kernel-janitors
Wed, Dec 09, 2015 at 11:41:29AM CET, dan.carpenter@oracle.com wrote:
>We already know "err" is zero so there is no need to check.
>
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch -next] mlxsw: core: remove an unneeded condition
@ 2015-12-09 10:47 ` Jiri Pirko
0 siblings, 0 replies; 6+ messages in thread
From: Jiri Pirko @ 2015-12-09 10:47 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jiri Pirko, Ido Schimmel, netdev, kernel-janitors
Wed, Dec 09, 2015 at 11:41:29AM CET, dan.carpenter@oracle.com wrote:
>We already know "err" is zero so there is no need to check.
>
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch -next] mlxsw: core: remove an unneeded condition
2015-12-09 10:41 ` Dan Carpenter
@ 2015-12-12 1:15 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2015-12-12 1:15 UTC (permalink / raw)
To: dan.carpenter; +Cc: jiri, idosch, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 9 Dec 2015 13:41:29 +0300
> We already know "err" is zero so there is no need to check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-12-12 1:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-09 10:41 [patch -next] mlxsw: core: remove an unneeded condition Dan Carpenter
2015-12-09 10:41 ` Dan Carpenter
2015-12-09 10:47 ` Jiri Pirko
2015-12-09 10:47 ` Jiri Pirko
2015-12-12 1:15 ` David Miller
2015-12-12 1:15 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.