All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Rami Rosen <rami.rosen@intel.com>
Cc: kadlec@blackhole.kfki.hu, netfilter-devel@vger.kernel.org,
	coreteam@netfilter.org
Subject: Re: [PATCH nf-next] netfilter: nftables: Change the return type of nfulnl_set_timeout() and nfulnl_set_qthresh() to be void.
Date: Wed, 9 Dec 2015 15:00:44 +0100	[thread overview]
Message-ID: <20151209140044.GA1568@salvia> (raw)
In-Reply-To: <20151209135158.GA1309@salvia>

On Wed, Dec 09, 2015 at 02:51:58PM +0100, Pablo Neira Ayuso wrote:
> On Tue, Dec 08, 2015 at 07:09:24AM -0500, Rami Rosen wrote:
> >  This patch changes the return type of the static methods nfulnl_set_timeout() and
> >  nfulnl_set_qthresh() to be void, as there is no justification and no need for these methods to return int.
> 
> Applied, thanks.

For the record, I have renamed the title to:

"netfilter: nfnetlink_log: Change setter functions to be void"

This is not related to nftables itself, but our userspace logging
infrastructure.

Then I have trimmed off the title length a bit, I hope this retains
the original spirit of it.

      reply	other threads:[~2015-12-09 14:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08 12:09 [PATCH nf-next] netfilter: nftables: Change the return type of nfulnl_set_timeout() and nfulnl_set_qthresh() to be void Rami Rosen
2015-12-09 13:51 ` Pablo Neira Ayuso
2015-12-09 14:00   ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151209140044.GA1568@salvia \
    --to=pablo@netfilter.org \
    --cc=coreteam@netfilter.org \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=rami.rosen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.