From: Mel Gorman <mgorman@techsingularity.net>
To: Qais Yousef <qais.yousef@imgtec.com>
Cc: linux-mips@linux-mips.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, ralf@linux-mips.org,
akpm@linux-foundation.org
Subject: Re: [PATCH v2] MIPS: fix DMA contiguous allocation
Date: Wed, 9 Dec 2015 15:03:02 +0000 [thread overview]
Message-ID: <20151209150302.GB15910@techsingularity.net> (raw)
In-Reply-To: <1449672845-2196-1-git-send-email-qais.yousef@imgtec.com>
On Wed, Dec 09, 2015 at 02:54:05PM +0000, Qais Yousef wrote:
> Recent changes to how GFP_ATOMIC is defined seems to have broken the condition
> to use mips_alloc_from_contiguous() in mips_dma_alloc_coherent().
>
> I couldn't bottom out the exact change but I think it's this one
>
> d0164adc89f6 (mm, page_alloc: distinguish between being unable to sleep,
> unwilling to sleep and avoiding waking kswapd)
>
> From what I see GFP_ATOMIC has multiple bits set and the check for !(gfp
> & GFP_ATOMIC) isn't enough.
>
> The reason behind this condition is to check whether we can potentially do
> a sleeping memory allocation. Use gfpflags_allow_blocking() instead which
> should be more robust.
>
> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net>
To: Qais Yousef <qais.yousef@imgtec.com>
Cc: linux-mips@linux-mips.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, ralf@linux-mips.org,
akpm@linux-foundation.org
Subject: Re: [PATCH v2] MIPS: fix DMA contiguous allocation
Date: Wed, 9 Dec 2015 15:03:02 +0000 [thread overview]
Message-ID: <20151209150302.GB15910@techsingularity.net> (raw)
In-Reply-To: <1449672845-2196-1-git-send-email-qais.yousef@imgtec.com>
On Wed, Dec 09, 2015 at 02:54:05PM +0000, Qais Yousef wrote:
> Recent changes to how GFP_ATOMIC is defined seems to have broken the condition
> to use mips_alloc_from_contiguous() in mips_dma_alloc_coherent().
>
> I couldn't bottom out the exact change but I think it's this one
>
> d0164adc89f6 (mm, page_alloc: distinguish between being unable to sleep,
> unwilling to sleep and avoiding waking kswapd)
>
> From what I see GFP_ATOMIC has multiple bits set and the check for !(gfp
> & GFP_ATOMIC) isn't enough.
>
> The reason behind this condition is to check whether we can potentially do
> a sleeping memory allocation. Use gfpflags_allow_blocking() instead which
> should be more robust.
>
> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-09 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 14:54 [PATCH v2] MIPS: fix DMA contiguous allocation Qais Yousef
2015-12-09 14:54 ` Qais Yousef
2015-12-09 14:54 ` Qais Yousef
2015-12-09 14:54 ` Qais Yousef
2015-12-09 15:03 ` Mel Gorman [this message]
2015-12-09 15:03 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209150302.GB15910@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=qais.yousef@imgtec.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.