From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] nvme: precedence bug in nvme_pr_clear()
Date: Wed, 09 Dec 2015 18:14:20 +0000 [thread overview]
Message-ID: <20151209181420.GB5284@mwanda> (raw)
In-Reply-To: <56686B55.7020900@fb.com>
On Wed, Dec 09, 2015 at 10:56:37AM -0700, Jens Axboe wrote:
> On 12/09/2015 03:24 AM, Dan Carpenter wrote:
> >The "|" operator has higher precedence than "?:" so this didn't work as
> >intended. I had previously fixed this bug, but it we copied the older
> >unfixed version when we moved the function between files.
> >
> >Fixes: 1673f1f08c88 ('nvme: move block_device_operations and ns/ctrl freeing to common code')
> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Dejavu, but I guess in a different function. Christoph, you are
> hereby banned from ever using ?:!
Christoph didn't write this. I think where it went wrong is:
[Moved the integrity and pr changes due to merge conflict]
We merged the buggy version instead of the fixed version. I don't know
git well enough to be positive.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: dan.carpenter@oracle.com (Dan Carpenter)
Subject: [patch] nvme: precedence bug in nvme_pr_clear()
Date: Wed, 9 Dec 2015 21:14:20 +0300 [thread overview]
Message-ID: <20151209181420.GB5284@mwanda> (raw)
In-Reply-To: <56686B55.7020900@fb.com>
On Wed, Dec 09, 2015@10:56:37AM -0700, Jens Axboe wrote:
> On 12/09/2015 03:24 AM, Dan Carpenter wrote:
> >The "|" operator has higher precedence than "?:" so this didn't work as
> >intended. I had previously fixed this bug, but it we copied the older
> >unfixed version when we moved the function between files.
> >
> >Fixes: 1673f1f08c88 ('nvme: move block_device_operations and ns/ctrl freeing to common code')
> >Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>
> Dejavu, but I guess in a different function. Christoph, you are
> hereby banned from ever using ?:!
Christoph didn't write this. I think where it went wrong is:
[Moved the integrity and pr changes due to merge conflict]
We merged the buggy version instead of the fixed version. I don't know
git well enough to be positive.
regards,
dan carpenter
next prev parent reply other threads:[~2015-12-09 18:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 10:24 [patch] nvme: precedence bug in nvme_pr_clear() Dan Carpenter
2015-12-09 10:24 ` Dan Carpenter
2015-12-09 17:56 ` Jens Axboe
2015-12-09 17:56 ` Jens Axboe
2015-12-09 18:00 ` Christoph Hellwig
2015-12-09 18:00 ` Christoph Hellwig
2015-12-09 18:05 ` Jens Axboe
2015-12-09 18:05 ` Jens Axboe
2015-12-09 18:15 ` Keith Busch
2015-12-09 18:15 ` Keith Busch
2015-12-09 18:00 ` Keith Busch
2015-12-09 18:00 ` Keith Busch
2015-12-09 18:14 ` Dan Carpenter [this message]
2015-12-09 18:14 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209181420.GB5284@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.