From: Brian Norris <computersforpeace@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Linux-sh list <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Frans Klaver <fransklaver@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] mtd: sh_flctl: pass FIFO as physical address
Date: Wed, 9 Dec 2015 18:21:46 -0800 [thread overview]
Message-ID: <20151210022146.GH144338@google.com> (raw)
In-Reply-To: <CAMuHMdVWss6Kz8sVrcUR3a4iJ+Z8D1q1Er6eH_uRMoS5DCN5pw@mail.gmail.com>
On Tue, Dec 08, 2015 at 05:30:02PM +0100, Geert Uytterhoeven wrote:
> On Tue, Dec 8, 2015 at 4:38 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > By convention, the FIFO address we pass using dmaengine_slave_config
> > is a physical address in the form that is understood by the DMA
> > engine, as a dma_addr_t, phys_addr_t or resource_size_t.
> >
> > The sh_flctl driver however passes a virtual __iomem address that
> > gets cast to dma_addr_t in the slave driver. This happens to work
> > on shmobile because that platform sets up an identity mapping for
> > its MMIO regions, but such code is not portable to other platforms,
> > and prevents us from ever changing the platform mapping or reusing
> > the driver on other architectures like ARM64 that might not have the
> > mapping.
>
> Note that since the removal of (ARM) sh7367/sh7377/sh7372 support, this
> driver is used on SH only.
It's still available as COMPILE_TEST, so it's still worth fixing.
But really, does anyone use this driver any more?
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mtd: sh_flctl: pass FIFO as physical address
Date: Thu, 10 Dec 2015 02:21:46 +0000 [thread overview]
Message-ID: <20151210022146.GH144338@google.com> (raw)
In-Reply-To: <CAMuHMdVWss6Kz8sVrcUR3a4iJ+Z8D1q1Er6eH_uRMoS5DCN5pw@mail.gmail.com>
On Tue, Dec 08, 2015 at 05:30:02PM +0100, Geert Uytterhoeven wrote:
> On Tue, Dec 8, 2015 at 4:38 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > By convention, the FIFO address we pass using dmaengine_slave_config
> > is a physical address in the form that is understood by the DMA
> > engine, as a dma_addr_t, phys_addr_t or resource_size_t.
> >
> > The sh_flctl driver however passes a virtual __iomem address that
> > gets cast to dma_addr_t in the slave driver. This happens to work
> > on shmobile because that platform sets up an identity mapping for
> > its MMIO regions, but such code is not portable to other platforms,
> > and prevents us from ever changing the platform mapping or reusing
> > the driver on other architectures like ARM64 that might not have the
> > mapping.
>
> Note that since the removal of (ARM) sh7367/sh7377/sh7372 support, this
> driver is used on SH only.
It's still available as COMPILE_TEST, so it's still worth fixing.
But really, does anyone use this driver any more?
Brian
WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: sh_flctl: pass FIFO as physical address
Date: Wed, 9 Dec 2015 18:21:46 -0800 [thread overview]
Message-ID: <20151210022146.GH144338@google.com> (raw)
In-Reply-To: <CAMuHMdVWss6Kz8sVrcUR3a4iJ+Z8D1q1Er6eH_uRMoS5DCN5pw@mail.gmail.com>
On Tue, Dec 08, 2015 at 05:30:02PM +0100, Geert Uytterhoeven wrote:
> On Tue, Dec 8, 2015 at 4:38 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > By convention, the FIFO address we pass using dmaengine_slave_config
> > is a physical address in the form that is understood by the DMA
> > engine, as a dma_addr_t, phys_addr_t or resource_size_t.
> >
> > The sh_flctl driver however passes a virtual __iomem address that
> > gets cast to dma_addr_t in the slave driver. This happens to work
> > on shmobile because that platform sets up an identity mapping for
> > its MMIO regions, but such code is not portable to other platforms,
> > and prevents us from ever changing the platform mapping or reusing
> > the driver on other architectures like ARM64 that might not have the
> > mapping.
>
> Note that since the removal of (ARM) sh7367/sh7377/sh7372 support, this
> driver is used on SH only.
It's still available as COMPILE_TEST, so it's still worth fixing.
But really, does anyone use this driver any more?
Brian
next prev parent reply other threads:[~2015-12-10 2:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 15:38 [PATCH] mtd: sh_flctl: pass FIFO as physical address Arnd Bergmann
2015-12-08 15:38 ` Arnd Bergmann
2015-12-08 15:38 ` Arnd Bergmann
2015-12-08 16:30 ` Geert Uytterhoeven
2015-12-08 16:30 ` Geert Uytterhoeven
2015-12-08 16:30 ` Geert Uytterhoeven
2015-12-10 2:21 ` Brian Norris [this message]
2015-12-10 2:21 ` Brian Norris
2015-12-10 2:21 ` Brian Norris
2015-12-10 9:02 ` Geert Uytterhoeven
2015-12-10 9:02 ` Geert Uytterhoeven
2015-12-10 9:02 ` Geert Uytterhoeven
2015-12-10 9:27 ` Arnd Bergmann
2015-12-10 9:27 ` Arnd Bergmann
2015-12-10 9:27 ` Arnd Bergmann
2015-12-19 2:27 ` Brian Norris
2015-12-19 2:27 ` Brian Norris
2015-12-19 2:27 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210022146.GH144338@google.com \
--to=computersforpeace@gmail.com \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=dwmw2@infradead.org \
--cc=fransklaver@gmail.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.