From: Will Deacon <will.deacon@arm.com>
To: Geoff Levand <geoff@infradead.org>
Cc: Pratyush Anand <panand@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
kexec@lists.infradead.org,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
christoffer.dall@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v12 05/16] arm64: Add back cpu_reset routines
Date: Thu, 10 Dec 2015 10:17:51 +0000 [thread overview]
Message-ID: <20151210101751.GA21134@arm.com> (raw)
In-Reply-To: <1449708562.24127.39.camel@infradead.org>
On Wed, Dec 09, 2015 at 04:49:22PM -0800, Geoff Levand wrote:
> On Thu, 2015-12-03 at 09:32 +0000, Will Deacon wrote:
> > On Wed, Dec 02, 2015 at 02:57:30PM -0800, Geoff Levand wrote:
> > > On Mon, 2015-11-30 at 10:40 +0000, Marc Zyngier wrote:
> > >
> > > > All that can be solved in C, and mostly at compile time. Using an
> > > > assembler trampoline is complicating things for no good reason:
> > >
> > > I added this into my kexec-v12.1 branch. After some more testing I'll
> > > post a v13 to the list.
> >
> > You may well need some notrace annotations if you want to run C code
> > here. Can you give it a spin with things like ftrace and kprobes?
>
> I tested ftrace with and without the notrace annotation on
> cpu_soft_restart() and could do kexec re-boots either way.
>
> When cpu_soft_restart() is called we've only done setup_mm_for_reboot(),
> so I would think C code should still be OK.
Yeah, you're right. I mistakenly thought that cpu_soft_restart was running
at the idmap address as opposed to the kernel virtual address.
Will
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v12 05/16] arm64: Add back cpu_reset routines
Date: Thu, 10 Dec 2015 10:17:51 +0000 [thread overview]
Message-ID: <20151210101751.GA21134@arm.com> (raw)
In-Reply-To: <1449708562.24127.39.camel@infradead.org>
On Wed, Dec 09, 2015 at 04:49:22PM -0800, Geoff Levand wrote:
> On Thu, 2015-12-03 at 09:32 +0000, Will Deacon wrote:
> > On Wed, Dec 02, 2015 at 02:57:30PM -0800, Geoff Levand wrote:
> > > On Mon, 2015-11-30 at 10:40 +0000, Marc Zyngier wrote:
> > >
> > > > All that can be solved in C, and mostly at compile time. Using an
> > > > assembler trampoline is complicating things for no good reason:
> > >
> > > I added this into my kexec-v12.1 branch. After some more testing I'll
> > > post a v13 to the list.
> >
> > You may well need some notrace annotations if you want to run C code
> > here. Can you give it a spin with things like ftrace and kprobes?
>
> I tested ftrace with and without the notrace annotation on
> cpu_soft_restart() and could do kexec re-boots either way.
>
> When cpu_soft_restart() is called we've only done setup_mm_for_reboot(),
> so I would think C code should still be OK.
Yeah, you're right. I mistakenly thought that cpu_soft_restart was running
at the idmap address as opposed to the kernel virtual address.
Will
next prev parent reply other threads:[~2015-12-10 10:17 UTC|newest]
Thread overview: 178+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 22:25 [PATCH v12 00/16] arm64 kexec kernel patches v12 Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-11-24 22:25 ` [PATCH v12 06/16] Revert "arm64: mm: remove unused cpu_set_idmap_tcr_t0sz function" Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-11-24 22:25 ` [PATCH v12 01/16] arm64: Fold proc-macros.S into assembler.h Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-11-24 22:25 ` [PATCH v12 07/16] Revert "arm64: remove dead code" Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-11-24 22:25 ` [PATCH v12 04/16] arm64: kvm: allows kvm cpu hotplug Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-11-27 13:54 ` Marc Zyngier
2015-11-27 13:54 ` Marc Zyngier
2015-12-02 22:40 ` Ashwin Chaugule
2015-12-02 22:40 ` Ashwin Chaugule
2015-12-03 13:55 ` Ashwin Chaugule
2015-12-03 13:55 ` Ashwin Chaugule
2015-12-03 13:58 ` Marc Zyngier
2015-12-03 13:58 ` Marc Zyngier
2015-12-10 18:31 ` Geoff Levand
2015-12-10 18:31 ` Geoff Levand
2015-12-11 16:31 ` Will Deacon
2015-12-11 16:31 ` Will Deacon
2015-12-15 8:48 ` AKASHI Takahiro
2015-12-15 8:48 ` AKASHI Takahiro
2015-12-10 18:44 ` Shi, Yang
2015-12-10 18:44 ` Shi, Yang
2015-12-11 8:09 ` AKASHI Takahiro
2015-12-11 8:09 ` AKASHI Takahiro
2015-12-14 18:00 ` Shi, Yang
2015-12-14 18:00 ` Shi, Yang
2015-12-11 8:06 ` AKASHI Takahiro
2015-12-11 8:06 ` AKASHI Takahiro
2015-12-11 13:00 ` Shanker Donthineni
2015-12-11 13:00 ` Shanker Donthineni
2015-12-11 16:28 ` Marc Zyngier
2015-12-11 16:28 ` Marc Zyngier
2015-12-11 18:00 ` Shanker Donthineni
2015-12-11 18:00 ` Shanker Donthineni
2015-12-11 18:11 ` Marc Zyngier
2015-12-11 18:11 ` Marc Zyngier
2015-12-11 19:11 ` Shanker Donthineni
2015-12-11 19:11 ` Shanker Donthineni
2015-12-11 20:13 ` Ashwin Chaugule
2015-12-11 20:13 ` Ashwin Chaugule
2015-12-14 7:33 ` AKASHI Takahiro
2015-12-14 7:33 ` AKASHI Takahiro
2015-12-14 17:33 ` Marc Zyngier
2015-12-14 17:33 ` Marc Zyngier
2015-12-15 7:51 ` AKASHI Takahiro
2015-12-15 7:51 ` AKASHI Takahiro
2015-12-15 8:45 ` Marc Zyngier
2015-12-15 8:45 ` Marc Zyngier
2015-12-15 9:51 ` AKASHI Takahiro
2015-12-15 9:51 ` AKASHI Takahiro
2015-12-15 10:13 ` Marc Zyngier
2015-12-15 10:13 ` Marc Zyngier
2015-11-24 22:25 ` [PATCH v12 05/16] arm64: Add back cpu_reset routines Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-11-27 14:19 ` Marc Zyngier
2015-11-27 14:19 ` Marc Zyngier
2015-11-30 5:28 ` Pratyush Anand
2015-11-30 5:28 ` Pratyush Anand
2015-11-30 10:40 ` Marc Zyngier
2015-11-30 10:40 ` Marc Zyngier
2015-12-02 22:57 ` Geoff Levand
2015-12-02 22:57 ` Geoff Levand
2015-12-03 9:32 ` Will Deacon
2015-12-03 9:32 ` Will Deacon
2015-12-10 0:49 ` Geoff Levand
2015-12-10 0:49 ` Geoff Levand
2015-12-10 10:17 ` Will Deacon [this message]
2015-12-10 10:17 ` Will Deacon
2015-11-30 20:03 ` Geoff Levand
2015-11-30 20:03 ` Geoff Levand
2015-12-01 9:38 ` Marc Zyngier
2015-12-01 9:38 ` Marc Zyngier
2015-11-24 22:25 ` [PATCH v12 02/16] arm64: Convert hcalls to use HVC immediate value Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-11-24 22:25 ` [PATCH v12 03/16] arm64: Add new hcall HVC_CALL_FUNC Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-11-24 22:25 ` [PATCH v12 13/16] arm64: kdump: add kdump support Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-12-15 17:45 ` Will Deacon
2015-12-15 17:45 ` Will Deacon
2015-12-16 5:41 ` AKASHI Takahiro
2015-12-16 5:41 ` AKASHI Takahiro
2015-11-24 22:25 ` [PATCH v12 10/16] arm64/kexec: Enable kexec in the arm64 defconfig Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-11-24 22:25 ` [PATCH v12 14/16] arm64: kdump: update a kernel doc Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-12-15 17:17 ` Will Deacon
2015-12-15 17:17 ` Will Deacon
2015-12-16 5:48 ` AKASHI Takahiro
2015-12-16 5:48 ` AKASHI Takahiro
2015-11-24 22:25 ` [PATCH v12 11/16] arm64: kdump: reserve memory for crash dump kernel Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-12-15 17:29 ` Will Deacon
2015-12-15 17:29 ` Will Deacon
2015-12-16 5:19 ` AKASHI Takahiro
2015-12-16 5:19 ` AKASHI Takahiro
2015-12-16 7:36 ` Pratyush Anand
2015-12-16 7:36 ` Pratyush Anand
2015-11-24 22:25 ` [PATCH v12 15/16] arm64: kdump: enable kdump in the arm64 defconfig Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-11-24 22:25 ` [PATCH v12 16/16] arm64: kdump: relax BUG_ON() if more than one cpus are still active Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-12-15 17:05 ` Will Deacon
2015-12-15 17:05 ` Will Deacon
2015-12-16 5:51 ` AKASHI Takahiro
2015-12-16 5:51 ` AKASHI Takahiro
2015-11-24 22:25 ` [PATCH v12 08/16] arm64/kexec: Add core kexec support Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-11-27 13:13 ` Pratyush Anand
2015-11-27 13:13 ` Pratyush Anand
2015-11-30 18:51 ` Geoff Levand
2015-11-30 18:51 ` Geoff Levand
2015-12-01 2:16 ` Pratyush Anand
2015-12-01 2:16 ` Pratyush Anand
2015-12-01 18:32 ` Azriel Samson
2015-12-01 18:32 ` Azriel Samson
2015-12-02 22:49 ` Geoff Levand
2015-12-02 22:49 ` Geoff Levand
2015-12-03 4:37 ` Azriel Samson
2015-12-03 4:37 ` Azriel Samson
2015-12-03 19:56 ` Geoff Levand
2015-12-03 19:56 ` Geoff Levand
2015-12-04 0:39 ` Azriel Samson
2015-12-04 0:39 ` Azriel Samson
2015-12-04 3:54 ` Pratyush Anand
2015-12-04 3:54 ` Pratyush Anand
2015-12-07 18:47 ` Geoff Levand
2015-12-07 18:47 ` Geoff Levand
2015-12-03 6:09 ` Pratyush Anand
2015-12-03 6:09 ` Pratyush Anand
2015-12-01 19:03 ` Mark Rutland
2015-12-01 19:03 ` Mark Rutland
2015-12-02 21:08 ` Geoff Levand
2015-12-02 21:08 ` Geoff Levand
2015-12-03 16:06 ` Mark Rutland
2015-12-03 16:06 ` Mark Rutland
2015-12-15 18:29 ` Will Deacon
2015-12-15 18:29 ` Will Deacon
2015-12-16 0:14 ` Geoff Levand
2015-12-16 0:14 ` Geoff Levand
2015-12-16 7:18 ` Pratyush Anand
2015-12-16 7:18 ` Pratyush Anand
2015-12-16 9:30 ` James Morse
2015-12-16 9:30 ` James Morse
2015-12-16 10:32 ` Pratyush Anand
2015-12-16 10:32 ` Pratyush Anand
2015-12-16 0:14 ` [PATCH v12.4] " Geoff Levand
2015-12-16 0:14 ` Geoff Levand
2015-11-24 22:25 ` [PATCH v12 12/16] arm64: kdump: implement machine_crash_shutdown() Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-11-27 14:39 ` Marc Zyngier
2015-11-27 14:39 ` Marc Zyngier
2015-12-10 11:34 ` AKASHI Takahiro
2015-12-10 11:34 ` AKASHI Takahiro
2015-12-10 11:44 ` Marc Zyngier
2015-12-10 11:44 ` Marc Zyngier
2015-12-10 12:55 ` AKASHI Takahiro
2015-12-10 12:55 ` AKASHI Takahiro
2015-12-10 13:43 ` Marc Zyngier
2015-12-10 13:43 ` Marc Zyngier
2015-12-03 4:15 ` Pratyush Anand
2015-12-03 4:15 ` Pratyush Anand
2015-12-10 11:42 ` AKASHI Takahiro
2015-12-10 11:42 ` AKASHI Takahiro
2015-12-10 11:50 ` Pratyush Anand
2015-12-10 11:50 ` Pratyush Anand
2015-11-24 22:25 ` [PATCH v12 09/16] arm64/kexec: Add pr_devel output Geoff Levand
2015-11-24 22:25 ` Geoff Levand
2015-12-15 17:15 ` Will Deacon
2015-12-15 17:15 ` Will Deacon
2015-12-16 0:45 ` Geoff Levand
2015-12-16 0:45 ` Geoff Levand
2015-12-16 0:46 ` [PATCH v12.4] arm64/kexec: Add pr_debug output Geoff Levand
2015-12-16 0:46 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210101751.GA21134@arm.com \
--to=will.deacon@arm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=geoff@infradead.org \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=panand@redhat.com \
--cc=takahiro.akashi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.