From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, nico@linaro.org
Subject: Re: [PATCH] iwlegacy: mark il_adjust_beacon_interval as noinline
Date: Thu, 10 Dec 2015 12:08:02 +0100 [thread overview]
Message-ID: <20151210110801.GA2010@redhat.com> (raw)
In-Reply-To: <36263581.L8412YxJjp@wuerfel>
On Wed, Dec 09, 2015 at 05:42:41PM +0100, Arnd Bergmann wrote:
> With the new optimized do_div() code, some versions of gcc
> produce obviously incorrect code that leads to a link error
> in iwlegacy/common.o:
>
> drivers/built-in.o: In function `il_send_rxon_timing':
> :(.text+0xa6b4d4): undefined reference to `____ilog2_NaN'
> :(.text+0xa6b4f0): undefined reference to `__aeabi_uldivmod'
>
> In a few thousand randconfig builds, I have seen this problem
> a couple of times in this file, but never anywhere else in the
> kernel, so we can try to work around this in the only file
> that shows the behavior, by marking the il_adjust_beacon_interval
> function as noinline, which convinces gcc to use the unoptimized
> do_div() all the time.
I don't think this is good way to "fix" the issue, but also have
nothing against to this particular change.
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: sgruszka@redhat.com (Stanislaw Gruszka)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iwlegacy: mark il_adjust_beacon_interval as noinline
Date: Thu, 10 Dec 2015 12:08:02 +0100 [thread overview]
Message-ID: <20151210110801.GA2010@redhat.com> (raw)
In-Reply-To: <36263581.L8412YxJjp@wuerfel>
On Wed, Dec 09, 2015 at 05:42:41PM +0100, Arnd Bergmann wrote:
> With the new optimized do_div() code, some versions of gcc
> produce obviously incorrect code that leads to a link error
> in iwlegacy/common.o:
>
> drivers/built-in.o: In function `il_send_rxon_timing':
> :(.text+0xa6b4d4): undefined reference to `____ilog2_NaN'
> :(.text+0xa6b4f0): undefined reference to `__aeabi_uldivmod'
>
> In a few thousand randconfig builds, I have seen this problem
> a couple of times in this file, but never anywhere else in the
> kernel, so we can try to work around this in the only file
> that shows the behavior, by marking the il_adjust_beacon_interval
> function as noinline, which convinces gcc to use the unoptimized
> do_div() all the time.
I don't think this is good way to "fix" the issue, but also have
nothing against to this particular change.
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
next prev parent reply other threads:[~2015-12-10 11:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 16:42 [PATCH] iwlegacy: mark il_adjust_beacon_interval as noinline Arnd Bergmann
2015-12-09 16:42 ` Arnd Bergmann
2015-12-09 17:13 ` Nicolas Pitre
2015-12-09 17:13 ` Nicolas Pitre
2015-12-10 11:08 ` Stanislaw Gruszka [this message]
2015-12-10 11:08 ` Stanislaw Gruszka
2015-12-11 11:50 ` Kalle Valo
2015-12-11 11:50 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210110801.GA2010@redhat.com \
--to=sgruszka@redhat.com \
--cc=arnd@arndb.de \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.