From: mchehab@osg.samsung.com (Mauro Carvalho Chehab)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [media] staging/davinci_vfpe: allow modular build
Date: Thu, 10 Dec 2015 12:40:54 -0200 [thread overview]
Message-ID: <20151210124054.3c527f11@recife.lan> (raw)
In-Reply-To: <2029571.PWO4DcqdUl@wuerfel>
Em Thu, 10 Dec 2015 15:29:38 +0100
Arnd Bergmann <arnd@arndb.de> escreveu:
> It has never been possible to actually build this driver as
> a loadable module, only built-in because the Makefile attempts
> to build each file into its own module and fails:
>
> ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined!
> ERROR: "vpfe_resizer_register_entities" [drivers/staging/media/davinci_vpfe/vpfe_mc_capture.ko] undefined!
> ERROR: "rsz_enable" [drivers/staging/media/davinci_vpfe/dm365_resizer.ko] undefined!
> ERROR: "config_ipipe_hw" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
> ERROR: "ipipe_set_lutdpc_regs" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
>
> It took a long time to catch this bug with randconfig builds
> because at least 14 other Kconfig symbols have to be enabled in
> order to configure this one.
>
> The solution is really easy: this patch changes the Makefile to
> link all files into one module.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>
> diff --git a/drivers/staging/media/davinci_vpfe/Makefile b/drivers/staging/media/davinci_vpfe/Makefile
> index c64515c644cd..3019c9ecd548 100644
> --- a/drivers/staging/media/davinci_vpfe/Makefile
> +++ b/drivers/staging/media/davinci_vpfe/Makefile
> @@ -1,3 +1,5 @@
> -obj-$(CONFIG_VIDEO_DM365_VPFE) += \
> +obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci-vfpe.o
> +
> +davinci-vfpe-objs := \
> dm365_isif.o dm365_ipipe_hw.o dm365_ipipe.o \
> dm365_resizer.o dm365_ipipeif.o vpfe_mc_capture.o vpfe_video.o
>
That seems a bad signal to me... I guess either this driver was never
actually tested or it was tested only if compiled as built-in...
Regards,
Mauro
WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH] [media] staging/davinci_vfpe: allow modular build
Date: Thu, 10 Dec 2015 12:40:54 -0200 [thread overview]
Message-ID: <20151210124054.3c527f11@recife.lan> (raw)
In-Reply-To: <2029571.PWO4DcqdUl@wuerfel>
Em Thu, 10 Dec 2015 15:29:38 +0100
Arnd Bergmann <arnd@arndb.de> escreveu:
> It has never been possible to actually build this driver as
> a loadable module, only built-in because the Makefile attempts
> to build each file into its own module and fails:
>
> ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined!
> ERROR: "vpfe_resizer_register_entities" [drivers/staging/media/davinci_vpfe/vpfe_mc_capture.ko] undefined!
> ERROR: "rsz_enable" [drivers/staging/media/davinci_vpfe/dm365_resizer.ko] undefined!
> ERROR: "config_ipipe_hw" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
> ERROR: "ipipe_set_lutdpc_regs" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
>
> It took a long time to catch this bug with randconfig builds
> because at least 14 other Kconfig symbols have to be enabled in
> order to configure this one.
>
> The solution is really easy: this patch changes the Makefile to
> link all files into one module.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>
> diff --git a/drivers/staging/media/davinci_vpfe/Makefile b/drivers/staging/media/davinci_vpfe/Makefile
> index c64515c644cd..3019c9ecd548 100644
> --- a/drivers/staging/media/davinci_vpfe/Makefile
> +++ b/drivers/staging/media/davinci_vpfe/Makefile
> @@ -1,3 +1,5 @@
> -obj-$(CONFIG_VIDEO_DM365_VPFE) += \
> +obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci-vfpe.o
> +
> +davinci-vfpe-objs := \
> dm365_isif.o dm365_ipipe_hw.o dm365_ipipe.o \
> dm365_resizer.o dm365_ipipeif.o vpfe_mc_capture.o vpfe_video.o
>
That seems a bad signal to me... I guess either this driver was never
actually tested or it was tested only if compiled as built-in...
Regards,
Mauro
next prev parent reply other threads:[~2015-12-10 14:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 14:29 [PATCH] [media] staging/davinci_vfpe: allow modular build Arnd Bergmann
2015-12-10 14:29 ` Arnd Bergmann
2015-12-10 14:40 ` Mauro Carvalho Chehab [this message]
2015-12-10 14:40 ` Mauro Carvalho Chehab
2015-12-10 14:44 ` Sekhar Nori
2015-12-10 14:44 ` Sekhar Nori
-- strict thread matches above, loose matches on Subject: below --
2016-02-26 12:27 Arnd Bergmann
2016-02-26 12:27 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210124054.3c527f11@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.