From: Will Deacon <will.deacon@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
kernel-build-reports@lists.linaro.org,
linaro-kernel@lists.linaro.org, linux-next@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: next-20151210 build: 4 failures 43 warnings (next-20151210)
Date: Thu, 10 Dec 2015 17:14:01 +0000 [thread overview]
Message-ID: <20151210171401.GG21134@arm.com> (raw)
In-Reply-To: <20151210165513.GO5727@sirena.org.uk>
On Thu, Dec 10, 2015 at 04:55:13PM +0000, Mark Brown wrote:
> On Thu, Dec 10, 2015 at 08:06:07AM +0000, Build bot for Mark Brown wrote:
>
> Today's -next fails to build most arm64 configs with some rather
> spectacular errors below introduced by 02598e94ed5a78 (mm, printk:
> introduce new format string for flags) from Andrew's tree. These in
> turn stem from the fact that we introduce an inclusion of
> linux/tracepoint.h into linux/mmdebug.h which through a chain of nested
> inclusions means that we end up attempting to use definitions from
> headers before they have finished including. For example:
>
> > arm64-allnoconfig
> > ../include/linux/wait.h:1217:2: error: implicit declaration of function 'atomic_read' [-Werror=implicit-function-declaration]
>
> is a result of:
>
> In file included from include/linux/completion.h:11:0,
> from include/linux/rcupdate.h:43,
> from include/linux/tracepoint.h:19,
> from include/linux/mmdebug.h:6,
> from ./arch/arm64/include/asm/cmpxchg.h:22,
> from ./arch/arm64/include/asm/atomic.h:41,
> from include/linux/atomic.h:4,
> from include/linux/spinlock.h:406,
> from include/linux/seqlock.h:35,
> from include/linux/time.h:5,
> from include/uapi/linux/timex.h:56,
> from include/linux/timex.h:56,
> from include/linux/sched.h:19,
> from arch/arm64/kernel/asm-offsets.c:21:
> include/linux/wait.h: In function 'wait_on_atomic_t':
> include/linux/wait.h:1218:2: error: implicit declaration of function 'atomic_read' [-Werror=implicit-function-declaration]
> if (atomic_read(val) == 0)
>
> where atomic_read() will be defined in atomic.h which is part of the
> inclusion chain above but hasn't yet parsed far enough to actually
> define anything. This is all a bit of a horrific mess the root cause of
> which appears to be that arm64 is unusual in including linux/mmdebug.h
> in asm/cmpxchg.h which triggers the mess. There doesn't seem to be any
> reason for this inclusion, I've just sent a patch removing it. It'd be
> good to get this into -next as a matter of urgency.
I'll pick up your fix into the arm64 for-next/core branch.
Cheers,
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: next-20151210 build: 4 failures 43 warnings (next-20151210)
Date: Thu, 10 Dec 2015 17:14:01 +0000 [thread overview]
Message-ID: <20151210171401.GG21134@arm.com> (raw)
In-Reply-To: <20151210165513.GO5727@sirena.org.uk>
On Thu, Dec 10, 2015 at 04:55:13PM +0000, Mark Brown wrote:
> On Thu, Dec 10, 2015 at 08:06:07AM +0000, Build bot for Mark Brown wrote:
>
> Today's -next fails to build most arm64 configs with some rather
> spectacular errors below introduced by 02598e94ed5a78 (mm, printk:
> introduce new format string for flags) from Andrew's tree. These in
> turn stem from the fact that we introduce an inclusion of
> linux/tracepoint.h into linux/mmdebug.h which through a chain of nested
> inclusions means that we end up attempting to use definitions from
> headers before they have finished including. For example:
>
> > arm64-allnoconfig
> > ../include/linux/wait.h:1217:2: error: implicit declaration of function 'atomic_read' [-Werror=implicit-function-declaration]
>
> is a result of:
>
> In file included from include/linux/completion.h:11:0,
> from include/linux/rcupdate.h:43,
> from include/linux/tracepoint.h:19,
> from include/linux/mmdebug.h:6,
> from ./arch/arm64/include/asm/cmpxchg.h:22,
> from ./arch/arm64/include/asm/atomic.h:41,
> from include/linux/atomic.h:4,
> from include/linux/spinlock.h:406,
> from include/linux/seqlock.h:35,
> from include/linux/time.h:5,
> from include/uapi/linux/timex.h:56,
> from include/linux/timex.h:56,
> from include/linux/sched.h:19,
> from arch/arm64/kernel/asm-offsets.c:21:
> include/linux/wait.h: In function 'wait_on_atomic_t':
> include/linux/wait.h:1218:2: error: implicit declaration of function 'atomic_read' [-Werror=implicit-function-declaration]
> if (atomic_read(val) == 0)
>
> where atomic_read() will be defined in atomic.h which is part of the
> inclusion chain above but hasn't yet parsed far enough to actually
> define anything. This is all a bit of a horrific mess the root cause of
> which appears to be that arm64 is unusual in including linux/mmdebug.h
> in asm/cmpxchg.h which triggers the mess. There doesn't seem to be any
> reason for this inclusion, I've just sent a patch removing it. It'd be
> good to get this into -next as a matter of urgency.
I'll pick up your fix into the arm64 for-next/core branch.
Cheers,
Will
next prev parent reply other threads:[~2015-12-10 17:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 8:06 next-20151210 build: 4 failures 43 warnings (next-20151210) Build bot for Mark Brown
2015-12-10 16:54 ` [PATCH] arm64: cmpxchg: Don't incldue linux/mmdebug.h Mark Brown
2015-12-10 16:55 ` next-20151210 build: 4 failures 43 warnings (next-20151210) Mark Brown
2015-12-10 16:55 ` Mark Brown
2015-12-10 17:14 ` Will Deacon [this message]
2015-12-10 17:14 ` Will Deacon
2015-12-10 22:47 ` Andrew Morton
2015-12-10 22:47 ` Andrew Morton
2015-12-11 7:12 ` Vlastimil Babka
2015-12-11 7:12 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210171401.GG21134@arm.com \
--to=will.deacon@arm.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.