From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi][PATCH 1/2] ARM: dts: sun7i: Add Itead Ibox support
Date: Fri, 11 Dec 2015 11:59:30 +0100 [thread overview]
Message-ID: <20151211105930.GM27957@lukather> (raw)
In-Reply-To: <1449599344-15544-1-git-send-email-codekipper@gmail.com>
Hi,
On Tue, Dec 08, 2015 at 07:29:03PM +0100, codekipper at gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> The Itead Ibox is a multi board device based on the Allwinner A20 SoC.
> It contains the A20 Itead Core module and a base board for the external
> interfaces.
>
> The core module comes with 4GB NAND and 1GB DDR RAM.
>
> The base board to which the core board is connected provides 3 USB 2.0 Host
> ports, 1 USB 2.0 OTG, 1 uSD slot, 10/100 Ethernet port, HDMI, IR receiver,
> SPDIF and a 32-pin GPIO header. This header expands the features of core
> board by exposing the VGA pins, audio In/Out pins, SATA, SPI, I2C, UARTS,
> USB-OTG and power.
>
> As there is an A10 version of the Itead Core Module and at least one other
> base board to support then this patch partitions the device tree files with
> some consideration that these variants may be added later.
>
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/sun7i-a20-itead-core.dtsi | 83 ++++++++++++++++++
> arch/arm/boot/dts/sun7i-a20-itead-ibox.dts | 98 ++++++++++++++++++++++
> arch/arm/boot/dts/sunxi-itead-core-common.dtsi | 111 +++++++++++++++++++++++++
> 4 files changed, 293 insertions(+)
> create mode 100644 arch/arm/boot/dts/sun7i-a20-itead-core.dtsi
> create mode 100644 arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
> create mode 100644 arch/arm/boot/dts/sunxi-itead-core-common.dtsi
So, it looks like you're doing several things in this patch:
1) Create a common DTSI for all itead core variants
(sunxi-itead-core-common.dtsi)
2) Create an A20 variant of the itead core
3) Add support for a board using the A20 itead core.
Please make three different patches for this, and converting the A10
itead board would be a good idea too.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151211/36d132a4/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 1/2] ARM: dts: sun7i: Add Itead Ibox support
Date: Fri, 11 Dec 2015 11:59:30 +0100 [thread overview]
Message-ID: <20151211105930.GM27957@lukather> (raw)
In-Reply-To: <1449599344-15544-1-git-send-email-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2053 bytes --]
Hi,
On Tue, Dec 08, 2015 at 07:29:03PM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> The Itead Ibox is a multi board device based on the Allwinner A20 SoC.
> It contains the A20 Itead Core module and a base board for the external
> interfaces.
>
> The core module comes with 4GB NAND and 1GB DDR RAM.
>
> The base board to which the core board is connected provides 3 USB 2.0 Host
> ports, 1 USB 2.0 OTG, 1 uSD slot, 10/100 Ethernet port, HDMI, IR receiver,
> SPDIF and a 32-pin GPIO header. This header expands the features of core
> board by exposing the VGA pins, audio In/Out pins, SATA, SPI, I2C, UARTS,
> USB-OTG and power.
>
> As there is an A10 version of the Itead Core Module and at least one other
> base board to support then this patch partitions the device tree files with
> some consideration that these variants may be added later.
>
> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/sun7i-a20-itead-core.dtsi | 83 ++++++++++++++++++
> arch/arm/boot/dts/sun7i-a20-itead-ibox.dts | 98 ++++++++++++++++++++++
> arch/arm/boot/dts/sunxi-itead-core-common.dtsi | 111 +++++++++++++++++++++++++
> 4 files changed, 293 insertions(+)
> create mode 100644 arch/arm/boot/dts/sun7i-a20-itead-core.dtsi
> create mode 100644 arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
> create mode 100644 arch/arm/boot/dts/sunxi-itead-core-common.dtsi
So, it looks like you're doing several things in this patch:
1) Create a common DTSI for all itead core variants
(sunxi-itead-core-common.dtsi)
2) Create an A20 variant of the itead core
3) Add support for a board using the A20 itead core.
Please make three different patches for this, and converting the A10
itead board would be a good idea too.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-11 10:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 18:29 [linux-sunxi][PATCH 1/2] ARM: dts: sun7i: Add Itead Ibox support codekipper at gmail.com
2015-12-08 18:29 ` [PATCH " codekipper-Re5JQEeQqe8AvxtiuMwx3w
2015-12-08 18:29 ` [linux-sunxi][PATCH 2/2] ARM: dts: sun7i: Add audio codec to Itead Ibox codekipper at gmail.com
2015-12-08 18:29 ` [PATCH " codekipper-Re5JQEeQqe8AvxtiuMwx3w
2015-12-11 11:00 ` [linux-sunxi][PATCH " Maxime Ripard
2015-12-11 11:00 ` [PATCH " Maxime Ripard
2015-12-11 10:59 ` Maxime Ripard [this message]
2015-12-11 10:59 ` [PATCH 1/2] ARM: dts: sun7i: Add Itead Ibox support Maxime Ripard
2015-12-14 7:51 ` [linux-sunxi][PATCH " Code Kipper
2015-12-14 7:51 ` [PATCH " Code Kipper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211105930.GM27957@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.