From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: prism54: off by one BUG_ON() test
Date: Fri, 11 Dec 2015 11:23:20 +0000 [thread overview]
Message-ID: <20151211112320.5798B141ACB@smtp.codeaurora.org> (raw)
In-Reply-To: <20151204131949.GF12792@mwanda>
In-Reply-To: <20151204131949.GF12792@mwanda>
> This code was supposed to trigger a BUG() if we truncate the output but
> it's off by one so it allows one character to be truncated. Really
> drivers shouldn't call BUG_ON() and especially for something minor like
> this so I've changed it to a WARN_ON().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: prism54: off by one BUG_ON() test
Date: Fri, 11 Dec 2015 11:23:20 +0000 (UTC) [thread overview]
Message-ID: <20151211112320.5798B141ACB@smtp.codeaurora.org> (raw)
In-Reply-To: <20151204131949.GF12792@mwanda>
> This code was supposed to trigger a BUG() if we truncate the output but
> it's off by one so it allows one character to be truncated. Really
> drivers shouldn't call BUG_ON() and especially for something minor like
> this so I've changed it to a WARN_ON().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
next prev parent reply other threads:[~2015-12-11 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 13:19 [patch] prism54: off by one BUG_ON() test Dan Carpenter
2015-12-04 13:19 ` Dan Carpenter
2015-12-11 11:23 ` Kalle Valo [this message]
2015-12-11 11:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211112320.5798B141ACB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.