From: "Pali Rohár" <pali.rohar@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Thomas Hellstrom <thellstrom@vmware.com>,
jckeerthan@gmail.com, till2.schaefer@uni-dortmund.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] Input: psmouse - rearrange Focaltech init code
Date: Fri, 11 Dec 2015 12:44:45 +0100 [thread overview]
Message-ID: <20151211114445.GJ12308@pali> (raw)
In-Reply-To: <1448774036-39040-4-git-send-email-dmitry.torokhov@gmail.com>
On Saturday 28 November 2015 21:13:53 Dmitry Torokhov wrote:
> The fact that we were calling focaltech_init() even when Focaltech support
> is disabled was confusing. Rearrange the code so that if support is
> disabled we continue to fall through the rest of protocol probing code
> until we get to full reset that Focaltech devices need to work properly.
>
> Also, replace focaltech_init() with a stub now that it is only called when
> protocol is enabled.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
It's also OK, so
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Thomas Hellstrom <thellstrom@vmware.com>,
jckeerthan@gmail.com, till2.schaefer@uni-dortmund.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] Input: psmouse - rearrange Focaltech init code
Date: Fri, 11 Dec 2015 12:44:45 +0100 [thread overview]
Message-ID: <20151211114445.GJ12308@pali> (raw)
In-Reply-To: <1448774036-39040-4-git-send-email-dmitry.torokhov@gmail.com>
On Saturday 28 November 2015 21:13:53 Dmitry Torokhov wrote:
> The fact that we were calling focaltech_init() even when Focaltech support
> is disabled was confusing. Rearrange the code so that if support is
> disabled we continue to fall through the rest of protocol probing code
> until we get to full reset that Focaltech devices need to work properly.
>
> Also, replace focaltech_init() with a stub now that it is only called when
> protocol is enabled.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
It's also OK, so
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2015-12-11 11:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-29 5:13 [PATCH 0/6] Only probe select protocols on pass through PS/2 prots Dmitry Torokhov
2015-11-29 5:13 ` [PATCH 1/6] Input: psmouse - use switch statement in psmouse_process_byte() Dmitry Torokhov
2015-12-11 11:37 ` Pali Rohár
2015-11-29 5:13 ` [PATCH 2/6] Input: psmouse - fix comment style Dmitry Torokhov
2015-12-11 11:39 ` Pali Rohár
2015-11-29 5:13 ` [PATCH 3/6] Input: psmouse - rearrange Focaltech init code Dmitry Torokhov
2015-12-11 11:44 ` Pali Rohár [this message]
2015-12-11 11:44 ` Pali Rohár
2015-11-29 5:13 ` [PATCH 4/6] Input: psmouse - move protocol descriptions around Dmitry Torokhov
2015-12-11 11:46 ` Pali Rohár
2015-12-11 11:46 ` Pali Rohár
2015-11-29 5:13 ` [PATCH 5/6] Input: psmouse - factor out common protocol probing code Dmitry Torokhov
2015-12-02 15:20 ` Hans de Goede
2015-12-02 19:18 ` Dmitry Torokhov
2015-12-03 8:33 ` Hans de Goede
2015-11-29 5:13 ` [PATCH 6/6] Input: psmouse - limit protocols that we try on passthrough ports Dmitry Torokhov
2015-12-02 15:21 ` Hans de Goede
2015-12-11 11:50 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211114445.GJ12308@pali \
--to=pali.rohar@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jckeerthan@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thellstrom@vmware.com \
--cc=till2.schaefer@uni-dortmund.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.