From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/mplayer: Needs threads
Date: Sun, 13 Dec 2015 22:44:41 +0100 [thread overview]
Message-ID: <20151213214441.GE18449@free.fr> (raw)
In-Reply-To: <1450031671-24884-1-git-send-email-bernd.kuhls@t-online.de>
Bernd, all,
On 2015-12-13 19:34 +0100, Bernd Kuhls spake thusly:
> Fixes
> http://autobuild.buildroot.net/results/fc0/fc02e01514965e13ee1de8f520a5b45f63a1103e/
> http://autobuild.buildroot.net/results/b9c/b9cb712b321de4528d1a8dfb9bdfb16190bb660a/
> http://autobuild.buildroot.net/results/22a/22aa0367ff76a3024faec69c762a08a4a441f45f/
> and others
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/mplayer/Config.in | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/mplayer/Config.in b/package/mplayer/Config.in
> index 7a8b03f..686b3b0 100644
> --- a/package/mplayer/Config.in
> +++ b/package/mplayer/Config.in
> @@ -10,12 +10,17 @@ config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
> config BR2_PACKAGE_MPLAYER
> bool "mplayer"
> depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
> + depends on BR2_TOOLCHAIN_HAS_THREADS
There's an option to disable threads in mplayer, but I think it odes not
make much sense to do so, so your patch is fine with me.
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> help
> MPlayer is a movie player which runs on many systems and supports
> many different file formats.
>
> http://www.mplayerhq.hu/
>
> +comment "mplayer needs a toolchain w/ threads"
> + depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
> + depends on !BR2_TOOLCHAIN_HAS_THREADS
> +
> if BR2_PACKAGE_MPLAYER
>
> config BR2_PACKAGE_MPLAYER_MPLAYER
> --
> 2.6.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-12-13 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 18:34 [Buildroot] [PATCH 1/1] package/mplayer: Needs threads Bernd Kuhls
2015-12-13 21:44 ` Yann E. MORIN [this message]
2015-12-13 21:47 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151213214441.GE18449@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.