[Buildroot] [PATCH 1/1] package/mplayer: Needs threads

[Buildroot] [PATCH 1/1] package/mplayer: Needs threads

[Bernd Kuhls]

Fixes
http://autobuild.buildroot.net/results/fc0/fc02e01514965e13ee1de8f520a5b45f63a1103e/
http://autobuild.buildroot.net/results/b9c/b9cb712b321de4528d1a8dfb9bdfb16190bb660a/
http://autobuild.buildroot.net/results/22a/22aa0367ff76a3024faec69c762a08a4a441f45f/
and others

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/mplayer/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/mplayer/Config.in b/package/mplayer/Config.in
index 7a8b03f..686b3b0 100644
--- a/package/mplayer/Config.in
+++ b/package/mplayer/Config.in
@@ -10,12 +10,17 @@ config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
 config BR2_PACKAGE_MPLAYER
 	bool "mplayer"
 	depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  MPlayer is a movie player which runs on many systems and supports
 	  many different file formats.
 
 	  http://www.mplayerhq.hu/
 
+comment "mplayer needs a toolchain w/ threads"
+	depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
 if BR2_PACKAGE_MPLAYER
 
 config BR2_PACKAGE_MPLAYER_MPLAYER
-- 
2.6.2

[Buildroot] [PATCH 1/1] package/mplayer: Needs threads

[Yann E. MORIN]

Bernd, all,

On 2015-12-13 19:34 +0100, Bernd Kuhls spake thusly:
> Fixes
> http://autobuild.buildroot.net/results/fc0/fc02e01514965e13ee1de8f520a5b45f63a1103e/
> http://autobuild.buildroot.net/results/b9c/b9cb712b321de4528d1a8dfb9bdfb16190bb660a/
> http://autobuild.buildroot.net/results/22a/22aa0367ff76a3024faec69c762a08a4a441f45f/
> and others
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/mplayer/Config.in | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/mplayer/Config.in b/package/mplayer/Config.in
> index 7a8b03f..686b3b0 100644
> --- a/package/mplayer/Config.in
> +++ b/package/mplayer/Config.in
> @@ -10,12 +10,17 @@ config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
>  config BR2_PACKAGE_MPLAYER
>  	bool "mplayer"
>  	depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
> +	depends on BR2_TOOLCHAIN_HAS_THREADS

There's an option to disable threads in mplayer, but I think it odes not
make much sense to do so, so your patch is fine with me.

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

>  	help
>  	  MPlayer is a movie player which runs on many systems and supports
>  	  many different file formats.
>  
>  	  http://www.mplayerhq.hu/
>  
> +comment "mplayer needs a toolchain w/ threads"
> +	depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS
> +
>  if BR2_PACKAGE_MPLAYER
>  
>  config BR2_PACKAGE_MPLAYER_MPLAYER
> -- 
> 2.6.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] package/mplayer: Needs threads

[Thomas Petazzoni]

Dear Bernd Kuhls,

On Sun, 13 Dec 2015 19:34:31 +0100, Bernd Kuhls wrote:
> Fixes
> http://autobuild.buildroot.net/results/fc0/fc02e01514965e13ee1de8f520a5b45f63a1103e/
> http://autobuild.buildroot.net/results/b9c/b9cb712b321de4528d1a8dfb9bdfb16190bb660a/
> http://autobuild.buildroot.net/results/22a/22aa0367ff76a3024faec69c762a08a4a441f45f/
> and others
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/mplayer/Config.in | 5 +++++
>  1 file changed, 5 insertions(+)

I agree with Yann, we could disable thread support in Mplayer, but who
wants a big thing like Mplayer on a non-threaded system anyway?

So: applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com