From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: vf-colibri: split PWM pinctrl
Date: Mon, 14 Dec 2015 10:18:01 +0800 [thread overview]
Message-ID: <20151214021801.GA25756@tiger> (raw)
In-Reply-To: <1449094307-6011-1-git-send-email-stefan@agner.ch>
On Wed, Dec 02, 2015 at 02:11:46PM -0800, Stefan Agner wrote:
> Split PWM pins into separate pinctrl nodes to allow overrides which
> select pins individually. This is useful for carrier boards which use
> only one pin for PWM and would like to use the other pin for a
> different purpose.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/boot/dts/vf-colibri.dtsi | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
> index e5949b9..924b660 100644
> --- a/arch/arm/boot/dts/vf-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
> @@ -74,12 +74,12 @@
>
> &pwm0 {
> pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_pwm0>;
> + pinctrl-0 = <&pinctrl_pwm0_a &pinctrl_pwm0_c>;
> };
>
> &pwm1 {
> pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_pwm1>;
> + pinctrl-0 = <&pinctrl_pwm1_b &pinctrl_pwm1_d>;
> };
It may make more sense to define these pwm nodes in the final board
level dts with only defining the pins that are actually used on the
board.
Shawn
>
> &uart0 {
> @@ -195,16 +195,26 @@
> >;
> };
>
> - pinctrl_pwm0: pwm0grp {
> + pinctrl_pwm0_a: pwm0agrp {
> fsl,pins = <
> VF610_PAD_PTB0__FTM0_CH0 0x1182
> + >;
> + };
> +
> + pinctrl_pwm0_c: pwm0cgrp {
> + fsl,pins = <
> VF610_PAD_PTB1__FTM0_CH1 0x1182
> >;
> };
>
> - pinctrl_pwm1: pwm1grp {
> + pinctrl_pwm1_b: pwm1bgrp {
> fsl,pins = <
> VF610_PAD_PTB8__FTM1_CH0 0x1182
> + >;
> + };
> +
> + pinctrl_pwm1_d: pwm1dgrp {
> + fsl,pins = <
> VF610_PAD_PTB9__FTM1_CH1 0x1182
> >;
> };
> --
> 2.6.2
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
Cc: kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] ARM: dts: vf-colibri: split PWM pinctrl
Date: Mon, 14 Dec 2015 10:18:01 +0800 [thread overview]
Message-ID: <20151214021801.GA25756@tiger> (raw)
In-Reply-To: <1449094307-6011-1-git-send-email-stefan-XLVq0VzYD2Y@public.gmane.org>
On Wed, Dec 02, 2015 at 02:11:46PM -0800, Stefan Agner wrote:
> Split PWM pins into separate pinctrl nodes to allow overrides which
> select pins individually. This is useful for carrier boards which use
> only one pin for PWM and would like to use the other pin for a
> different purpose.
>
> Signed-off-by: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
> ---
> arch/arm/boot/dts/vf-colibri.dtsi | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
> index e5949b9..924b660 100644
> --- a/arch/arm/boot/dts/vf-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
> @@ -74,12 +74,12 @@
>
> &pwm0 {
> pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_pwm0>;
> + pinctrl-0 = <&pinctrl_pwm0_a &pinctrl_pwm0_c>;
> };
>
> &pwm1 {
> pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_pwm1>;
> + pinctrl-0 = <&pinctrl_pwm1_b &pinctrl_pwm1_d>;
> };
It may make more sense to define these pwm nodes in the final board
level dts with only defining the pins that are actually used on the
board.
Shawn
>
> &uart0 {
> @@ -195,16 +195,26 @@
> >;
> };
>
> - pinctrl_pwm0: pwm0grp {
> + pinctrl_pwm0_a: pwm0agrp {
> fsl,pins = <
> VF610_PAD_PTB0__FTM0_CH0 0x1182
> + >;
> + };
> +
> + pinctrl_pwm0_c: pwm0cgrp {
> + fsl,pins = <
> VF610_PAD_PTB1__FTM0_CH1 0x1182
> >;
> };
>
> - pinctrl_pwm1: pwm1grp {
> + pinctrl_pwm1_b: pwm1bgrp {
> fsl,pins = <
> VF610_PAD_PTB8__FTM1_CH0 0x1182
> + >;
> + };
> +
> + pinctrl_pwm1_d: pwm1dgrp {
> + fsl,pins = <
> VF610_PAD_PTB9__FTM1_CH1 0x1182
> >;
> };
> --
> 2.6.2
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: kernel@pengutronix.de, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: vf-colibri: split PWM pinctrl
Date: Mon, 14 Dec 2015 10:18:01 +0800 [thread overview]
Message-ID: <20151214021801.GA25756@tiger> (raw)
In-Reply-To: <1449094307-6011-1-git-send-email-stefan@agner.ch>
On Wed, Dec 02, 2015 at 02:11:46PM -0800, Stefan Agner wrote:
> Split PWM pins into separate pinctrl nodes to allow overrides which
> select pins individually. This is useful for carrier boards which use
> only one pin for PWM and would like to use the other pin for a
> different purpose.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/boot/dts/vf-colibri.dtsi | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
> index e5949b9..924b660 100644
> --- a/arch/arm/boot/dts/vf-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
> @@ -74,12 +74,12 @@
>
> &pwm0 {
> pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_pwm0>;
> + pinctrl-0 = <&pinctrl_pwm0_a &pinctrl_pwm0_c>;
> };
>
> &pwm1 {
> pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_pwm1>;
> + pinctrl-0 = <&pinctrl_pwm1_b &pinctrl_pwm1_d>;
> };
It may make more sense to define these pwm nodes in the final board
level dts with only defining the pins that are actually used on the
board.
Shawn
>
> &uart0 {
> @@ -195,16 +195,26 @@
> >;
> };
>
> - pinctrl_pwm0: pwm0grp {
> + pinctrl_pwm0_a: pwm0agrp {
> fsl,pins = <
> VF610_PAD_PTB0__FTM0_CH0 0x1182
> + >;
> + };
> +
> + pinctrl_pwm0_c: pwm0cgrp {
> + fsl,pins = <
> VF610_PAD_PTB1__FTM0_CH1 0x1182
> >;
> };
>
> - pinctrl_pwm1: pwm1grp {
> + pinctrl_pwm1_b: pwm1bgrp {
> fsl,pins = <
> VF610_PAD_PTB8__FTM1_CH0 0x1182
> + >;
> + };
> +
> + pinctrl_pwm1_d: pwm1dgrp {
> + fsl,pins = <
> VF610_PAD_PTB9__FTM1_CH1 0x1182
> >;
> };
> --
> 2.6.2
>
>
next prev parent reply other threads:[~2015-12-14 2:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 22:11 [PATCH 1/2] ARM: dts: vf-colibri: split PWM pinctrl Stefan Agner
2015-12-02 22:11 ` Stefan Agner
2015-12-02 22:11 ` [PATCH 2/2] ARM: dts: vf-colibri: add CAN support Stefan Agner
2015-12-02 22:11 ` Stefan Agner
2015-12-14 2:26 ` Shawn Guo
2015-12-14 2:26 ` Shawn Guo
2015-12-14 2:26 ` Shawn Guo
2015-12-14 2:18 ` Shawn Guo [this message]
2015-12-14 2:18 ` [PATCH 1/2] ARM: dts: vf-colibri: split PWM pinctrl Shawn Guo
2015-12-14 2:18 ` Shawn Guo
2015-12-14 2:53 ` Stefan Agner
2015-12-14 2:53 ` Stefan Agner
2015-12-14 2:53 ` Stefan Agner
2015-12-21 13:46 ` Shawn Guo
2015-12-21 13:46 ` Shawn Guo
2015-12-21 13:46 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214021801.GA25756@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.