From: Samuel Thibault <samuel.thibault@gnu.org>
To: Thomas Huth <thuth@redhat.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, Vasiliy Tolstov <v.tolstov@selfip.ru>,
Dave Gilbert <dgilbert@redhat.com>,
Gonglei <arei.gonglei@huawei.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Huangpeng <peter.huangpeng@huawei.com>,
Yang Hongyang <yanghy@cn.fujitsu.com>,
Guillaume Subiron <maethor@subiron.org>
Subject: Re: [Qemu-devel] [PATCH 7/9] slirp: Add sockaddr_equal, make solookup family-agnostic
Date: Mon, 14 Dec 2015 23:24:01 +0100 [thread overview]
Message-ID: <20151214222401.GC2967@var.home> (raw)
In-Reply-To: <566F23CF.4050701@redhat.com>
Thomas Huth, on Mon 14 Dec 2015 21:17:19 +0100, wrote:
> > + lhost.ss_family = AF_INET;
> > + ((struct sockaddr_in *)&lhost)->sin_addr = ti->ti_src;
> > + ((struct sockaddr_in *)&lhost)->sin_port = ti->ti_sport;
> > + fhost.ss_family = AF_INET;
> > + ((struct sockaddr_in *)&fhost)->sin_addr = ti->ti_dst;
> > + ((struct sockaddr_in *)&fhost)->sin_port = ti->ti_dport;
>
> Couldn't you simply use "fhost.sin.sin_addr = ..." etc. instead of
> casting everything via a pointer?
No, here fhost is a struct sockaddr_storage, which doesn't have a sin
field. We could define a struct sockaddr_in *fhost4 that would be made
an alias to fhost, but I don't feel it's more readable to introduce an
alias than expliciting those two casts.
Samuel
next prev parent reply other threads:[~2015-12-14 22:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 13:49 [Qemu-devel] [PATCHv6 0/9] slirp: Adding IPv6 support to Qemu -net user mode Samuel Thibault
2015-12-14 13:51 ` [Qemu-devel] [PATCH 1/9] slirp: goto bad in udp_input if sosendto fails Samuel Thibault
2015-12-14 13:51 ` [Qemu-devel] [PATCH 2/9] slirp: Generalizing and neutralizing ARP code Samuel Thibault
2015-12-14 14:24 ` Thomas Huth
2015-12-14 13:51 ` [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames Samuel Thibault
2015-12-14 17:50 ` Thomas Huth
2015-12-14 22:06 ` Samuel Thibault
2015-12-14 22:07 ` Samuel Thibault
2015-12-15 6:47 ` Thomas Huth
2015-12-14 13:51 ` [Qemu-devel] [PATCH 4/9] slirp: Make Socket structure IPv6 compatible Samuel Thibault
2015-12-14 19:31 ` Thomas Huth
2015-12-14 13:51 ` [Qemu-devel] [PATCH 5/9] slirp: Factorizing address translation Samuel Thibault
2015-12-14 13:51 ` [Qemu-devel] [PATCH 6/9] slirp: Factorizing and cleaning solookup() Samuel Thibault
2015-12-14 20:05 ` Thomas Huth
2015-12-14 13:51 ` [Qemu-devel] [PATCH 7/9] slirp: Add sockaddr_equal, make solookup family-agnostic Samuel Thibault
2015-12-14 20:17 ` Thomas Huth
2015-12-14 22:24 ` Samuel Thibault [this message]
2015-12-14 13:51 ` [Qemu-devel] [PATCH 8/9] slirp: Make udp_attach IPv6 compatible Samuel Thibault
2015-12-14 13:51 ` [Qemu-devel] [PATCH 9/9] slirp: Adding family argument to tcp_fconnect() Samuel Thibault
-- strict thread matches above, loose matches on Subject: below --
2015-12-19 21:24 [Qemu-devel] [PATCHv7 0/9] slirp: Adding IPv6 support to Qemu -net user mode Samuel Thibault
2015-12-19 21:24 ` [Qemu-devel] [PATCH 1/9] slirp: goto bad in udp_input if sosendto fails Samuel Thibault
2015-12-19 21:25 ` [Qemu-devel] [PATCH 7/9] slirp: Add sockaddr_equal, make solookup family-agnostic Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214222401.GC2967@var.home \
--to=samuel.thibault@gnu.org \
--cc=arei.gonglei@huawei.com \
--cc=dgilbert@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=maethor@subiron.org \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=thuth@redhat.com \
--cc=v.tolstov@selfip.ru \
--cc=yanghy@cn.fujitsu.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.