From: Thomas Huth <thuth@redhat.com>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, Vasiliy Tolstov <v.tolstov@selfip.ru>,
Dave Gilbert <dgilbert@redhat.com>,
Gonglei <arei.gonglei@huawei.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Huangpeng <peter.huangpeng@huawei.com>,
Guillaume Subiron <maethor@subiron.org>
Subject: Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames
Date: Tue, 15 Dec 2015 07:47:29 +0100 [thread overview]
Message-ID: <566FB781.7060000@redhat.com> (raw)
In-Reply-To: <20151214220616.GB2967@var.home>
On 14/12/15 23:06, Samuel Thibault wrote:
> Thomas Huth, on Mon 14 Dec 2015 18:50:49 +0100, wrote:
>>> + default:
>>> + /* Do not assert while we don't manage IP6VERSION */
>>> + /* assert(0); */
>>
>> Not sure if we ever want to have an assert() here - since I assume this
>> could be triggered by the guest?
>
> No, this is if_encap, so packets that slirp builds for the guest, so it
> shouldn't ever happen. The input side is in slirp_input(), which just
> ignores frames with unknown protocol.
OK, in that case the assert() is of course the right choice. Thanks for
the explanation!
Thomas
next prev parent reply other threads:[~2015-12-15 6:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 13:49 [Qemu-devel] [PATCHv6 0/9] slirp: Adding IPv6 support to Qemu -net user mode Samuel Thibault
2015-12-14 13:51 ` [Qemu-devel] [PATCH 1/9] slirp: goto bad in udp_input if sosendto fails Samuel Thibault
2015-12-14 13:51 ` [Qemu-devel] [PATCH 2/9] slirp: Generalizing and neutralizing ARP code Samuel Thibault
2015-12-14 14:24 ` Thomas Huth
2015-12-14 13:51 ` [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames Samuel Thibault
2015-12-14 17:50 ` Thomas Huth
2015-12-14 22:06 ` Samuel Thibault
2015-12-14 22:07 ` Samuel Thibault
2015-12-15 6:47 ` Thomas Huth [this message]
2015-12-14 13:51 ` [Qemu-devel] [PATCH 4/9] slirp: Make Socket structure IPv6 compatible Samuel Thibault
2015-12-14 19:31 ` Thomas Huth
2015-12-14 13:51 ` [Qemu-devel] [PATCH 5/9] slirp: Factorizing address translation Samuel Thibault
2015-12-14 13:51 ` [Qemu-devel] [PATCH 6/9] slirp: Factorizing and cleaning solookup() Samuel Thibault
2015-12-14 20:05 ` Thomas Huth
2015-12-14 13:51 ` [Qemu-devel] [PATCH 7/9] slirp: Add sockaddr_equal, make solookup family-agnostic Samuel Thibault
2015-12-14 20:17 ` Thomas Huth
2015-12-14 22:24 ` Samuel Thibault
2015-12-14 13:51 ` [Qemu-devel] [PATCH 8/9] slirp: Make udp_attach IPv6 compatible Samuel Thibault
2015-12-14 13:51 ` [Qemu-devel] [PATCH 9/9] slirp: Adding family argument to tcp_fconnect() Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566FB781.7060000@redhat.com \
--to=thuth@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=dgilbert@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=maethor@subiron.org \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@gnu.org \
--cc=stefanha@gmail.com \
--cc=v.tolstov@selfip.ru \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.