All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Ross Zwisler <zwisler@gmail.com>
Cc: Tony Luck <tony.luck@intel.com>,
	linux-nvdimm <linux-nvdimm@ml01.01.org>, X86 ML <x86@kernel.org>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	linux-mm@kvack.org, Andy Lutomirski <luto@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: Re: [PATCHV2 1/3] x86, ras: Add new infrastructure for machine check fixup tables
Date: Mon, 14 Dec 2015 23:27:59 +0100	[thread overview]
Message-ID: <20151214222759.GF10520@pd.tnic> (raw)
In-Reply-To: <CAOxpaSX5SH7T2AqvGoFDtEWKc9k_-77gbQXQd7FYQZ-Ep2kRhA@mail.gmail.com>

On Mon, Dec 14, 2015 at 10:58:45AM -0700, Ross Zwisler wrote:
> With this code if CONFIG_MCE_KERNEL_RECOVERY isn't defined you'll get
> a compiler error that the function doesn't have a return statement,
> right?  I think we need an #else to return NULL, or to have the #ifdef
> encompass the whole function definition as it was in Tony's version.

Right, correct.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Ross Zwisler <zwisler@gmail.com>
Cc: Tony Luck <tony.luck@intel.com>,
	linux-nvdimm <linux-nvdimm@ml01.01.org>, X86 ML <x86@kernel.org>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	linux-mm@kvack.org, Andy Lutomirski <luto@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: Re: [PATCHV2 1/3] x86, ras: Add new infrastructure for machine check fixup tables
Date: Mon, 14 Dec 2015 23:27:59 +0100	[thread overview]
Message-ID: <20151214222759.GF10520@pd.tnic> (raw)
In-Reply-To: <CAOxpaSX5SH7T2AqvGoFDtEWKc9k_-77gbQXQd7FYQZ-Ep2kRhA@mail.gmail.com>

On Mon, Dec 14, 2015 at 10:58:45AM -0700, Ross Zwisler wrote:
> With this code if CONFIG_MCE_KERNEL_RECOVERY isn't defined you'll get
> a compiler error that the function doesn't have a return statement,
> right?  I think we need an #else to return NULL, or to have the #ifdef
> encompass the whole function definition as it was in Tony's version.

Right, correct.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

  reply	other threads:[~2015-12-14 22:28 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 19:13 [PATCHV2 0/3] Machine check recovery when kernel accesses poison Tony Luck
2015-12-11 19:13 ` Tony Luck
2015-12-10 21:58 ` [PATCHV2 1/3] x86, ras: Add new infrastructure for machine check fixup tables Tony Luck
2015-12-10 21:58   ` Tony Luck
2015-12-11 20:06   ` Andy Lutomirski
2015-12-11 20:06     ` Andy Lutomirski
2015-12-11 21:01     ` Luck, Tony
2015-12-11 21:01       ` Luck, Tony
2015-12-12 10:11   ` Borislav Petkov
2015-12-12 10:11     ` Borislav Petkov
2015-12-14 17:58     ` Ross Zwisler
2015-12-14 17:58       ` Ross Zwisler
2015-12-14 22:27       ` Borislav Petkov [this message]
2015-12-14 22:27         ` Borislav Petkov
2015-12-15  1:00     ` Luck, Tony
2015-12-15  1:00       ` Luck, Tony
2015-12-15  9:46       ` Borislav Petkov
2015-12-15  9:46         ` Borislav Petkov
2015-12-15 10:44         ` Borislav Petkov
2015-12-15 10:44           ` Borislav Petkov
2015-12-11  0:14 ` [PATCHV2 2/3] x86, ras: Extend machine check recovery code to annotated ring0 areas Tony Luck
2015-12-11  0:14   ` Tony Luck
2015-12-11 20:08   ` Andy Lutomirski
2015-12-11 20:08     ` Andy Lutomirski
2015-12-15 11:43   ` Borislav Petkov
2015-12-15 11:43     ` Borislav Petkov
2015-12-15 23:46     ` Luck, Tony
2015-12-15 23:46       ` Luck, Tony
2015-12-11  0:21 ` [PATCHV2 3/3] x86, ras: Add mcsafe_memcpy() function to recover from machine checks Tony Luck
2015-12-11  0:21   ` Tony Luck
2015-12-11 20:09   ` Andy Lutomirski
2015-12-11 20:09     ` Andy Lutomirski
2015-12-11 21:19     ` Luck, Tony
2015-12-11 21:19       ` Luck, Tony
2015-12-11 21:32       ` Konrad Rzeszutek Wilk
2015-12-11 21:50       ` Andy Lutomirski
2015-12-11 21:50         ` Andy Lutomirski
2015-12-11 22:17         ` Luck, Tony
2015-12-11 22:17           ` Luck, Tony
2015-12-11 22:20           ` Dan Williams
2015-12-11 22:20             ` Dan Williams
2015-12-11 22:26             ` Andy Lutomirski
2015-12-11 22:26               ` Andy Lutomirski
2015-12-11 22:35               ` Luck, Tony
2015-12-11 22:35                 ` Luck, Tony
2015-12-11 22:38                 ` Andy Lutomirski
2015-12-11 22:38                   ` Andy Lutomirski
2015-12-11 22:45                   ` Luck, Tony
2015-12-11 22:45                     ` Luck, Tony
2015-12-11 22:55                     ` Andy Lutomirski
2015-12-11 22:55                       ` Andy Lutomirski
2015-12-14  8:36                       ` Ingo Molnar
2015-12-14  8:36                         ` Ingo Molnar
2015-12-14 19:46                         ` Luck, Tony
2015-12-14 19:46                           ` Luck, Tony
2015-12-14 20:11                           ` Andy Lutomirski
2015-12-14 20:11                             ` Andy Lutomirski
2015-12-15 13:11   ` Borislav Petkov
2015-12-15 13:11     ` Borislav Petkov
2015-12-15 17:45     ` Dan Williams
2015-12-15 17:45       ` Dan Williams
2015-12-15 17:53       ` Luck, Tony
2015-12-15 17:53         ` Luck, Tony
2015-12-15 18:21         ` Borislav Petkov
2015-12-15 18:21           ` Borislav Petkov
2015-12-15 18:27         ` Dan Williams
2015-12-15 18:27           ` Dan Williams
2015-12-15 18:35           ` Dan Williams
2015-12-15 18:35             ` Dan Williams
2015-12-15 18:39             ` Borislav Petkov
2015-12-15 18:39               ` Borislav Petkov
2015-12-15 19:19               ` Elliott, Robert (Persistent Memory)
2015-12-15 19:19                 ` Elliott, Robert (Persistent Memory)
2015-12-15 19:28                 ` Borislav Petkov
2015-12-15 19:28                   ` Borislav Petkov
2015-12-15 20:25                   ` Elliott, Robert (Persistent Memory)
2015-12-15 20:25                     ` Elliott, Robert (Persistent Memory)
2015-12-21 17:33                     ` Borislav Petkov
2015-12-21 17:33                       ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151214222759.GF10520@pd.tnic \
    --to=bp@alien8.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=ross.zwisler@linux.intel.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=zwisler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.