All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: "Stefan Müller-Klieser" <s.mueller-klieser@phytec.de>
Cc: meta-ti@yoctoproject.org
Subject: Re: [PATCH] linux-ti-staging: Work around to avoid race condition with external module
Date: Tue, 15 Dec 2015 11:32:54 -0500	[thread overview]
Message-ID: <20151215163253.GG23133@edge> (raw)
In-Reply-To: <566EB0CE.5030706@phytec.de>

Stefan,

Yes, indeed, thanks.


Sam,

You only picked up part of the fix:
http://cgit.openembedded.org/openembedded-core/commit/?id=afcea61e8eb39234d336c706fdfd4680dea7c060

I don't want to overlay the entire module-base.bbclass, so I guess for our 
problematic out-of-tree modules we can just add this to their recipes:

do_configure[depends] += "virtual/kernel:do_compile_kernelmodules"

-- 
Denys


On Mon, Dec 14, 2015 at 01:06:38PM +0100, Stefan Müller-Klieser wrote:
> Hi,
> 
> this work around introduces another race condition, as you have to make
> sure every external module recipe depends on
> do_compile_kernelmodules, and not shared_workdir.
> 
> Regards,
> Stefan
> 
> 
> On 14.12.2015 12:47, Sam Nelson wrote:
> >- Currently there is an issue with compiling external kernel module
> >which depends on symbols from another kernel module which is part of the
> >list of modules configured to be built as modules in the default config.
> >- This work around allows to avoid the issue by copying the module
> >symbols to the kernel directory after making the kernel modules build.
> >- This issue is already fixed in oe-core: master branch as of date
> >- This is just work around before updating to latest oe-core
> >
> >Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> >---
> >  recipes-kernel/linux/linux-ti-staging_3.14.bb | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> >diff --git a/recipes-kernel/linux/linux-ti-staging_3.14.bb b/recipes-kernel/linux/linux-ti-staging_3.14.bb
> >index 54530e4..88950ae 100644
> >--- a/recipes-kernel/linux/linux-ti-staging_3.14.bb
> >+++ b/recipes-kernel/linux/linux-ti-staging_3.14.bb
> >@@ -65,3 +65,7 @@ KERNEL_GIT_PROTOCOL = "git"
> >  SRC_URI += "${KERNEL_GIT_URI};protocol=${KERNEL_GIT_PROTOCOL};branch=${BRANCH} \
> >              file://defconfig \
> >             "
> >+
> >+do_compile_kernelmodules_append() {
> >+	cp Module.symvers ${STAGING_KERNEL_BUILDDIR}/
> >+}
> >
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti


  reply	other threads:[~2015-12-15 16:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-14 11:47 [PATCH] linux-ti-staging: Work around to avoid race condition with external module Sam Nelson
2015-12-14 12:06 ` Stefan Müller-Klieser
2015-12-15 16:32   ` Denys Dmytriyenko [this message]
2015-12-16 18:24     ` Nelson, Sam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151215163253.GG23133@edge \
    --to=denys@ti.com \
    --cc=meta-ti@yoctoproject.org \
    --cc=s.mueller-klieser@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.