[PATCH] linux-ti-staging: Work around to avoid race condition with external module

[PATCH] linux-ti-staging: Work around to avoid race condition with external module

[Sam Nelson]

- Currently there is an issue with compiling external kernel module
which depends on symbols from another kernel module which is part of the
list of modules configured to be built as modules in the default config.
- This work around allows to avoid the issue by copying the module
symbols to the kernel directory after making the kernel modules build.
- This issue is already fixed in oe-core: master branch as of date
- This is just work around before updating to latest oe-core

Signed-off-by: Sam Nelson <sam.nelson@ti.com>
---
 recipes-kernel/linux/linux-ti-staging_3.14.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/recipes-kernel/linux/linux-ti-staging_3.14.bb b/recipes-kernel/linux/linux-ti-staging_3.14.bb
index 54530e4..88950ae 100644
--- a/recipes-kernel/linux/linux-ti-staging_3.14.bb
+++ b/recipes-kernel/linux/linux-ti-staging_3.14.bb
@@ -65,3 +65,7 @@ KERNEL_GIT_PROTOCOL = "git"
 SRC_URI += "${KERNEL_GIT_URI};protocol=${KERNEL_GIT_PROTOCOL};branch=${BRANCH} \
             file://defconfig \
            "
+
+do_compile_kernelmodules_append() {
+	cp Module.symvers ${STAGING_KERNEL_BUILDDIR}/
+}
-- 
1.9.1

Re: [PATCH] linux-ti-staging: Work around to avoid race condition with external module

[Stefan Müller-Klieser]

Hi,

this work around introduces another race condition, as you have to make
sure every external module recipe depends on do_compile_kernelmodules, 
and not shared_workdir.

Regards,
Stefan


On 14.12.2015 12:47, Sam Nelson wrote:
> - Currently there is an issue with compiling external kernel module
> which depends on symbols from another kernel module which is part of the
> list of modules configured to be built as modules in the default config.
> - This work around allows to avoid the issue by copying the module
> symbols to the kernel directory after making the kernel modules build.
> - This issue is already fixed in oe-core: master branch as of date
> - This is just work around before updating to latest oe-core
>
> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> ---
>   recipes-kernel/linux/linux-ti-staging_3.14.bb | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/recipes-kernel/linux/linux-ti-staging_3.14.bb b/recipes-kernel/linux/linux-ti-staging_3.14.bb
> index 54530e4..88950ae 100644
> --- a/recipes-kernel/linux/linux-ti-staging_3.14.bb
> +++ b/recipes-kernel/linux/linux-ti-staging_3.14.bb
> @@ -65,3 +65,7 @@ KERNEL_GIT_PROTOCOL = "git"
>   SRC_URI += "${KERNEL_GIT_URI};protocol=${KERNEL_GIT_PROTOCOL};branch=${BRANCH} \
>               file://defconfig \
>              "
> +
> +do_compile_kernelmodules_append() {
> +	cp Module.symvers ${STAGING_KERNEL_BUILDDIR}/
> +}
>

Re: [PATCH] linux-ti-staging: Work around to avoid race condition with external module

[Denys Dmytriyenko]

Stefan,

Yes, indeed, thanks.


Sam,

You only picked up part of the fix:
http://cgit.openembedded.org/openembedded-core/commit/?id=afcea61e8eb39234d336c706fdfd4680dea7c060

I don't want to overlay the entire module-base.bbclass, so I guess for our 
problematic out-of-tree modules we can just add this to their recipes:

do_configure[depends] += "virtual/kernel:do_compile_kernelmodules"

-- 
Denys


On Mon, Dec 14, 2015 at 01:06:38PM +0100, Stefan Müller-Klieser wrote:
> Hi,
> 
> this work around introduces another race condition, as you have to make
> sure every external module recipe depends on
> do_compile_kernelmodules, and not shared_workdir.
> 
> Regards,
> Stefan
> 
> 
> On 14.12.2015 12:47, Sam Nelson wrote:
> >- Currently there is an issue with compiling external kernel module
> >which depends on symbols from another kernel module which is part of the
> >list of modules configured to be built as modules in the default config.
> >- This work around allows to avoid the issue by copying the module
> >symbols to the kernel directory after making the kernel modules build.
> >- This issue is already fixed in oe-core: master branch as of date
> >- This is just work around before updating to latest oe-core
> >
> >Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> >---
> >  recipes-kernel/linux/linux-ti-staging_3.14.bb | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> >diff --git a/recipes-kernel/linux/linux-ti-staging_3.14.bb b/recipes-kernel/linux/linux-ti-staging_3.14.bb
> >index 54530e4..88950ae 100644
> >--- a/recipes-kernel/linux/linux-ti-staging_3.14.bb
> >+++ b/recipes-kernel/linux/linux-ti-staging_3.14.bb
> >@@ -65,3 +65,7 @@ KERNEL_GIT_PROTOCOL = "git"
> >  SRC_URI += "${KERNEL_GIT_URI};protocol=${KERNEL_GIT_PROTOCOL};branch=${BRANCH} \
> >              file://defconfig \
> >             "
> >+
> >+do_compile_kernelmodules_append() {
> >+	cp Module.symvers ${STAGING_KERNEL_BUILDDIR}/
> >+}
> >
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti

Re: [PATCH] linux-ti-staging: Work around to avoid race condition with external module

[Nelson, Sam]

Ok. I will go ahead send an update to the one affected module to take care of the other part.
With regards,
Sam

> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Tuesday, December 15, 2015 11:33 AM
> To: Stefan Müller-Klieser
> Cc: Nelson, Sam; meta-ti@yoctoproject.org
> Subject: Re: [meta-ti] [PATCH] linux-ti-staging: Work around to avoid race
> condition with external module
> 
> Stefan,
> 
> Yes, indeed, thanks.
> 
> 
> Sam,
> 
> You only picked up part of the fix:
> http://cgit.openembedded.org/openembedded-
> core/commit/?id=afcea61e8eb39234d336c706fdfd4680dea7c060
> 
> I don't want to overlay the entire module-base.bbclass, so I guess for our
> problematic out-of-tree modules we can just add this to their recipes:
> 
> do_configure[depends] += "virtual/kernel:do_compile_kernelmodules"
> 
> --
> Denys
> 
> 
> On Mon, Dec 14, 2015 at 01:06:38PM +0100, Stefan Müller-Klieser wrote:
> > Hi,
> >
> > this work around introduces another race condition, as you have to make
> > sure every external module recipe depends on
> > do_compile_kernelmodules, and not shared_workdir.
> >
> > Regards,
> > Stefan
> >
> >
> > On 14.12.2015 12:47, Sam Nelson wrote:
> > >- Currently there is an issue with compiling external kernel module
> > >which depends on symbols from another kernel module which is part of the
> > >list of modules configured to be built as modules in the default config.
> > >- This work around allows to avoid the issue by copying the module
> > >symbols to the kernel directory after making the kernel modules build.
> > >- This issue is already fixed in oe-core: master branch as of date
> > >- This is just work around before updating to latest oe-core
> > >
> > >Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > >---
> > >  recipes-kernel/linux/linux-ti-staging_3.14.bb | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > >diff --git a/recipes-kernel/linux/linux-ti-staging_3.14.bb b/recipes-
> kernel/linux/linux-ti-staging_3.14.bb
> > >index 54530e4..88950ae 100644
> > >--- a/recipes-kernel/linux/linux-ti-staging_3.14.bb
> > >+++ b/recipes-kernel/linux/linux-ti-staging_3.14.bb
> > >@@ -65,3 +65,7 @@ KERNEL_GIT_PROTOCOL = "git"
> > >  SRC_URI +=
> "${KERNEL_GIT_URI};protocol=${KERNEL_GIT_PROTOCOL};branch=${BRANCH}
> \
> > >              file://defconfig \
> > >             "
> > >+
> > >+do_compile_kernelmodules_append() {
> > >+	cp Module.symvers ${STAGING_KERNEL_BUILDDIR}/
> > >+}
> > >
> > --
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti