From: Greg KH <gregkh@linuxfoundation.org>
To: Sudeep Biswas <sudeep.biswas@st.com>
Cc: DCG_UPD_stlinux_kernel@list.st.com,
Will Deacon <will.deacon@arm.com>,
stable@vger.kernel.org,
Russell King <rmk+kernel@arm.linux.org.uk>
Subject: Re: [PATCH v1.0(linux-sti-3.10) SDK2.15_x 3/4] ARM: 8191/1: decompressor: ensure I-side picks up relocated code
Date: Tue, 15 Dec 2015 09:02:22 -0800 [thread overview]
Message-ID: <20151215170222.GC18302@kroah.com> (raw)
In-Reply-To: <1450191476-14078-4-git-send-email-sudeep.biswas@st.com>
On Tue, Dec 15, 2015 at 08:27:55PM +0530, Sudeep Biswas wrote:
> From: Will Deacon <will.deacon@arm.com>
>
> To speed up decompression, the decompressor sets up a flat, cacheable
> mapping of memory. However, when there is insufficient space to hold
> the page tables for this mapping, we don't bother to enable the caches
> and subsequently skip all the cache maintenance hooks.
>
> Skipping the cache maintenance before jumping to the relocated code
> allows the processor to predict the branch and populate the I-cache
> with stale data before the relocation loop has completed (since a
> bootloader may have SCTLR.I set, which permits normal, cacheable
> instruction fetches regardless of SCTLR.M).
>
> This patch moves the cache maintenance check into the maintenance
> routines themselves, allowing the v6/v7 versions to invalidate the
> I-cache regardless of the MMU state.
>
> Cc: <stable@vger.kernel.org>
> Reported-by: Marc Carino <marc.ceeeee@gmail.com>
> Tested-by: Julien Grall <julien.grall@linaro.org>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> (cherry picked from commit 238962ac71910d6c20162ea5230685fead1836a4)
>
> Buglink: https://stintbugzilla.st.com/show_bug.cgi?id=89771
>
> Signed-off-by: Sudeep Biswas <sudeep.biswas@st.com>
> ---
> arch/arm/boot/compressed/head.S | 20 ++++++++++++++++----
> 1 files changed, 16 insertions(+), 4 deletions(-)
I don't understand, this is a very old patch, why are you sending it out
again, and what stable tree do you want it applied to that it is not
already in?
confused,
greg k-h
next prev parent reply other threads:[~2015-12-15 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1450191476-14078-1-git-send-email-sudeep.biswas@st.com>
2015-12-15 14:57 ` [PATCH v1.0(linux-sti-3.10) SDK2.15_x 3/4] ARM: 8191/1: decompressor: ensure I-side picks up relocated code Sudeep Biswas
2015-12-15 17:02 ` Greg KH [this message]
2015-12-15 17:16 ` Sudeep BISWAS DCG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215170222.GC18302@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=DCG_UPD_stlinux_kernel@list.st.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=stable@vger.kernel.org \
--cc=sudeep.biswas@st.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.