All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Juri Lelli <juri.lelli@arm.com>, Rob Herring <robh@kernel.org>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	peterz@infradead.org, vincent.guittot@linaro.org,
	linux@arm.linux.org.uk, sudeep.holla@arm.com,
	lorenzo.pieralisi@arm.com, catalin.marinas@arm.com,
	will.deacon@arm.com, morten.rasmussen@arm.com,
	dietmar.eggemann@arm.com, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Olof Johansson <olof@lixom.net>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	Paul Walmsley <paul@pwsan.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [RFC PATCH 2/8] Documentation: arm: define DT cpu capacity bindings
Date: Tue, 15 Dec 2015 18:10:03 +0000	[thread overview]
Message-ID: <20151215181002.GA8568@leverpostej> (raw)
In-Reply-To: <20151215174516.GB5727@sirena.org.uk>

On Tue, Dec 15, 2015 at 05:45:16PM +0000, Mark Brown wrote:
> On Tue, Dec 15, 2015 at 05:28:37PM +0000, Mark Rutland wrote:
> > On Tue, Dec 15, 2015 at 05:17:13PM +0000, Mark Brown wrote:
> 
> > > Obviously people are going to get upset if we introduce performance
> > > regressions - but that's true always, we can also introduce problems
> > > with numbers people have put in DT.  It seems like it'd be harder to
> > > manage regressions due to externally provided magic numbers since
> > > there's inherently less information there.
> 
> > It's certainly still possible to have regressions in that case. Those
> > regressions would be due to code changes in the kernel, given the DT
> > didn't change.
> 
> > I'm not sure I follow w.r.t. "inherently less information", unless you
> > mean trying to debug without access to that DTB?
> 
> If what the kernel knows about the system is that it's got a bunch of
> cores with numbers assigned to them then all it's really got is those
> numbers.  If something changes that causes problems for some systems
> (eg, because the numbers have been picked poorly but in a way that
> happened to work well with the old code) that's not a lot to go on, the
> more we know about the system the more likely it is that we'll be able
> to adjust the assumptions in whatever new thing we do that causes
> problems for any particular systems where we run into trouble.

Regardless of where the numbers live (DT or kernel), all we have are
numbers. I can see that changing the in-kernel numbers would be possible
when modifyign the DT is not, but I don't see how that gives you more
information.

Mark.

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/8] Documentation: arm: define DT cpu capacity bindings
Date: Tue, 15 Dec 2015 18:10:03 +0000	[thread overview]
Message-ID: <20151215181002.GA8568@leverpostej> (raw)
In-Reply-To: <20151215174516.GB5727@sirena.org.uk>

On Tue, Dec 15, 2015 at 05:45:16PM +0000, Mark Brown wrote:
> On Tue, Dec 15, 2015 at 05:28:37PM +0000, Mark Rutland wrote:
> > On Tue, Dec 15, 2015 at 05:17:13PM +0000, Mark Brown wrote:
> 
> > > Obviously people are going to get upset if we introduce performance
> > > regressions - but that's true always, we can also introduce problems
> > > with numbers people have put in DT.  It seems like it'd be harder to
> > > manage regressions due to externally provided magic numbers since
> > > there's inherently less information there.
> 
> > It's certainly still possible to have regressions in that case. Those
> > regressions would be due to code changes in the kernel, given the DT
> > didn't change.
> 
> > I'm not sure I follow w.r.t. "inherently less information", unless you
> > mean trying to debug without access to that DTB?
> 
> If what the kernel knows about the system is that it's got a bunch of
> cores with numbers assigned to them then all it's really got is those
> numbers.  If something changes that causes problems for some systems
> (eg, because the numbers have been picked poorly but in a way that
> happened to work well with the old code) that's not a lot to go on, the
> more we know about the system the more likely it is that we'll be able
> to adjust the assumptions in whatever new thing we do that causes
> problems for any particular systems where we run into trouble.

Regardless of where the numbers live (DT or kernel), all we have are
numbers. I can see that changing the in-kernel numbers would be possible
when modifyign the DT is not, but I don't see how that gives you more
information.

Mark.

  reply	other threads:[~2015-12-15 18:10 UTC|newest]

Thread overview: 135+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23 14:28 [RFC PATCH 0/8] CPUs capacity information for heterogeneous systems Juri Lelli
2015-11-23 14:28 ` Juri Lelli
2015-11-23 14:28 ` [RFC PATCH 1/8] ARM: initialize cpu_scale to its default Juri Lelli
2015-11-23 14:28   ` Juri Lelli
2015-11-30 11:13   ` Vincent Guittot
2015-11-30 11:13     ` Vincent Guittot
2015-11-23 14:28 ` [RFC PATCH 2/8] Documentation: arm: define DT cpu capacity bindings Juri Lelli
2015-11-23 14:28   ` Juri Lelli
2015-11-23 14:28   ` Juri Lelli
2015-11-24  2:06   ` Rob Herring
2015-11-24  2:06     ` Rob Herring
2015-11-24 10:54     ` Juri Lelli
2015-11-24 10:54       ` Juri Lelli
2015-11-24 10:54       ` Juri Lelli
2015-11-30  9:59       ` Vincent Guittot
2015-11-30  9:59         ` Vincent Guittot
2015-11-30  9:59         ` Vincent Guittot
2015-12-01 11:20         ` Juri Lelli
2015-12-01 11:20           ` Juri Lelli
2015-12-01 11:20           ` Juri Lelli
2015-12-10 14:14           ` Dietmar Eggemann
2015-12-10 14:14             ` Dietmar Eggemann
2015-12-10 14:14             ` Dietmar Eggemann
2015-12-11 10:09             ` Juri Lelli
2015-12-11 10:09               ` Juri Lelli
2015-12-11 10:09               ` Juri Lelli
2015-12-10 15:30     ` Mark Brown
2015-12-10 15:30       ` Mark Brown
2015-12-10 15:30       ` Mark Brown
2015-12-10 17:58       ` Juri Lelli
2015-12-10 17:58         ` Juri Lelli
2015-12-11 17:49         ` Mark Brown
2015-12-11 17:49           ` Mark Brown
     [not found]           ` <20151211174940.GQ5727-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-12-14 12:36             ` Juri Lelli
2015-12-14 12:36               ` Juri Lelli
2015-12-14 12:36               ` Juri Lelli
2015-12-14 16:59               ` Mark Brown
2015-12-14 16:59                 ` Mark Brown
2015-12-15 12:22                 ` Juri Lelli
2015-12-15 12:22                   ` Juri Lelli
2015-12-15 13:39                   ` Mark Brown
2015-12-15 13:39                     ` Mark Brown
2015-12-15 14:01                     ` Mark Rutland
2015-12-15 14:01                       ` Mark Rutland
2015-12-15 14:24                       ` Juri Lelli
2015-12-15 14:24                         ` Juri Lelli
2015-12-15 14:50                         ` Mark Rutland
2015-12-15 14:50                           ` Mark Rutland
2015-12-15 14:50                           ` Mark Rutland
2015-12-15 15:36                           ` Juri Lelli
2015-12-15 15:36                             ` Juri Lelli
2015-12-15 15:36                             ` Juri Lelli
2015-12-15 15:08                       ` Mark Brown
2015-12-15 15:08                         ` Mark Brown
     [not found]                         ` <20151215150813.GZ5727-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-12-15 15:32                           ` Mark Rutland
2015-12-15 15:32                             ` Mark Rutland
2015-12-15 15:32                             ` Mark Rutland
2015-12-15 15:46                             ` Juri Lelli
2015-12-15 15:46                               ` Juri Lelli
2015-12-15 15:46                               ` Juri Lelli
2015-12-15 15:57                               ` Mark Rutland
2015-12-15 15:57                                 ` Mark Rutland
2015-12-15 16:23                                 ` Catalin Marinas
2015-12-15 16:23                                   ` Catalin Marinas
2015-12-15 16:41                                   ` Mark Rutland
2015-12-15 16:41                                     ` Mark Rutland
2015-12-15 16:59                                     ` Vincent Guittot
2015-12-15 16:59                                       ` Vincent Guittot
2015-12-15 16:59                                       ` Vincent Guittot
     [not found]                                       ` <CAKfTPtAuosPcL8bbQ27Y-vUE1h4QRY8hGESnm4YrxqRAQ3K=5g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-15 17:15                                         ` Mark Rutland
2015-12-15 17:15                                           ` Mark Rutland
2015-12-15 17:15                                           ` Mark Rutland
2015-12-15 17:47                                           ` Vincent Guittot
2015-12-15 17:47                                             ` Vincent Guittot
2015-12-15 17:47                                             ` Vincent Guittot
     [not found]                                             ` <CAKfTPtBzWcNHx+Fi7hUabNpPsd1thFAkPnLcpsnqbQp6Qq24cQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-15 18:39                                               ` Mark Rutland
2015-12-15 18:39                                                 ` Mark Rutland
2015-12-15 18:39                                                 ` Mark Rutland
2015-12-15 17:17                             ` Mark Brown
2015-12-15 17:17                               ` Mark Brown
     [not found]                               ` <20151215171713.GA5727-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-12-15 17:28                                 ` Mark Rutland
2015-12-15 17:28                                   ` Mark Rutland
2015-12-15 17:28                                   ` Mark Rutland
2015-12-15 17:45                                   ` Mark Brown
2015-12-15 17:45                                     ` Mark Brown
2015-12-15 18:10                                     ` Mark Rutland [this message]
2015-12-15 18:10                                       ` Mark Rutland
2015-12-15 18:45                                       ` Mark Brown
2015-12-15 18:45                                         ` Mark Brown
2015-12-17  9:07                                     ` Juri Lelli
2015-12-17  9:07                                       ` Juri Lelli
2015-12-15 13:55                   ` Vincent Guittot
2015-12-15 13:55                     ` Vincent Guittot
2015-12-15 13:55                     ` Vincent Guittot
2015-11-23 14:28 ` [RFC PATCH 3/8] arm: parse cpu capacity from DT Juri Lelli
2015-11-23 14:28   ` Juri Lelli
2015-11-23 14:28   ` Juri Lelli
2015-12-10 14:14   ` Dietmar Eggemann
2015-12-10 14:14     ` Dietmar Eggemann
     [not found]     ` <566988DD.9080005-5wv7dgnIgG8@public.gmane.org>
2015-12-11 10:12       ` Juri Lelli
2015-12-11 10:12         ` Juri Lelli
2015-12-11 10:12         ` Juri Lelli
2015-11-23 14:28 ` [RFC PATCH 4/8] arm, dts: add TC2 cpu capacity information Juri Lelli
2015-11-23 14:28   ` Juri Lelli
2015-11-23 14:28 ` [RFC PATCH 5/8] arm64: parse cpu capacity from DT Juri Lelli
2015-11-23 14:28   ` Juri Lelli
2015-12-10 14:15   ` Dietmar Eggemann
2015-12-10 14:15     ` Dietmar Eggemann
2015-12-11 10:07     ` Juri Lelli
2015-12-11 10:07       ` Juri Lelli
2015-11-23 14:28 ` [RFC PATCH 6/8] arm64, dts: add Juno cpu capacity information Juri Lelli
2015-11-23 14:28   ` Juri Lelli
2015-11-23 14:28 ` [RFC PATCH 7/8] arm: add sysfs cpu_capacity attribute Juri Lelli
2015-11-23 14:28   ` Juri Lelli
2015-11-23 14:28 ` [RFC PATCH 8/8] arm64: " Juri Lelli
2015-11-23 14:28   ` Juri Lelli
2015-12-10 14:15   ` Dietmar Eggemann
2015-12-10 14:15     ` Dietmar Eggemann
2015-12-10 15:59     ` Mark Brown
2015-12-10 15:59       ` Mark Brown
2015-12-10 18:01       ` Juri Lelli
2015-12-10 18:01         ` Juri Lelli
2015-12-11 17:54         ` Mark Brown
2015-12-11 17:54           ` Mark Brown
2015-12-07 12:02 ` [RFC PATCH 0/8] CPUs capacity information for heterogeneous systems Juri Lelli
2015-12-07 12:02   ` Juri Lelli
2015-12-07 12:11   ` Russell King - ARM Linux
2015-12-07 12:11     ` Russell King - ARM Linux
2015-12-07 12:36     ` Juri Lelli
2015-12-07 12:36       ` Juri Lelli
2015-12-07 13:18       ` Russell King - ARM Linux
2015-12-07 13:18         ` Russell King - ARM Linux
     [not found]         ` <20151207131843.GP8644-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-12-07 15:41           ` Juri Lelli
2015-12-07 15:41             ` Juri Lelli
2015-12-07 15:41             ` Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151215181002.GA8568@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=galak@codeaurora.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=juri.lelli@arm.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=morten.rasmussen@arm.com \
    --cc=olof@lixom.net \
    --cc=paul@pwsan.com \
    --cc=pawel.moll@arm.com \
    --cc=peterz@infradead.org \
    --cc=robh@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=vincent.guittot@linaro.org \
    --cc=wens@csie.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.