From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: Dept-GELinuxNICDev@qlogic.com, manish.chopra@qlogic.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
rajesh.borundia@qlogic.com
Subject: Re: [patch v2] qlcnic: fix a timeout loop
Date: Tue, 15 Dec 2015 20:13:50 +0000 [thread overview]
Message-ID: <20151215201350.GI5177@mwanda> (raw)
In-Reply-To: <20151215.131341.175421419282676757.davem@davemloft.net>
On Tue, Dec 15, 2015 at 01:13:41PM -0500, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Tue, 15 Dec 2015 16:56:16 +0300
>
> > The problem here is that at the end of the loop we test for if
> > idc->vnic_wait_limit is zero, but since idc->vnic_wait_limit-- is a
> > post-op, it actually ends up set to (u8)-1. I have fixed this by
> > moving the decrement inside the loop.
> >
> > Fixes: 486a5bc77a4a ('qlcnic: Add support for 83xx suspend and resume.')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Applied.
Ugh... I appologize, I just noticed a mistake in this one. I have to
do the decrement at the end of the loop and not the start of the loop.
I will send a fix for that on top of this fix.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: Dept-GELinuxNICDev@qlogic.com, manish.chopra@qlogic.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
rajesh.borundia@qlogic.com
Subject: Re: [patch v2] qlcnic: fix a timeout loop
Date: Tue, 15 Dec 2015 23:13:50 +0300 [thread overview]
Message-ID: <20151215201350.GI5177@mwanda> (raw)
In-Reply-To: <20151215.131341.175421419282676757.davem@davemloft.net>
On Tue, Dec 15, 2015 at 01:13:41PM -0500, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Tue, 15 Dec 2015 16:56:16 +0300
>
> > The problem here is that at the end of the loop we test for if
> > idc->vnic_wait_limit is zero, but since idc->vnic_wait_limit-- is a
> > post-op, it actually ends up set to (u8)-1. I have fixed this by
> > moving the decrement inside the loop.
> >
> > Fixes: 486a5bc77a4a ('qlcnic: Add support for 83xx suspend and resume.')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Applied.
Ugh... I appologize, I just noticed a mistake in this one. I have to
do the decrement at the end of the loop and not the start of the loop.
I will send a fix for that on top of this fix.
regards,
dan carpenter
next prev parent reply other threads:[~2015-12-15 20:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 10:16 [patch] qlcnic: fix a timeout loop Dan Carpenter
2015-12-15 10:16 ` Dan Carpenter
2015-12-15 13:46 ` Manish Chopra
2015-12-15 13:56 ` [patch v2] " Dan Carpenter
2015-12-15 13:56 ` Dan Carpenter
2015-12-15 18:13 ` David Miller
2015-12-15 18:13 ` David Miller
2015-12-15 20:13 ` Dan Carpenter [this message]
2015-12-15 20:13 ` Dan Carpenter
2015-12-15 20:17 ` Dan Carpenter
2015-12-15 20:17 ` Dan Carpenter
2015-12-24 9:21 ` [patch] qlcnic: fix a loop exit condition better Dan Carpenter
2015-12-24 9:21 ` Dan Carpenter
2015-12-24 16:02 ` David Miller
2015-12-24 16:02 ` David Miller
2016-01-04 13:19 ` [patch v2] qlcnic: fix a timeout loop Yann Dupont - Veille Techno
2016-01-05 19:30 ` Dan Carpenter
2015-12-15 16:35 ` [patch] " walter harms
2015-12-15 16:35 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215201350.GI5177@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Dept-GELinuxNICDev@qlogic.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=manish.chopra@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=rajesh.borundia@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.