* [patch] wil6210: fix a warning message condition
@ 2015-12-16 11:10 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2015-12-16 11:10 UTC (permalink / raw)
To: Maya Erez; +Cc: Kalle Valo, linux-wireless, wil6210, kernel-janitors
"iter" is -1 at the end of the loop and not zero. It means we don't
print a warning message.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/ath/wil6210/main.c b/drivers/net/wireless/ath/wil6210/main.c
index 48687f1..4544e8c 100644
--- a/drivers/net/wireless/ath/wil6210/main.c
+++ b/drivers/net/wireless/ath/wil6210/main.c
@@ -985,7 +985,7 @@ int __wil_down(struct wil6210_priv *wil)
}
mutex_lock(&wil->mutex);
- if (!iter)
+ if (iter < 0)
wil_err(wil, "timeout waiting for idle FW/HW\n");
wil_reset(wil, false);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [patch] wil6210: fix a warning message condition
@ 2015-12-16 11:10 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2015-12-16 11:10 UTC (permalink / raw)
To: Maya Erez; +Cc: Kalle Valo, linux-wireless, wil6210, kernel-janitors
"iter" is -1 at the end of the loop and not zero. It means we don't
print a warning message.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/ath/wil6210/main.c b/drivers/net/wireless/ath/wil6210/main.c
index 48687f1..4544e8c 100644
--- a/drivers/net/wireless/ath/wil6210/main.c
+++ b/drivers/net/wireless/ath/wil6210/main.c
@@ -985,7 +985,7 @@ int __wil_down(struct wil6210_priv *wil)
}
mutex_lock(&wil->mutex);
- if (!iter)
+ if (iter < 0)
wil_err(wil, "timeout waiting for idle FW/HW\n");
wil_reset(wil, false);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [patch] wil6210: fix a warning message condition
2015-12-16 11:10 ` Dan Carpenter
(?)
@ 2015-12-16 12:55 ` Haim, Maya
-1 siblings, 0 replies; 5+ messages in thread
From: Haim, Maya @ 2015-12-16 12:55 UTC (permalink / raw)
To: Dan Carpenter, qca_merez
Cc: Kalle Valo, linux-wireless@vger.kernel.org, wil6210,
kernel-janitors@vger.kernel.org
Acked-by: Maya Erez <qca_merez@qca.qualcomm.com>
-----Original Message-----
From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
Sent: Wednesday, December 16, 2015 1:10 PM
To: qca_merez
Cc: Kalle Valo; linux-wireless@vger.kernel.org; wil6210; kernel-janitors@vger.kernel.org
Subject: [patch] wil6210: fix a warning message condition
"iter" is -1 at the end of the loop and not zero. It means we don't print a warning message.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/ath/wil6210/main.c b/drivers/net/wireless/ath/wil6210/main.c
index 48687f1..4544e8c 100644
--- a/drivers/net/wireless/ath/wil6210/main.c
+++ b/drivers/net/wireless/ath/wil6210/main.c
@@ -985,7 +985,7 @@ int __wil_down(struct wil6210_priv *wil)
}
mutex_lock(&wil->mutex);
- if (!iter)
+ if (iter < 0)
wil_err(wil, "timeout waiting for idle FW/HW\n");
wil_reset(wil, false);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [patch] wil6210: fix a warning message condition
2015-12-16 11:10 ` Dan Carpenter
@ 2015-12-31 13:13 ` Kalle Valo
-1 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2015-12-31 13:13 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Maya Erez, linux-wireless, wil6210, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> writes:
> "iter" is -1 at the end of the loop and not zero. It means we don't
> print a warning message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to ath.git, thanks.
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-12-31 13:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-16 11:10 [patch] wil6210: fix a warning message condition Dan Carpenter
2015-12-16 11:10 ` Dan Carpenter
2015-12-16 12:55 ` Haim, Maya
2015-12-31 13:13 ` Kalle Valo
2015-12-31 13:13 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.