* [patch] ASoC: Intel: Skylake: Fix a couple signedness bugs
@ 2015-12-12 12:38 ` Dan Carpenter
0 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2015-12-12 12:38 UTC (permalink / raw)
To: Liam Girdwood, Dharageswari R
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Vinod Koul, Jeeja KP,
Subhransu S. Prusty, alsa-devel, kernel-janitors
These need to be unsigned because they hold negative error codes.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/intel/skylake/skl-sst.c b/sound/soc/intel/skylake/skl-sst.c
index 8cd5cdb..e26f474 100644
--- a/sound/soc/intel/skylake/skl-sst.c
+++ b/sound/soc/intel/skylake/skl-sst.c
@@ -208,7 +208,7 @@ static unsigned int skl_get_errorcode(struct sst_dsp *ctx)
* since get/set_module are called from DAPM context,
* we don't need lock for usage count
*/
-static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
+static int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
{
struct skl_module_table *module;
@@ -220,7 +220,7 @@ static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
return -EINVAL;
}
-static unsigned int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
+static int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
{
struct skl_module_table *module;
@@ -340,7 +340,7 @@ static int skl_load_module(struct sst_dsp *ctx, u16 mod_id, char *guid)
static int skl_unload_module(struct sst_dsp *ctx, u16 mod_id)
{
- unsigned int usage_cnt;
+ int usage_cnt;
struct skl_sst *skl = ctx->thread_context;
int ret = 0;
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [patch] ASoC: Intel: Skylake: Fix a couple signedness bugs
2015-12-12 12:38 ` Dan Carpenter
@ 2015-12-16 14:56 ` Vinod Koul
-1 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2015-12-16 14:44 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Dharageswari R, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Jeeja KP, Subhransu S. Prusty, alsa-devel,
kernel-janitors
On Sat, Dec 12, 2015 at 03:38:15PM +0300, Dan Carpenter wrote:
> These need to be unsigned because they hold negative error codes.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
>
> diff --git a/sound/soc/intel/skylake/skl-sst.c b/sound/soc/intel/skylake/skl-sst.c
> index 8cd5cdb..e26f474 100644
> --- a/sound/soc/intel/skylake/skl-sst.c
> +++ b/sound/soc/intel/skylake/skl-sst.c
> @@ -208,7 +208,7 @@ static unsigned int skl_get_errorcode(struct sst_dsp *ctx)
> * since get/set_module are called from DAPM context,
> * we don't need lock for usage count
> */
> -static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
> +static int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
> {
> struct skl_module_table *module;
>
> @@ -220,7 +220,7 @@ static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
> return -EINVAL;
> }
>
> -static unsigned int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
> +static int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
> {
> struct skl_module_table *module;
>
> @@ -340,7 +340,7 @@ static int skl_load_module(struct sst_dsp *ctx, u16 mod_id, char *guid)
>
> static int skl_unload_module(struct sst_dsp *ctx, u16 mod_id)
> {
> - unsigned int usage_cnt;
> + int usage_cnt;
> struct skl_sst *skl = ctx->thread_context;
> int ret = 0;
>
>
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [patch] ASoC: Intel: Skylake: Fix a couple signedness bugs
@ 2015-12-16 14:56 ` Vinod Koul
0 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2015-12-16 14:56 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Dharageswari R, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Jeeja KP, Subhransu S. Prusty, alsa-devel,
kernel-janitors
On Sat, Dec 12, 2015 at 03:38:15PM +0300, Dan Carpenter wrote:
> These need to be unsigned because they hold negative error codes.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
>
> diff --git a/sound/soc/intel/skylake/skl-sst.c b/sound/soc/intel/skylake/skl-sst.c
> index 8cd5cdb..e26f474 100644
> --- a/sound/soc/intel/skylake/skl-sst.c
> +++ b/sound/soc/intel/skylake/skl-sst.c
> @@ -208,7 +208,7 @@ static unsigned int skl_get_errorcode(struct sst_dsp *ctx)
> * since get/set_module are called from DAPM context,
> * we don't need lock for usage count
> */
> -static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
> +static int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
> {
> struct skl_module_table *module;
>
> @@ -220,7 +220,7 @@ static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
> return -EINVAL;
> }
>
> -static unsigned int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
> +static int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
> {
> struct skl_module_table *module;
>
> @@ -340,7 +340,7 @@ static int skl_load_module(struct sst_dsp *ctx, u16 mod_id, char *guid)
>
> static int skl_unload_module(struct sst_dsp *ctx, u16 mod_id)
> {
> - unsigned int usage_cnt;
> + int usage_cnt;
> struct skl_sst *skl = ctx->thread_context;
> int ret = 0;
>
>
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [patch] ASoC: Intel: Skylake: Fix a couple signedness bugs
2015-12-16 14:56 ` Vinod Koul
@ 2015-12-16 14:55 ` Dan Carpenter
-1 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2015-12-16 14:55 UTC (permalink / raw)
To: Vinod Koul
Cc: Liam Girdwood, Dharageswari R, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Jeeja KP, Subhransu S. Prusty, alsa-devel,
kernel-janitors
On Wed, Dec 16, 2015 at 08:14:00PM +0530, Vinod Koul wrote:
> On Sat, Dec 12, 2015 at 03:38:15PM +0300, Dan Carpenter wrote:
> > These need to be unsigned because they hold negative error codes.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: Vinod Koul <vinod.koul@intel.com>
Sorry, I sent a v2 of this with "be unsigned" changed to "be signed" in
the changelog, but I messed up the In-Reply-To header so it was a new
thread.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] ASoC: Intel: Skylake: Fix a couple signedness bugs
@ 2015-12-16 14:55 ` Dan Carpenter
0 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2015-12-16 14:55 UTC (permalink / raw)
To: Vinod Koul
Cc: Liam Girdwood, Dharageswari R, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Jeeja KP, Subhransu S. Prusty, alsa-devel,
kernel-janitors
On Wed, Dec 16, 2015 at 08:14:00PM +0530, Vinod Koul wrote:
> On Sat, Dec 12, 2015 at 03:38:15PM +0300, Dan Carpenter wrote:
> > These need to be unsigned because they hold negative error codes.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: Vinod Koul <vinod.koul@intel.com>
Sorry, I sent a v2 of this with "be unsigned" changed to "be signed" in
the changelog, but I messed up the In-Reply-To header so it was a new
thread.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] ASoC: Intel: Skylake: Fix a couple signedness bugs
2015-12-16 14:55 ` Dan Carpenter
@ 2015-12-16 15:59 ` Vinod Koul
-1 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2015-12-16 15:56 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Dharageswari R, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Jeeja KP, Subhransu S. Prusty, alsa-devel,
kernel-janitors
On Wed, Dec 16, 2015 at 05:55:18PM +0300, Dan Carpenter wrote:
> On Wed, Dec 16, 2015 at 08:14:00PM +0530, Vinod Koul wrote:
> > On Sat, Dec 12, 2015 at 03:38:15PM +0300, Dan Carpenter wrote:
> > > These need to be unsigned because they hold negative error codes.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > Acked-by: Vinod Koul <vinod.koul@intel.com>
>
> Sorry, I sent a v2 of this with "be unsigned" changed to "be signed" in
> the changelog, but I messed up the In-Reply-To header so it was a new
> thread.
No issues, Acked v2 now :)
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] ASoC: Intel: Skylake: Fix a couple signedness bugs
@ 2015-12-16 15:59 ` Vinod Koul
0 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2015-12-16 15:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Dharageswari R, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Jeeja KP, Subhransu S. Prusty, alsa-devel,
kernel-janitors
On Wed, Dec 16, 2015 at 05:55:18PM +0300, Dan Carpenter wrote:
> On Wed, Dec 16, 2015 at 08:14:00PM +0530, Vinod Koul wrote:
> > On Sat, Dec 12, 2015 at 03:38:15PM +0300, Dan Carpenter wrote:
> > > These need to be unsigned because they hold negative error codes.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > Acked-by: Vinod Koul <vinod.koul@intel.com>
>
> Sorry, I sent a v2 of this with "be unsigned" changed to "be signed" in
> the changelog, but I messed up the In-Reply-To header so it was a new
> thread.
No issues, Acked v2 now :)
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
* Applied "ASoC: Intel: Skylake: Fix a couple signedness bugs" to the asoc tree
2015-12-12 12:38 ` Dan Carpenter
(?)
(?)
@ 2015-12-16 19:24 ` Mark Brown
-1 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2015-12-16 19:24 UTC (permalink / raw)
To: Dan Carpenter, Mark Brown; +Cc: alsa-devel
The patch
ASoC: Intel: Skylake: Fix a couple signedness bugs
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From db4e561378b539230feb4db5e7d5d548c2db2cd4 Mon Sep 17 00:00:00 2001
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 15 Dec 2015 12:20:14 +0300
Subject: [PATCH] ASoC: Intel: Skylake: Fix a couple signedness bugs
These need to be signed because they hold negative error codes.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/skylake/skl-sst.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/intel/skylake/skl-sst.c b/sound/soc/intel/skylake/skl-sst.c
index 8cd5cdb21fd5..e26f4746afb7 100644
--- a/sound/soc/intel/skylake/skl-sst.c
+++ b/sound/soc/intel/skylake/skl-sst.c
@@ -208,7 +208,7 @@ static unsigned int skl_get_errorcode(struct sst_dsp *ctx)
* since get/set_module are called from DAPM context,
* we don't need lock for usage count
*/
-static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
+static int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
{
struct skl_module_table *module;
@@ -220,7 +220,7 @@ static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
return -EINVAL;
}
-static unsigned int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
+static int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
{
struct skl_module_table *module;
@@ -340,7 +340,7 @@ static int skl_load_module(struct sst_dsp *ctx, u16 mod_id, char *guid)
static int skl_unload_module(struct sst_dsp *ctx, u16 mod_id)
{
- unsigned int usage_cnt;
+ int usage_cnt;
struct skl_sst *skl = ctx->thread_context;
int ret = 0;
--
2.6.2
^ permalink raw reply related [flat|nested] 9+ messages in thread