From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sasha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
arnd-r2nGTMty4D4@public.gmane.org,
Tomasz Figa <tfiga-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Daniel Kurtz <djkurtz-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver
Date: Wed, 16 Dec 2015 16:15:15 +0100 [thread overview]
Message-ID: <20151216151514.GI18805@8bytes.org> (raw)
In-Reply-To: <5670098E.40601-5wv7dgnIgG8@public.gmane.org>
On Tue, Dec 15, 2015 at 12:37:34PM +0000, Robin Murphy wrote:
> The potential issue I *do* see, looking more closely, is that
> iommu_group_get_for_dev() is setting group->domain but not calling
> the attach_dev callback, which looks wrong...
Attaching the device happens from iommu_group_add_device(), which is
called from iommu_group_get_for_dev() right after the domains are
allocated/initialized.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: joro@8bytes.org (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver
Date: Wed, 16 Dec 2015 16:15:15 +0100 [thread overview]
Message-ID: <20151216151514.GI18805@8bytes.org> (raw)
In-Reply-To: <5670098E.40601@arm.com>
On Tue, Dec 15, 2015 at 12:37:34PM +0000, Robin Murphy wrote:
> The potential issue I *do* see, looking more closely, is that
> iommu_group_get_for_dev() is setting group->domain but not calling
> the attach_dev callback, which looks wrong...
Attaching the device happens from iommu_group_add_device(), which is
called from iommu_group_get_for_dev() right after the domains are
allocated/initialized.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Yong Wu <yong.wu@mediatek.com>,
Thierry Reding <treding@nvidia.com>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Will Deacon <will.deacon@arm.com>,
Daniel Kurtz <djkurtz@google.com>, Tomasz Figa <tfiga@google.com>,
Lucas Stach <l.stach@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-mediatek@lists.infradead.org,
Sasha Hauer <kernel@pengutronix.de>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, pebolle@tiscali.nl,
arnd@arndb.de, mitchelh@codeaurora.org, p.zabel@pengutronix.de,
yingjoe.chen@mediatek.com
Subject: Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver
Date: Wed, 16 Dec 2015 16:15:15 +0100 [thread overview]
Message-ID: <20151216151514.GI18805@8bytes.org> (raw)
In-Reply-To: <5670098E.40601@arm.com>
On Tue, Dec 15, 2015 at 12:37:34PM +0000, Robin Murphy wrote:
> The potential issue I *do* see, looking more closely, is that
> iommu_group_get_for_dev() is setting group->domain but not calling
> the attach_dev callback, which looks wrong...
Attaching the device happens from iommu_group_add_device(), which is
called from iommu_group_get_for_dev() right after the domains are
allocated/initialized.
Joerg
next prev parent reply other threads:[~2015-12-16 15:15 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 9:49 [PATCH v6 0/5] MT8173 IOMMU SUPPORT Yong Wu
2015-12-08 9:49 ` Yong Wu
2015-12-08 9:49 ` Yong Wu
2015-12-08 9:49 ` [PATCH v6 1/5] dt-bindings: iommu: Add binding for mediatek IOMMU Yong Wu
2015-12-08 9:49 ` Yong Wu
2015-12-08 9:49 ` Yong Wu
[not found] ` <1449568153-15643-2-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-12-09 3:33 ` Rob Herring
2015-12-09 3:33 ` Rob Herring
2015-12-09 3:33 ` Rob Herring
2015-12-09 6:55 ` Yong Wu
2015-12-09 6:55 ` Yong Wu
2015-12-09 6:55 ` Yong Wu
2015-12-08 9:49 ` [PATCH v6 2/5] dt-bindings: mediatek: Add smi dts binding Yong Wu
2015-12-08 9:49 ` Yong Wu
2015-12-08 9:49 ` Yong Wu
[not found] ` <1449568153-15643-3-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-12-09 3:35 ` Rob Herring
2015-12-09 3:35 ` Rob Herring
2015-12-09 3:35 ` Rob Herring
2015-12-08 9:49 ` [PATCH v6 3/5] memory: mediatek: Add SMI driver Yong Wu
2015-12-08 9:49 ` Yong Wu
2015-12-08 9:49 ` Yong Wu
[not found] ` <1449568153-15643-4-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-12-11 7:22 ` Yong Wu
2015-12-11 7:22 ` Yong Wu
2015-12-11 7:22 ` Yong Wu
2015-12-14 18:18 ` Matthias Brugger
2015-12-14 18:18 ` Matthias Brugger
[not found] ` <24171857.0SPpBlzoZl-FL1YVkE3Js+HtQ08XqlRiA@public.gmane.org>
2015-12-15 2:38 ` Yong Wu
2015-12-15 2:38 ` Yong Wu
2015-12-15 2:38 ` Yong Wu
2015-12-15 5:45 ` Daniel Kurtz
2015-12-15 5:45 ` Daniel Kurtz
2015-12-15 5:45 ` Daniel Kurtz
[not found] ` <CAGS+omDTt646fH3p7kA+EHkR93xGX0APu1sOEjY7MCzQfpO8DA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-16 6:00 ` Yong Wu
2015-12-16 6:00 ` Yong Wu
2015-12-16 6:00 ` Yong Wu
2015-12-08 9:49 ` [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver Yong Wu
2015-12-08 9:49 ` Yong Wu
2015-12-08 9:49 ` Yong Wu
2015-12-08 10:32 ` kbuild test robot
2015-12-08 10:32 ` kbuild test robot
2015-12-08 10:32 ` kbuild test robot
[not found] ` <1449568153-15643-5-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-12-14 14:16 ` Joerg Roedel
2015-12-14 14:16 ` Joerg Roedel
2015-12-14 14:16 ` Joerg Roedel
[not found] ` <20151214141656.GG18805-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-12-15 3:28 ` Yong Wu
2015-12-15 3:28 ` Yong Wu
2015-12-15 3:28 ` Yong Wu
2015-12-15 12:37 ` Robin Murphy
2015-12-15 12:37 ` Robin Murphy
2015-12-15 12:37 ` Robin Murphy
[not found] ` <5670098E.40601-5wv7dgnIgG8@public.gmane.org>
2015-12-16 5:59 ` Yong Wu
2015-12-16 5:59 ` Yong Wu
2015-12-16 5:59 ` Yong Wu
2015-12-16 12:48 ` Robin Murphy
2015-12-16 12:48 ` Robin Murphy
2015-12-16 12:48 ` Robin Murphy
[not found] ` <56715D8D.3050102-5wv7dgnIgG8@public.gmane.org>
2015-12-17 3:12 ` Yong Wu
2015-12-17 3:12 ` Yong Wu
2015-12-17 3:12 ` Yong Wu
2015-12-16 15:15 ` Joerg Roedel [this message]
2015-12-16 15:15 ` Joerg Roedel
2015-12-16 15:15 ` Joerg Roedel
2015-12-14 18:19 ` Matthias Brugger
2015-12-14 18:19 ` Matthias Brugger
2015-12-14 18:19 ` Matthias Brugger
[not found] ` <566F0821.4080507-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-15 2:40 ` Yong Wu
2015-12-15 2:40 ` Yong Wu
2015-12-15 2:40 ` Yong Wu
[not found] ` <1449568153-15643-1-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-12-08 9:49 ` [PATCH v6 5/5] dts: mt8173: Add iommu/smi nodes for mt8173 Yong Wu
2015-12-08 9:49 ` Yong Wu
2015-12-08 9:49 ` Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151216151514.GI18805@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=djkurtz-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
--cc=srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=tfiga-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
--cc=yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.