All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/5] lib: Add wait_for_bit
Date: Thu, 17 Dec 2015 00:52:23 +0100	[thread overview]
Message-ID: <201512170052.23759.marex@denx.de> (raw)
In-Reply-To: <5671F48A.90606@gmail.com>

On Thursday, December 17, 2015 at 12:32:26 AM, Mateusz Kulikowski wrote:
> Hi Marek,

Hi,

> On 16.12.2015 23:11, Marek Vasut wrote:
> > On Wednesday, December 16, 2015 at 10:58:38 PM, Mateusz Kulikowski wrote:
> [...]
> 
> >> +#include <console.h>
> >> +#include <asm/io.h>
> >> +#include <asm/errno.h>
> >> +
> >> +int wait_for_bit(const char *prefix, const u32 *reg, const u32 mask,
> >> +		 const bool set, const unsigned int timeout,
> >> +		 const bool breakable)
> >> +{
> > 
> > I wonder, what would happen if you stuffed this function into the header
> > file altogether ? I think this would allow the compiler to do
> > interprocedure optimalization on whichever file this would be included
> > into. I wonder if that would have any impact on the resulting code size.
> 
> Of course I can make it static inline.
> 
> I was suggested not to care about possible leftovers that are
> not garbage-collected by linker so didn't changed that on V2.
> 
> It's (max) few bytes that may be consumed by section alignment.

I was just curious about how much difference this would make.

Best regards,
Marek Vasut

  reply	other threads:[~2015-12-16 23:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 21:58 [U-Boot] [PATCH v2 0/5] Add wait_for_bit() Mateusz Kulikowski
2015-12-16 21:58 ` [U-Boot] [PATCH v2 1/5] lib: Add wait_for_bit Mateusz Kulikowski
2015-12-16 22:11   ` Marek Vasut
2015-12-16 23:32     ` Mateusz Kulikowski
2015-12-16 23:52       ` Marek Vasut [this message]
2015-12-20 16:19         ` Mateusz Kulikowski
2015-12-16 21:58 ` [U-Boot] [PATCH v2 2/5] usb: dwc2: Use shared wait_for_bit Mateusz Kulikowski
2015-12-16 21:58 ` [U-Boot] [PATCH v2 3/5] usb: ohci-lpc32xx: " Mateusz Kulikowski
2015-12-16 21:58 ` [U-Boot] [PATCH v2 4/5] usb: ehci-mx6: " Mateusz Kulikowski
2015-12-16 21:58 ` [U-Boot] [PATCH v2 5/5] net: zynq_gem: " Mateusz Kulikowski
2015-12-17 13:57 ` [U-Boot] [PATCH v2 0/5] Add wait_for_bit() LEMIEUX, SYLVAIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201512170052.23759.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.