From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: qla2xxx-upstream@qlogic.com,
Atul Deshmukh <atul.deshmukh@qlogic.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [patch] qla2xxx: fix a timeout loop
Date: Thu, 17 Dec 2015 10:46:24 +0000 [thread overview]
Message-ID: <20151217104624.GO5177@mwanda> (raw)
In-Reply-To: <yq1lh8ut3di.fsf@sermon.lab.mkp.net>
On Wed, Dec 16, 2015 at 05:50:17PM -0500, Martin K. Petersen wrote:
> >>>>> "Dan" = Dan Carpenter <dan.carpenter@oracle.com> writes:
>
> Dan> After the loop we test for "if (!retries) " as a failure, but
> Dan> actually the post-op here will end with retries set to -1. I have
> Dan> fixed this by using a pre-op instead.
>
> Applied to 4.4/scsi-fixes.
>
The qlogic devs asked me to redo this patch but you have already applied
it. Should I resend or redo it on top of the earlier patch. (James's
tree was rebaseable for a day after a patch was "applied".)
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: qla2xxx-upstream@qlogic.com,
Atul Deshmukh <atul.deshmukh@qlogic.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [patch] qla2xxx: fix a timeout loop
Date: Thu, 17 Dec 2015 13:46:24 +0300 [thread overview]
Message-ID: <20151217104624.GO5177@mwanda> (raw)
In-Reply-To: <yq1lh8ut3di.fsf@sermon.lab.mkp.net>
On Wed, Dec 16, 2015 at 05:50:17PM -0500, Martin K. Petersen wrote:
> >>>>> "Dan" == Dan Carpenter <dan.carpenter@oracle.com> writes:
>
> Dan> After the loop we test for "if (!retries) " as a failure, but
> Dan> actually the post-op here will end with retries set to -1. I have
> Dan> fixed this by using a pre-op instead.
>
> Applied to 4.4/scsi-fixes.
>
The qlogic devs asked me to redo this patch but you have already applied
it. Should I resend or redo it on top of the earlier patch. (James's
tree was rebaseable for a day after a patch was "applied".)
regards,
dan carpenter
next prev parent reply other threads:[~2015-12-17 10:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 11:07 [patch] qla2xxx: fix a timeout loop Dan Carpenter
2015-12-16 11:07 ` Dan Carpenter
2015-12-16 11:45 ` Johannes Thumshirn
2015-12-16 11:45 ` Johannes Thumshirn
2015-12-16 22:50 ` Martin K. Petersen
2015-12-16 22:50 ` Martin K. Petersen
2015-12-17 10:46 ` Dan Carpenter [this message]
2015-12-17 10:46 ` Dan Carpenter
2015-12-17 16:47 ` Martin K. Petersen
2015-12-17 16:47 ` Martin K. Petersen
2015-12-17 1:25 ` Himanshu Madhani
2015-12-17 1:25 ` Himanshu Madhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217104624.GO5177@mwanda \
--to=dan.carpenter@oracle.com \
--cc=JBottomley@odin.com \
--cc=atul.deshmukh@qlogic.com \
--cc=jthumshirn@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=qla2xxx-upstream@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.