From: Phil Sutter <phil@nwl.cc>
To: Dmitrii Shcherbakov <fw.dmitrii@yandex.com>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev <device_name> ' command
Date: Thu, 17 Dec 2015 14:11:30 +0100 [thread overview]
Message-ID: <20151217131130.GC1980@orbyte.ovh.net> (raw)
In-Reply-To: <907481450345533@web24h.yandex.ru>
On Thu, Dec 17, 2015 at 12:45:33PM +0300, Dmitrii Shcherbakov wrote:
> >I don't think your patch should contain this cleanup of "b4".
>
> It seems that b3 is only used for the legacy overhead part and if I remove it, b3 is not going to be used. So I figured I remove b4 put b3 instead.
No worries, your intentions are good per se. All he wants from you is to
split changes up: a dedicated patch for mpu->overhead conversion and a
second one dedicated for SPRINT_BUF variable cleanup.
HTH, Phil
prev parent reply other threads:[~2015-12-17 13:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 11:09 [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev <device_name> ' command Dmitrii Shcherbakov
2015-12-16 15:15 ` Jesper Dangaard Brouer
2015-12-16 16:04 ` Phil Sutter
2015-12-16 20:56 ` Dmitrii Shcherbakov
2015-12-18 16:39 ` Dmitrii Shcherbakov
2015-12-18 16:55 ` Phil Sutter
2015-12-18 21:45 ` Dmitrii Shcherbakov
2015-12-22 5:45 ` Stephen Hemminger
2015-12-17 9:27 ` Dmitrii Shcherbakov
2015-12-17 9:45 ` Dmitrii Shcherbakov
2015-12-17 13:11 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217131130.GC1980@orbyte.ovh.net \
--to=phil@nwl.cc \
--cc=brouer@redhat.com \
--cc=fw.dmitrii@yandex.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.