From: Wolfram Sang <wsa@the-dreams.de>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Simon Horman <horms@verge.net.au>,
Bjorn Helgaas <bhelgaas@google.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 4/4] PCI: rcar: Add Gen2 PHY setup to pcie-rcar
Date: Thu, 17 Dec 2015 14:33:08 +0100 [thread overview]
Message-ID: <20151217133308.GB20372@katana> (raw)
In-Reply-To: <1450358557-28376-5-git-send-email-phil.edworthy@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
> + rcar_pci_write_reg(pcie, 0x000f0030, GEN2_PCIEPHYADDR);
> + rcar_pci_write_reg(pcie, 0x00381203, GEN2_PCIEPHYDATA);
> + rcar_pci_write_reg(pcie, 0x00000001, GEN2_PCIEPHYCTRL);
> + rcar_pci_write_reg(pcie, 0x00000006, GEN2_PCIEPHYCTRL);
> +
> + rcar_pci_write_reg(pcie, 0x000f0054, GEN2_PCIEPHYADDR);
> + /* The following value is for DC connection, no termination resistor */
> + rcar_pci_write_reg(pcie, 0x13802007, GEN2_PCIEPHYDATA);
> + rcar_pci_write_reg(pcie, 0x00000001, GEN2_PCIEPHYCTRL);
> + rcar_pci_write_reg(pcie, 0x00000006, GEN2_PCIEPHYCTRL);
I'd vote for a comment saying where these magic values come from, i.e.
which manual, which chapter, etc...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Simon Horman <horms@verge.net.au>,
Bjorn Helgaas <bhelgaas@google.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 4/4] PCI: rcar: Add Gen2 PHY setup to pcie-rcar
Date: Thu, 17 Dec 2015 13:33:08 +0000 [thread overview]
Message-ID: <20151217133308.GB20372@katana> (raw)
In-Reply-To: <1450358557-28376-5-git-send-email-phil.edworthy@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
> + rcar_pci_write_reg(pcie, 0x000f0030, GEN2_PCIEPHYADDR);
> + rcar_pci_write_reg(pcie, 0x00381203, GEN2_PCIEPHYDATA);
> + rcar_pci_write_reg(pcie, 0x00000001, GEN2_PCIEPHYCTRL);
> + rcar_pci_write_reg(pcie, 0x00000006, GEN2_PCIEPHYCTRL);
> +
> + rcar_pci_write_reg(pcie, 0x000f0054, GEN2_PCIEPHYADDR);
> + /* The following value is for DC connection, no termination resistor */
> + rcar_pci_write_reg(pcie, 0x13802007, GEN2_PCIEPHYDATA);
> + rcar_pci_write_reg(pcie, 0x00000001, GEN2_PCIEPHYCTRL);
> + rcar_pci_write_reg(pcie, 0x00000006, GEN2_PCIEPHYCTRL);
I'd vote for a comment saying where these magic values come from, i.e.
which manual, which chapter, etc...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-17 13:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 13:22 [PATCH 0/4] Various R-Car PCIe patches Phil Edworthy
2015-12-17 13:22 ` Phil Edworthy
2015-12-17 13:22 ` [PATCH 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar Phil Edworthy
2015-12-17 13:22 ` Phil Edworthy
2015-12-17 13:22 ` [PATCH 2/4] PCI: rcar: Support runtime PM link state L1 handling " Phil Edworthy
2015-12-17 13:22 ` Phil Edworthy
2015-12-17 13:30 ` Wolfram Sang
2015-12-17 13:30 ` Wolfram Sang
2015-12-17 13:41 ` Geert Uytterhoeven
2015-12-17 13:41 ` Geert Uytterhoeven
2015-12-18 13:44 ` Phil Edworthy
2015-12-18 13:44 ` Phil Edworthy
2015-12-18 13:42 ` Phil Edworthy
2015-12-18 14:04 ` Wolfram Sang
2015-12-18 14:04 ` Wolfram Sang
2015-12-18 15:25 ` Phil Edworthy
2015-12-21 10:52 ` Phil Edworthy
2015-12-21 13:16 ` Geert Uytterhoeven
2015-12-21 13:16 ` Geert Uytterhoeven
2016-01-04 14:18 ` Phil Edworthy
2016-01-04 14:18 ` Phil Edworthy
2016-01-04 14:18 ` Phil Edworthy
2016-01-04 14:56 ` Geert Uytterhoeven
2016-01-04 14:56 ` Geert Uytterhoeven
2015-12-17 13:22 ` [PATCH 3/4] PCI: rcar: Add runtime PM support to pcie-rcar Phil Edworthy
2015-12-17 13:22 ` Phil Edworthy
2015-12-17 13:22 ` [PATCH 4/4] PCI: rcar: Add Gen2 PHY setup " Phil Edworthy
2015-12-17 13:22 ` Phil Edworthy
2015-12-17 13:33 ` Wolfram Sang [this message]
2015-12-17 13:33 ` Wolfram Sang
2015-12-18 13:43 ` Phil Edworthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217133308.GB20372@katana \
--to=wsa@the-dreams.de \
--cc=bhelgaas@google.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.