From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2] i2c: rcar: disable runtime PM correctly in slave mode
Date: Thu, 17 Dec 2015 20:39:07 +0100 [thread overview]
Message-ID: <20151217193907.GC1530@katana> (raw)
In-Reply-To: <1450292718-11951-1-git-send-email-wsa@the-dreams.de>
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
On Wed, Dec 16, 2015 at 08:05:18PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> When we also are I2C slave, we need to disable runtime PM because the
> address detection mechanism needs to be active all the time. However, we
> can reenable runtime PM once the slave instance was unregistered. So,
> use pm_runtime_get_sync/put to achieve this, since it has proper
> refcounting. pm_runtime_allow/forbid is like a global knob controllable
> from userspace which is unsuitable here.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-current, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2] i2c: rcar: disable runtime PM correctly in slave mode
Date: Thu, 17 Dec 2015 19:39:07 +0000 [thread overview]
Message-ID: <20151217193907.GC1530@katana> (raw)
In-Reply-To: <1450292718-11951-1-git-send-email-wsa@the-dreams.de>
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
On Wed, Dec 16, 2015 at 08:05:18PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> When we also are I2C slave, we need to disable runtime PM because the
> address detection mechanism needs to be active all the time. However, we
> can reenable runtime PM once the slave instance was unregistered. So,
> use pm_runtime_get_sync/put to achieve this, since it has proper
> refcounting. pm_runtime_allow/forbid is like a global knob controllable
> from userspace which is unsuitable here.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-current, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-17 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 19:05 [PATCH v2] i2c: rcar: disable runtime PM correctly in slave mode Wolfram Sang
2015-12-16 19:05 ` Wolfram Sang
2015-12-17 19:39 ` Wolfram Sang [this message]
2015-12-17 19:39 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217193907.GC1530@katana \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.