[meta-multimedia][PATCH 0/4] mpg123 cleanups + update

[meta-multimedia][PATCH 0/4] mpg123 cleanups + update

[Andre McCurdy]

Andre McCurdy (4):
  mpg123: recipe formatting cleanup, no functional changes
  mpg123: limit ARM_INSTRUCTION_SET = "arm" over-ride to armv4/armv5
  mpg123: drop unnecessary dependency on tslib
  mpg123: update 1.21.0 -> 1.22.4

 .../mpg123/{mpg123_1.21.0.bb => mpg123_1.22.4.bb}  | 47 ++++++++++++----------
 1 file changed, 25 insertions(+), 22 deletions(-)
 rename meta-multimedia/recipes-multimedia/mpg123/{mpg123_1.21.0.bb => mpg123_1.22.4.bb} (86%)

-- 
1.9.1

[meta-multimedia][PATCH 1/4] mpg123: recipe formatting cleanup, no functional changes

[Andre McCurdy]

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 .../recipes-multimedia/mpg123/mpg123_1.21.0.bb     | 42 +++++++++++-----------
 1 file changed, 22 insertions(+), 20 deletions(-)

diff --git a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
index 3aa5f3d..a3225f2 100644
--- a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
+++ b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
@@ -6,40 +6,42 @@ HOMEPAGE = "http://mpg123.de/"
 BUGTRACKER = "http://sourceforge.net/p/mpg123/bugs/"
 SECTION = "multimedia"
 
+LICENSE = "LGPLv2.1"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM = "file://COPYING;md5=1e86753638d3cf2512528b99079bc4f3"
+
 DEPENDS = "tslib audiofile"
 
+SRC_URI = "${SOURCEFORGE_MIRROR}/mpg123/mpg123/${PV}/${BP}.tar.bz2"
+
+SRC_URI[md5sum] = "13a9df5d4e7aa110e4ae27cf30128ce9"
+SRC_URI[sha256sum] = "3ad197f77c9ffdf3601e1c3183ae0709ccb3c3de68309527ce9375fcfb15dcba"
+
+inherit autotools pkgconfig
+
 # The options should be mutually exclusive for configuration script.
 # If both alsa and pulseaudio are specified (as in the default distro features)
 # pulseaudio takes precedence.
 PACKAGECONFIG_ALSA = "${@base_contains('DISTRO_FEATURES', 'alsa', 'alsa', '', d)}"
 PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '${PACKAGECONFIG_ALSA}', d)}"
-PACKAGECONFIG[pulseaudio] = "--with-default-audio=pulse,,pulseaudio"
+
 PACKAGECONFIG[alsa] = "--with-default-audio=alsa,,alsa-lib"
-PACKAGECONFIG[sdl] = ",,libsdl"
-PACKAGECONFIG[openal] = ",,openal-soft"
+PACKAGECONFIG[esd] = ",,esound"
 PACKAGECONFIG[jack] = ",,jack"
+PACKAGECONFIG[openal] = ",,openal-soft"
 PACKAGECONFIG[portaudio] = ",,portaudio-v19"
-PACKAGECONFIG[esd] = ",,esound"
+PACKAGECONFIG[pulseaudio] = "--with-default-audio=pulse,,pulseaudio"
+PACKAGECONFIG[sdl] = ",,libsdl"
 
-# Following are possible sound output modules
-#alsa tinyalsa oss coreaudio sndio sun win32 win32_wasapi os2 esd jack portaudio pulse sdl nas arts openal dummy
+# Following are possible sound output modules:
+# alsa arts coreaudio dummy esd jack nas openal os2 oss portaudio pulse sdl sndio sun tinyalsa win32 win32_wasapi
 AUDIOMODS += "${@base_contains('PACKAGECONFIG', 'alsa', 'alsa', '', d)}"
-AUDIOMODS += "${@base_contains('PACKAGECONFIG', 'pulseaudio', 'pulse', '', d)}"
-AUDIOMODS += "${@base_contains('PACKAGECONFIG', 'sdl', 'sdl', '', d)}"
-AUDIOMODS += "${@base_contains('PACKAGECONFIG', 'openal', 'openal', '', d)}"
+AUDIOMODS += "${@base_contains('PACKAGECONFIG', 'esd', 'esd', '', d)}"
 AUDIOMODS += "${@base_contains('PACKAGECONFIG', 'jack', 'jack', '', d)}"
+AUDIOMODS += "${@base_contains('PACKAGECONFIG', 'openal', 'openal', '', d)}"
 AUDIOMODS += "${@base_contains('PACKAGECONFIG', 'portaudio', 'portaudio', '', d)}"
-AUDIOMODS += "${@base_contains('PACKAGECONFIG', 'esd', 'esd', '', d)}"
-
-LICENSE = "LGPLv2.1"
-LICENSE_FLAGS = "commercial"
-LIC_FILES_CHKSUM = "file://COPYING;md5=1e86753638d3cf2512528b99079bc4f3"
-
-SRC_URI = "${SOURCEFORGE_MIRROR}/mpg123/mpg123/${PV}/${BP}.tar.bz2"
-SRC_URI[md5sum] = "13a9df5d4e7aa110e4ae27cf30128ce9"
-SRC_URI[sha256sum] = "3ad197f77c9ffdf3601e1c3183ae0709ccb3c3de68309527ce9375fcfb15dcba"
-
-inherit autotools pkgconfig
+AUDIOMODS += "${@base_contains('PACKAGECONFIG', 'pulseaudio', 'pulse', '', d)}"
+AUDIOMODS += "${@base_contains('PACKAGECONFIG', 'sdl', 'sdl', '', d)}"
 
 EXTRA_OECONF = " \
     --enable-shared \
-- 
1.9.1

[meta-multimedia][PATCH 2/4] mpg123: limit ARM_INSTRUCTION_SET = "arm" over-ride to armv4/armv5

[Andre McCurdy]

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
index a3225f2..0625634 100644
--- a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
+++ b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
@@ -57,4 +57,5 @@ EXTRA_OECONF = " \
 #| {standard input}:48: Error: shifts in CMP/MOV instructions are only supported in unified syntax -- `mov r5,r5,lsr#24'
 #...
 #| make[3]: *** [equalizer.lo] Error 1
-ARM_INSTRUCTION_SET = "arm"
+ARM_INSTRUCTION_SET_armv4 = "arm"
+ARM_INSTRUCTION_SET_armv5 = "arm"
-- 
1.9.1

Re: [meta-multimedia][PATCH 2/4] mpg123: limit ARM_INSTRUCTION_SET = "arm" over-ride to armv4/armv5

[Khem Raj]

On Thu, Dec 3, 2015 at 7:21 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
> index a3225f2..0625634 100644
> --- a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
> +++ b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
> @@ -57,4 +57,5 @@ EXTRA_OECONF = " \
>  #| {standard input}:48: Error: shifts in CMP/MOV instructions are only supported in unified syntax -- `mov r5,r5,lsr#24'
>  #...
>  #| make[3]: *** [equalizer.lo] Error 1
> -ARM_INSTRUCTION_SET = "arm"
> +ARM_INSTRUCTION_SET_armv4 = "arm"
> +ARM_INSTRUCTION_SET_armv5 = "arm"

how does is fix the problem ? I think it might just be hiding real problem

> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-multimedia][PATCH 2/4] mpg123: limit ARM_INSTRUCTION_SET = "arm" over-ride to armv4/armv5

[Andre McCurdy]

On Mon, Dec 7, 2015 at 10:28 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Thu, Dec 3, 2015 at 7:21 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> ---
>>  meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>> index a3225f2..0625634 100644
>> --- a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>> +++ b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>> @@ -57,4 +57,5 @@ EXTRA_OECONF = " \
>>  #| {standard input}:48: Error: shifts in CMP/MOV instructions are only supported in unified syntax -- `mov r5,r5,lsr#24'
>>  #...
>>  #| make[3]: *** [equalizer.lo] Error 1
>> -ARM_INSTRUCTION_SET = "arm"
>> +ARM_INSTRUCTION_SET_armv4 = "arm"
>> +ARM_INSTRUCTION_SET_armv5 = "arm"
>
> how does is fix the problem ? I think it might just be hiding real problem

You mean the problem that upstream packages don't seem to care much
about Thumb1 any more?

I wasn't attempting to fix that, just to allow Thumb2 for CPUs which support it.

>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-multimedia][PATCH 2/4] mpg123: limit ARM_INSTRUCTION_SET = "arm" over-ride to armv4/armv5

[Khem Raj]

On Mon, Dec 7, 2015 at 11:58 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Mon, Dec 7, 2015 at 10:28 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> On Thu, Dec 3, 2015 at 7:21 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>>> ---
>>>  meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>>> index a3225f2..0625634 100644
>>> --- a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>>> +++ b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>>> @@ -57,4 +57,5 @@ EXTRA_OECONF = " \
>>>  #| {standard input}:48: Error: shifts in CMP/MOV instructions are only supported in unified syntax -- `mov r5,r5,lsr#24'
>>>  #...
>>>  #| make[3]: *** [equalizer.lo] Error 1
>>> -ARM_INSTRUCTION_SET = "arm"
>>> +ARM_INSTRUCTION_SET_armv4 = "arm"
>>> +ARM_INSTRUCTION_SET_armv5 = "arm"
>>
>> how does is fix the problem ? I think it might just be hiding real problem
>
> You mean the problem that upstream packages don't seem to care much
> about Thumb1 any more?
>
> I wasn't attempting to fix that, just to allow Thumb2 for CPUs which support it.

ARM mode should have worked for chips using armv7+ as well so my
question was if there is a general problem of compiling mpg123 in arm
mode.
or something else. The change in itself is fine it limits the scope to
armv5 and older.

Re: [meta-multimedia][PATCH 2/4] mpg123: limit ARM_INSTRUCTION_SET = "arm" over-ride to armv4/armv5

[Andre McCurdy]

On Mon, Dec 7, 2015 at 12:27 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Mon, Dec 7, 2015 at 11:58 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
>> On Mon, Dec 7, 2015 at 10:28 AM, Khem Raj <raj.khem@gmail.com> wrote:
>>> On Thu, Dec 3, 2015 at 7:21 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>>>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>>>> ---
>>>>  meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb | 3 ++-
>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>>>> index a3225f2..0625634 100644
>>>> --- a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>>>> +++ b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>>>> @@ -57,4 +57,5 @@ EXTRA_OECONF = " \
>>>>  #| {standard input}:48: Error: shifts in CMP/MOV instructions are only supported in unified syntax -- `mov r5,r5,lsr#24'
>>>>  #...
>>>>  #| make[3]: *** [equalizer.lo] Error 1
>>>> -ARM_INSTRUCTION_SET = "arm"
>>>> +ARM_INSTRUCTION_SET_armv4 = "arm"
>>>> +ARM_INSTRUCTION_SET_armv5 = "arm"
>>>
>>> how does is fix the problem ? I think it might just be hiding real problem
>>
>> You mean the problem that upstream packages don't seem to care much
>> about Thumb1 any more?
>>
>> I wasn't attempting to fix that, just to allow Thumb2 for CPUs which support it.
>
> ARM mode should have worked for chips using armv7+ as well so my
> question was if there is a general problem of compiling mpg123 in arm
> mode.
> or something else. The change in itself is fine it limits the scope to
> armv5 and older.

I've tested ARM and Thumb2 on armv7a and both seem to be working fine.

> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-multimedia][PATCH 2/4] mpg123: limit ARM_INSTRUCTION_SET = "arm" over-ride to armv4/armv5

[Khem Raj]

On Mon, Dec 7, 2015 at 12:55 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Mon, Dec 7, 2015 at 12:27 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> On Mon, Dec 7, 2015 at 11:58 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
>>> On Mon, Dec 7, 2015 at 10:28 AM, Khem Raj <raj.khem@gmail.com> wrote:
>>>> On Thu, Dec 3, 2015 at 7:21 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>>>>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>>>>> ---
>>>>>  meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb | 3 ++-
>>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>>>>> index a3225f2..0625634 100644
>>>>> --- a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>>>>> +++ b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
>>>>> @@ -57,4 +57,5 @@ EXTRA_OECONF = " \
>>>>>  #| {standard input}:48: Error: shifts in CMP/MOV instructions are only supported in unified syntax -- `mov r5,r5,lsr#24'
>>>>>  #...
>>>>>  #| make[3]: *** [equalizer.lo] Error 1
>>>>> -ARM_INSTRUCTION_SET = "arm"
>>>>> +ARM_INSTRUCTION_SET_armv4 = "arm"
>>>>> +ARM_INSTRUCTION_SET_armv5 = "arm"
>>>>
>>>> how does is fix the problem ? I think it might just be hiding real problem
>>>
>>> You mean the problem that upstream packages don't seem to care much
>>> about Thumb1 any more?
>>>
>>> I wasn't attempting to fix that, just to allow Thumb2 for CPUs which support it.
>>
>> ARM mode should have worked for chips using armv7+ as well so my
>> question was if there is a general problem of compiling mpg123 in arm
>> mode.
>> or something else. The change in itself is fine it limits the scope to
>> armv5 and older.
>
> I've tested ARM and Thumb2 on armv7a and both seem to be working fine.

OK thanks

[meta-multimedia][PATCH 3/4] mpg123: drop unnecessary dependency on tslib

[Andre McCurdy]

The mpg123 sources don't contain any references to tslib or -lts and
there are no obvious build issues or QA warnings after the tslib
dependency is removed.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
index 0625634..4048404 100644
--- a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
+++ b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
@@ -10,7 +10,7 @@ LICENSE = "LGPLv2.1"
 LICENSE_FLAGS = "commercial"
 LIC_FILES_CHKSUM = "file://COPYING;md5=1e86753638d3cf2512528b99079bc4f3"
 
-DEPENDS = "tslib audiofile"
+DEPENDS = "audiofile"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/mpg123/mpg123/${PV}/${BP}.tar.bz2"
 
-- 
1.9.1

[meta-multimedia][PATCH 4/4] mpg123: update 1.21.0 -> 1.22.4

[Andre McCurdy]

  http://mpg123.de/cgi-bin/scm/mpg123/tags/1.22.4/NEWS

1.22.4
---
- Fix stupid regression introduced with a bugfix in 1.14.1 to make
  free format streams work again. It took 3 years for someone to notice.
  I added a regression test for that now!

1.22.3
- Fix UTF-16 surrogate detection because that used to falsely detect
  characters above 0xDFFF as surrogates (bug 216).

1.22.2
---
- Fix buffering for funny sample formats (namely, 24 bit), that do not
  fit nicely into 32768 bytes. Effect was a nasty endless loop where
  mpg123 needs to be externally killed.

1.22.1
---
- Fix mpg123-id3dump when writing images with funny (manipulated) MIME type.
  Stupid mistake in length computation of the fallback file extension caused
  junk from memory being appended to the filename if the pointer size
  is less than 64 bit. For 64 bit pointers (or longer) it was correct by
  accident.
- Fix pedantic build by cleaning up out123 source, also now really showing
  the encoding list in --longhelp instead of possibly, again, writing junk
  from memory in there.
- Not linking libmpg123 against libltdl anymore (bug 215).
- Update MSVC++ ports a bit to make them work again.

1.22.0
---
- libmpg123 version 41
- Build fix: Avoid name clash on OSX SDK with "normal" being defined in an enum already.
- More resilience against folks who do not check errors and rather pass NULL pointers around (see NEWS.libmpg123).
  This changes some return values to MPG123_BAD_HANDLE instead of MPG123_ERR (always check for != MPG123_OK).
- Fix WAV writing to stdout on Windows (bug 214).
- Rework Xing/Info/Lame tag parsing, also detecting short ones without the TOC now.
  In addition, the warning about file size being off is a _lot_ more accurate now.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 .../recipes-multimedia/mpg123/{mpg123_1.21.0.bb => mpg123_1.22.4.bb}  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
 rename meta-multimedia/recipes-multimedia/mpg123/{mpg123_1.21.0.bb => mpg123_1.22.4.bb} (95%)

diff --git a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.22.4.bb
similarity index 95%
rename from meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
rename to meta-multimedia/recipes-multimedia/mpg123/mpg123_1.22.4.bb
index 4048404..22ea572 100644
--- a/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.21.0.bb
+++ b/meta-multimedia/recipes-multimedia/mpg123/mpg123_1.22.4.bb
@@ -14,8 +14,8 @@ DEPENDS = "audiofile"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/mpg123/mpg123/${PV}/${BP}.tar.bz2"
 
-SRC_URI[md5sum] = "13a9df5d4e7aa110e4ae27cf30128ce9"
-SRC_URI[sha256sum] = "3ad197f77c9ffdf3601e1c3183ae0709ccb3c3de68309527ce9375fcfb15dcba"
+SRC_URI[md5sum] = "2dfafae3bbc532b4c8b04a77c6a6de89"
+SRC_URI[sha256sum] = "5069e02e50138600f10cc5f7674e44e9bf6f1930af81d0e1d2f869b3c0ee40d2"
 
 inherit autotools pkgconfig
 
-- 
1.9.1

Re: [meta-multimedia][PATCH 0/4] mpg123 cleanups + update

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]

On Thu, Dec 03, 2015 at 07:21:52PM -0800, Andre McCurdy wrote:
> Andre McCurdy (4):
>   mpg123: recipe formatting cleanup, no functional changes
>   mpg123: limit ARM_INSTRUCTION_SET = "arm" over-ride to armv4/armv5
>   mpg123: drop unnecessary dependency on tslib
>   mpg123: update 1.21.0 -> 1.22.4

Can you please fix:
mpg123-1.22.4: ELF binary
'/tmp/work/i586-oe-linux/mpg123/1.22.4-r0/packages-split/mpg123/usr/lib/libmpg123.so.0.41.2'
has relocations in .text [textrel]

> 
>  .../mpg123/{mpg123_1.21.0.bb => mpg123_1.22.4.bb}  | 47 ++++++++++++----------
>  1 file changed, 25 insertions(+), 22 deletions(-)
>  rename meta-multimedia/recipes-multimedia/mpg123/{mpg123_1.21.0.bb => mpg123_1.22.4.bb} (86%)
> 
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-multimedia][PATCH 0/4] mpg123 cleanups + update

[Andre McCurdy]

On Fri, Dec 18, 2015 at 3:31 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Thu, Dec 03, 2015 at 07:21:52PM -0800, Andre McCurdy wrote:
>> Andre McCurdy (4):
>>   mpg123: recipe formatting cleanup, no functional changes
>>   mpg123: limit ARM_INSTRUCTION_SET = "arm" over-ride to armv4/armv5
>>   mpg123: drop unnecessary dependency on tslib
>>   mpg123: update 1.21.0 -> 1.22.4
>
> Can you please fix:
> mpg123-1.22.4: ELF binary
> '/tmp/work/i586-oe-linux/mpg123/1.22.4-r0/packages-split/mpg123/usr/lib/libmpg123.so.0.41.2'
> has relocations in .text [textrel]

Yes, I can take a look. This isn't a regression though - all versions
of mpg123 contain x86 assembler which require text relocations and
upstream isn't planning to fix them:

  http://sourceforge.net/p/mpg123/bugs/168/

So the solution will be a new patch which disables assembler
optimisations when building for x86.

>>
>>  .../mpg123/{mpg123_1.21.0.bb => mpg123_1.22.4.bb}  | 47 ++++++++++++----------
>>  1 file changed, 25 insertions(+), 22 deletions(-)
>>  rename meta-multimedia/recipes-multimedia/mpg123/{mpg123_1.21.0.bb => mpg123_1.22.4.bb} (86%)
>>
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [meta-multimedia][PATCH 0/4] mpg123 cleanups + update

[Martin Jansa]

Then you can disable that warning with this explanation in comment with
INSANE_SKIP.

On Fri, Dec 18, 2015 at 8:54 PM, Andre McCurdy <armccurdy@gmail.com> wrote:

> On Fri, Dec 18, 2015 at 3:31 AM, Martin Jansa <martin.jansa@gmail.com>
> wrote:
> > On Thu, Dec 03, 2015 at 07:21:52PM -0800, Andre McCurdy wrote:
> >> Andre McCurdy (4):
> >>   mpg123: recipe formatting cleanup, no functional changes
> >>   mpg123: limit ARM_INSTRUCTION_SET = "arm" over-ride to armv4/armv5
> >>   mpg123: drop unnecessary dependency on tslib
> >>   mpg123: update 1.21.0 -> 1.22.4
> >
> > Can you please fix:
> > mpg123-1.22.4: ELF binary
> >
> '/tmp/work/i586-oe-linux/mpg123/1.22.4-r0/packages-split/mpg123/usr/lib/libmpg123.so.0.41.2'
> > has relocations in .text [textrel]
>
> Yes, I can take a look. This isn't a regression though - all versions
> of mpg123 contain x86 assembler which require text relocations and
> upstream isn't planning to fix them:
>
>   http://sourceforge.net/p/mpg123/bugs/168/
>
> So the solution will be a new patch which disables assembler
> optimisations when building for x86.
>
> >>
> >>  .../mpg123/{mpg123_1.21.0.bb => mpg123_1.22.4.bb}  | 47
> ++++++++++++----------
> >>  1 file changed, 25 insertions(+), 22 deletions(-)
> >>  rename meta-multimedia/recipes-multimedia/mpg123/{mpg123_1.21.0.bb =>
> mpg123_1.22.4.bb} (86%)
> >>
> >> --
> >> 1.9.1
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> > --
> > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [meta-multimedia][PATCH 0/4] mpg123 cleanups + update

[Andre McCurdy]

On Fri, Dec 18, 2015 at 11:56 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> Then you can disable that warning with this explanation in comment with
> INSANE_SKIP.

I'll do some experiments first. Based on the discussion in the mpg123
bug report it's not clear that the i586 assembler is any better than
the generic C, so disabling the assembler might be a good solution
anyway.

  http://sourceforge.net/p/mpg123/bugs/168/#677e

> On Fri, Dec 18, 2015 at 8:54 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>
>> On Fri, Dec 18, 2015 at 3:31 AM, Martin Jansa <martin.jansa@gmail.com>
>> wrote:
>> > On Thu, Dec 03, 2015 at 07:21:52PM -0800, Andre McCurdy wrote:
>> >> Andre McCurdy (4):
>> >>   mpg123: recipe formatting cleanup, no functional changes
>> >>   mpg123: limit ARM_INSTRUCTION_SET = "arm" over-ride to armv4/armv5
>> >>   mpg123: drop unnecessary dependency on tslib
>> >>   mpg123: update 1.21.0 -> 1.22.4
>> >
>> > Can you please fix:
>> > mpg123-1.22.4: ELF binary
>> >
>> '/tmp/work/i586-oe-linux/mpg123/1.22.4-r0/packages-split/mpg123/usr/lib/libmpg123.so.0.41.2'
>> > has relocations in .text [textrel]
>>
>> Yes, I can take a look. This isn't a regression though - all versions
>> of mpg123 contain x86 assembler which require text relocations and
>> upstream isn't planning to fix them:
>>
>>   http://sourceforge.net/p/mpg123/bugs/168/
>>
>> So the solution will be a new patch which disables assembler
>> optimisations when building for x86.
>>
>> >>
>> >>  .../mpg123/{mpg123_1.21.0.bb => mpg123_1.22.4.bb}  | 47
>> ++++++++++++----------
>> >>  1 file changed, 25 insertions(+), 22 deletions(-)
>> >>  rename meta-multimedia/recipes-multimedia/mpg123/{mpg123_1.21.0.bb =>
>> mpg123_1.22.4.bb} (86%)
>> >>
>> >> --
>> >> 1.9.1
>> >>
>> >> --
>> >> _______________________________________________
>> >> Openembedded-devel mailing list
>> >> Openembedded-devel@lists.openembedded.org
>> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>> >
>> > --
>> > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>> >
>> > --
>> > _______________________________________________
>> > Openembedded-devel mailing list
>> > Openembedded-devel@lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>> >
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel