From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: sujith h <sujith.h@gmail.com>
Cc: toaster@yoctoproject.org
Subject: Re: Build cancellation from toaster
Date: Fri, 18 Dec 2015 15:46:27 +0200 [thread overview]
Message-ID: <20151218134627.GA27311@linux.intel.com> (raw)
In-Reply-To: <CADyYWLm+yYR7J6NMLKHR6Ss_i16Q5Tiz=x2DuJ7_mOViTEvcYg@mail.gmail.com>
Hi Sujith,
Can you split your changes please?
I'd suggest to at least separate backend changes from frontend ones.
Having uihelper.py changes in a separate commit would be nice too.
It looks like you've spotted correctly that findServerDetails is not
used anywhere in bitbake code. You can remove it in a separate commit as
it looks unrelated to the rest of the patch.
+1 for Michael's suggestion to use build controller.
On Thu, Dec 17, 2015 at 10:26:11PM +0530, sujith h wrote:
> Hi,
>
> I have posted my changes in:
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/toaster-build-cancel
>
> Kindly review my changes and let me know if I have to make changes. I would
> be happy to do so.
>
> Thanks for all helping hand from RP, Ed, Michael, Belen and Paul.
>
> Thanks,
> Sujith H
--
Regards,
Ed
next prev parent reply other threads:[~2015-12-18 14:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 16:56 Build cancellation from toaster sujith h
2015-12-18 12:24 ` Michael Wood
2015-12-18 13:46 ` Ed Bartosh [this message]
2015-12-19 15:27 ` sujith h
2015-12-21 8:07 ` sujith h
2015-12-21 13:12 ` sujith h
2015-12-22 10:49 ` sujith h
2016-01-04 13:16 ` sujith h
2016-01-05 13:44 ` Barros Pena, Belen
2016-01-05 14:13 ` sujith h
2016-01-06 13:38 ` sujith h
2016-01-09 16:53 ` sujith h
2016-01-11 11:25 ` Barros Pena, Belen
2016-01-12 10:34 ` Barros Pena, Belen
2016-01-13 16:47 ` sujith h
2016-01-17 19:43 ` Barros Pena, Belen
2016-01-18 16:12 ` sujith h
2016-01-20 16:56 ` Brian Avery
2016-01-26 14:22 ` sujith h
2016-01-27 16:20 ` sujith h
2016-02-01 15:35 ` Barros Pena, Belen
2016-02-03 13:38 ` sujith h
2016-02-09 13:40 ` sujith h
2016-02-12 11:04 ` Barros Pena, Belen
2016-02-19 23:11 ` Michael Wood
2016-02-22 6:23 ` sujith h
2016-01-21 15:16 ` [Toaster] " sujith h
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218134627.GA27311@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=sujith.h@gmail.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.