All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
	davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Tom Herbert <tom@herbertland.com>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] ila: add NETFILTER dependency
Date: Fri, 18 Dec 2015 21:37:17 +0100	[thread overview]
Message-ID: <20151218203717.GA14846@salvia> (raw)
In-Reply-To: <20151218180931.GC29573@breakpoint.cc>

On Fri, Dec 18, 2015 at 07:09:31PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > I'm afraid this extra Kconfig dependency that Arnd adds to fix this is
> > a symptom that there is something that doesn't belong there.
> > 
> > I overlook this new hook on priority -1, how does this integrate into
> > our infrastructure?
> 
> Looks problematic since address changes post ipv6 dnat translations,
> its certainly unexpected for nft since we have magic address mangling
> after -2 and 0 priroized tables...

David indicated that this should be sort of transparent and integrated
into separated infrastructure.

The existing hook will break IPv6 conntrack and NAT for us, and the
extra hook is suboptimal as it

I'd suggest you add a static key and specific hook before netfilter to
deal with this.

WARNING: multiple messages have this Message-ID (diff)
From: pablo@netfilter.org (Pablo Neira Ayuso)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ila: add NETFILTER dependency
Date: Fri, 18 Dec 2015 21:37:17 +0100	[thread overview]
Message-ID: <20151218203717.GA14846@salvia> (raw)
In-Reply-To: <20151218180931.GC29573@breakpoint.cc>

On Fri, Dec 18, 2015 at 07:09:31PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > I'm afraid this extra Kconfig dependency that Arnd adds to fix this is
> > a symptom that there is something that doesn't belong there.
> > 
> > I overlook this new hook on priority -1, how does this integrate into
> > our infrastructure?
> 
> Looks problematic since address changes post ipv6 dnat translations,
> its certainly unexpected for nft since we have magic address mangling
> after -2 and 0 priroized tables...

David indicated that this should be sort of transparent and integrated
into separated infrastructure.

The existing hook will break IPv6 conntrack and NAT for us, and the
extra hook is suboptimal as it

I'd suggest you add a static key and specific hook before netfilter to
deal with this.

  reply	other threads:[~2015-12-18 20:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 14:37 [PATCH] ila: add NETFILTER dependency Arnd Bergmann
2015-12-18 14:37 ` Arnd Bergmann
2015-12-18 17:26 ` Pablo Neira Ayuso
2015-12-18 17:26   ` Pablo Neira Ayuso
2015-12-18 18:09   ` Florian Westphal
2015-12-18 18:09     ` Florian Westphal
2015-12-18 20:37     ` Pablo Neira Ayuso [this message]
2015-12-18 20:37       ` Pablo Neira Ayuso
2015-12-18 19:19 ` David Miller
2015-12-18 19:19   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151218203717.GA14846@salvia \
    --to=pablo@netfilter.org \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.