From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>,
Takashi Iwai <tiwai-IBi9RG/b67k@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: Re: [PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin
Date: Fri, 18 Dec 2015 21:53:41 +0100 [thread overview]
Message-ID: <20151218205341.GO30359@lukather> (raw)
In-Reply-To: <566EE953.3050702-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
On Mon, Dec 14, 2015 at 05:07:47PM +0100, Hans de Goede wrote:
> >>+static int sun4i_codec_spk_event(struct snd_soc_dapm_widget *w,
> >>+ struct snd_kcontrol *k, int event)
> >>+{
> >>+ struct sun4i_codec *scodec = snd_soc_card_get_drvdata(w->dapm->card);
> >>+
> >>+ if (scodec->gpio_pa)
> >>+ gpiod_set_value_cansleep(scodec->gpio_pa,
> >>+ !!SND_SOC_DAPM_EVENT_ON(event));
> >>+
> >>+ return 0;
> >>+}
> >>+
> >>+static const struct snd_soc_dapm_widget sun4i_codec_card_dapm_widgets[] = {
> >>+ SND_SOC_DAPM_SPK("Speaker", sun4i_codec_spk_event),
> >>+};
> >>+
> >>+static const struct snd_soc_dapm_route sun4i_codec_card_dapm_routes[] = {
> >>+ { "Speaker", NULL, "Power Amplifier" },
> >>+};
> >
> >Shouldn't it be tied to the HP outputs instead?
>
> You're right, the HP outputs are the final outputs, and since this is
> for enabling an external amplifier you're right. Since Mark has already
> merged this patch I will do a follow up patch to fix this.
Great, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin
Date: Fri, 18 Dec 2015 21:53:41 +0100 [thread overview]
Message-ID: <20151218205341.GO30359@lukather> (raw)
In-Reply-To: <566EE953.3050702@redhat.com>
On Mon, Dec 14, 2015 at 05:07:47PM +0100, Hans de Goede wrote:
> >>+static int sun4i_codec_spk_event(struct snd_soc_dapm_widget *w,
> >>+ struct snd_kcontrol *k, int event)
> >>+{
> >>+ struct sun4i_codec *scodec = snd_soc_card_get_drvdata(w->dapm->card);
> >>+
> >>+ if (scodec->gpio_pa)
> >>+ gpiod_set_value_cansleep(scodec->gpio_pa,
> >>+ !!SND_SOC_DAPM_EVENT_ON(event));
> >>+
> >>+ return 0;
> >>+}
> >>+
> >>+static const struct snd_soc_dapm_widget sun4i_codec_card_dapm_widgets[] = {
> >>+ SND_SOC_DAPM_SPK("Speaker", sun4i_codec_spk_event),
> >>+};
> >>+
> >>+static const struct snd_soc_dapm_route sun4i_codec_card_dapm_routes[] = {
> >>+ { "Speaker", NULL, "Power Amplifier" },
> >>+};
> >
> >Shouldn't it be tied to the HP outputs instead?
>
> You're right, the HP outputs are the final outputs, and since this is
> for enabling an external amplifier you're right. Since Mark has already
> merged this patch I will do a follow up patch to fix this.
Great, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151218/21c3a892/attachment.sig>
next prev parent reply other threads:[~2015-12-18 20:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 18:43 [PATCH v2 1/4] ASoC: sun4i-codec: Rename codec dapm widgets and routes Hans de Goede
2015-12-11 18:43 ` Hans de Goede
2015-12-12 23:07 ` Applied "ASoC: sun4i-codec: Rename codec dapm widgets and routes" to the asoc tree Mark Brown
[not found] ` <1449859439-30875-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-11 18:43 ` [PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin Hans de Goede
2015-12-11 18:43 ` Hans de Goede
2015-12-12 23:01 ` Mark Brown
2015-12-12 23:01 ` Mark Brown
2015-12-12 23:07 ` Applied "ASoC: sun4i-codec: Add support for PA gpio pin" to the asoc tree Mark Brown
[not found] ` <1449859439-30875-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-14 1:11 ` [PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin Rob Herring
2015-12-14 1:11 ` Rob Herring
2015-12-14 15:56 ` Maxime Ripard
2015-12-14 15:56 ` Maxime Ripard
2015-12-14 16:07 ` [linux-sunxi] " Hans de Goede
2015-12-14 16:07 ` Hans de Goede
[not found] ` <566EE953.3050702-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-18 20:53 ` Maxime Ripard [this message]
2015-12-18 20:53 ` Maxime Ripard
2015-12-11 18:43 ` [PATCH v2 3/4] ARM: dts: sun5i: Enable onboard codec used on the UTOO P66 tablet Hans de Goede
2015-12-11 18:43 ` Hans de Goede
2015-12-11 18:43 ` [PATCH v2 4/4] ARM: dts: sun4i: Enable onboard codec used on the pov protab2-ips9 tablet Hans de Goede
2015-12-11 18:43 ` Hans de Goede
[not found] ` <1449859439-30875-4-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-18 21:19 ` Maxime Ripard
2015-12-18 21:19 ` Maxime Ripard
2015-12-14 9:44 ` [PATCH v2 1/4] ASoC: sun4i-codec: Rename codec dapm widgets and routes Maxime Ripard
2015-12-14 9:44 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218205341.GO30359@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=tiwai-IBi9RG/b67k@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.