From: Dan Carpenter <dan.carpenter@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()
Date: Sat, 19 Dec 2015 21:04:14 +0000 [thread overview]
Message-ID: <20151219210414.GW5284@mwanda> (raw)
In-Reply-To: <5675C426.7040602@users.sourceforge.net>
On Sat, Dec 19, 2015 at 09:55:02PM +0100, SF Markus Elfring wrote:
> > Just make it an int.
>
> Thanks for your suggestion.
>
> Will any more software developers prefer this data type
> at some source code places?
>
Use s32 if the hardware spec specifies that you must. Otherwise prefer
ordinary types.
>
> > The caller also casts it to u32...
>
> Do you want to get rid of similar casts in affected functions?
If you want, that would be great. I just enjoy complaining generally,
though. :P
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()
Date: Sun, 20 Dec 2015 00:04:14 +0300 [thread overview]
Message-ID: <20151219210414.GW5284@mwanda> (raw)
In-Reply-To: <5675C426.7040602@users.sourceforge.net>
On Sat, Dec 19, 2015 at 09:55:02PM +0100, SF Markus Elfring wrote:
> > Just make it an int.
>
> Thanks for your suggestion.
>
> Will any more software developers prefer this data type
> at some source code places?
>
Use s32 if the hardware spec specifies that you must. Otherwise prefer
ordinary types.
>
> > The caller also casts it to u32...
>
> Do you want to get rid of similar casts in affected functions?
If you want, that would be great. I just enjoy complaining generally,
though. :P
regards,
dan carpenter
next prev parent reply other threads:[~2015-12-19 21:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 20:15 [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep() SF Markus Elfring
2015-12-19 20:15 ` SF Markus Elfring
2015-12-19 20:27 ` Dan Carpenter
2015-12-19 20:27 ` Dan Carpenter
2015-12-19 20:55 ` SF Markus Elfring
2015-12-19 20:55 ` SF Markus Elfring
2015-12-19 21:04 ` Dan Carpenter [this message]
2015-12-19 21:04 ` Dan Carpenter
2015-12-22 15:48 ` [PATCH v2 0/2] USB-FHCI: Use return type "int" for two functions SF Markus Elfring
2015-12-22 15:48 ` SF Markus Elfring
2015-12-22 15:51 ` [PATCH v2 1/2] USB-FHCI: Use a signed return type for fhci_create_ep() SF Markus Elfring
2015-12-22 15:51 ` SF Markus Elfring
2015-12-22 15:54 ` [PATCH v2 2/2] USB-FHCI: Use a signed return type for endpoint_zero_init() SF Markus Elfring
2015-12-22 15:54 ` SF Markus Elfring
2015-12-19 20:46 ` [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep() Sergei Shtylyov
2015-12-19 20:46 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151219210414.GW5284@mwanda \
--to=dan.carpenter@oracle.com \
--cc=elfring@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.