* [ath9k-devel] [patch -next] ath9k: fix ath9k_hw_nvram_check_version()
@ 2015-12-19 10:59 ` Dan Carpenter
0 siblings, 0 replies; 21+ messages in thread
From: Dan Carpenter @ 2015-12-19 10:59 UTC (permalink / raw)
To: ath9k-devel
There is a type bug so it always returns success.
Fixes: 6fa658fd5ab2 ('ath9k: Simplify and fix eeprom endianness swapping')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/ath/ath9k/eeprom.c b/drivers/net/wireless/ath/ath9k/eeprom.c
index f8c5065..a7afdee 100644
--- a/drivers/net/wireless/ath/ath9k/eeprom.c
+++ b/drivers/net/wireless/ath/ath9k/eeprom.c
@@ -206,7 +206,7 @@ bool ath9k_hw_nvram_check_version(struct ath_hw *ah, int version, int minrev)
ath_err(common, "Bad EEPROM VER 0x%04x or REV 0x%04x\n",
ah->eep_ops->get_eeprom_ver(ah),
ah->eep_ops->get_eeprom_rev(ah));
- return -EINVAL;
+ return false;
}
return true;
^ permalink raw reply related [flat|nested] 21+ messages in thread* [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2015-12-19 10:59 ` Dan Carpenter 0 siblings, 0 replies; 21+ messages in thread From: Dan Carpenter @ 2015-12-19 10:59 UTC (permalink / raw) To: QCA ath9k Development, Martin Blumenstingl Cc: Kalle Valo, linux-wireless, ath9k-devel, kernel-janitors There is a type bug so it always returns success. Fixes: 6fa658fd5ab2 ('ath9k: Simplify and fix eeprom endianness swapping') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/net/wireless/ath/ath9k/eeprom.c b/drivers/net/wireless/ath/ath9k/eeprom.c index f8c5065..a7afdee 100644 --- a/drivers/net/wireless/ath/ath9k/eeprom.c +++ b/drivers/net/wireless/ath/ath9k/eeprom.c @@ -206,7 +206,7 @@ bool ath9k_hw_nvram_check_version(struct ath_hw *ah, int version, int minrev) ath_err(common, "Bad EEPROM VER 0x%04x or REV 0x%04x\n", ah->eep_ops->get_eeprom_ver(ah), ah->eep_ops->get_eeprom_rev(ah)); - return -EINVAL; + return false; } return true; ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2015-12-19 10:59 ` Dan Carpenter 0 siblings, 0 replies; 21+ messages in thread From: Dan Carpenter @ 2015-12-19 10:59 UTC (permalink / raw) To: QCA ath9k Development, Martin Blumenstingl Cc: Kalle Valo, linux-wireless, ath9k-devel, kernel-janitors There is a type bug so it always returns success. Fixes: 6fa658fd5ab2 ('ath9k: Simplify and fix eeprom endianness swapping') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/net/wireless/ath/ath9k/eeprom.c b/drivers/net/wireless/ath/ath9k/eeprom.c index f8c5065..a7afdee 100644 --- a/drivers/net/wireless/ath/ath9k/eeprom.c +++ b/drivers/net/wireless/ath/ath9k/eeprom.c @@ -206,7 +206,7 @@ bool ath9k_hw_nvram_check_version(struct ath_hw *ah, int version, int minrev) ath_err(common, "Bad EEPROM VER 0x%04x or REV 0x%04x\n", ah->eep_ops->get_eeprom_ver(ah), ah->eep_ops->get_eeprom_rev(ah)); - return -EINVAL; + return false; } return true; ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [ath9k-devel] [patch -next] ath9k: fix ath9k_hw_nvram_check_version() 2015-12-19 10:59 ` Dan Carpenter (?) @ 2015-12-19 11:12 ` Martin Blumenstingl -1 siblings, 0 replies; 21+ messages in thread From: Martin Blumenstingl @ 2015-12-19 11:12 UTC (permalink / raw) To: ath9k-devel On Sat, Dec 19, 2015 at 11:59 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > There is a type bug so it always returns success. > > Fixes: 6fa658fd5ab2 ('ath9k: Simplify and fix eeprom endianness swapping') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Thank you for finding and fixing this one! ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2015-12-19 11:12 ` Martin Blumenstingl 0 siblings, 0 replies; 21+ messages in thread From: Martin Blumenstingl @ 2015-12-19 11:12 UTC (permalink / raw) To: Dan Carpenter Cc: QCA ath9k Development, Kalle Valo, linux-wireless, ath9k-devel, kernel-janitors On Sat, Dec 19, 2015 at 11:59 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > There is a type bug so it always returns success. > > Fixes: 6fa658fd5ab2 ('ath9k: Simplify and fix eeprom endianness swapping') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Thank you for finding and fixing this one! ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2015-12-19 11:12 ` Martin Blumenstingl 0 siblings, 0 replies; 21+ messages in thread From: Martin Blumenstingl @ 2015-12-19 11:12 UTC (permalink / raw) To: Dan Carpenter Cc: QCA ath9k Development, Kalle Valo, linux-wireless, ath9k-devel, kernel-janitors On Sat, Dec 19, 2015 at 11:59 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > There is a type bug so it always returns success. > > Fixes: 6fa658fd5ab2 ('ath9k: Simplify and fix eeprom endianness swapping') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Thank you for finding and fixing this one! ^ permalink raw reply [flat|nested] 21+ messages in thread
* [ath9k-devel] [patch -next] ath9k: fix ath9k_hw_nvram_check_version() 2015-12-19 10:59 ` Dan Carpenter (?) @ 2015-12-20 18:47 ` Joe Perches -1 siblings, 0 replies; 21+ messages in thread From: Joe Perches @ 2015-12-20 18:47 UTC (permalink / raw) To: ath9k-devel On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > There is a type bug so it always returns success. How many false positives do you have to sift through to find this sort of error? > +++ b/drivers/net/wireless/ath/ath9k/eeprom.c > @@ -206,7 +206,7 @@ bool ath9k_hw_nvram_check_version(struct ath_hw *ah, int version, int minrev) > ? ath_err(common, "Bad EEPROM VER 0x%04x or REV 0x%04x\n", > ? ah->eep_ops->get_eeprom_ver(ah), > ? ah->eep_ops->get_eeprom_rev(ah)); > - return -EINVAL; > + return false; > ? } > ? > ? return true; ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2015-12-20 18:47 ` Joe Perches 0 siblings, 0 replies; 21+ messages in thread From: Joe Perches @ 2015-12-20 18:47 UTC (permalink / raw) To: Dan Carpenter, QCA ath9k Development, Martin Blumenstingl Cc: Kalle Valo, linux-wireless, ath9k-devel, kernel-janitors On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > There is a type bug so it always returns success. How many false positives do you have to sift through to find this sort of error? > +++ b/drivers/net/wireless/ath/ath9k/eeprom.c > @@ -206,7 +206,7 @@ bool ath9k_hw_nvram_check_version(struct ath_hw *ah, int version, int minrev) > ath_err(common, "Bad EEPROM VER 0x%04x or REV 0x%04x\n", > ah->eep_ops->get_eeprom_ver(ah), > ah->eep_ops->get_eeprom_rev(ah)); > - return -EINVAL; > + return false; > } > > return true; ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2015-12-20 18:47 ` Joe Perches 0 siblings, 0 replies; 21+ messages in thread From: Joe Perches @ 2015-12-20 18:47 UTC (permalink / raw) To: Dan Carpenter, QCA ath9k Development, Martin Blumenstingl Cc: Kalle Valo, linux-wireless, ath9k-devel, kernel-janitors On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > There is a type bug so it always returns success. How many false positives do you have to sift through to find this sort of error? > +++ b/drivers/net/wireless/ath/ath9k/eeprom.c > @@ -206,7 +206,7 @@ bool ath9k_hw_nvram_check_version(struct ath_hw *ah, int version, int minrev) > ath_err(common, "Bad EEPROM VER 0x%04x or REV 0x%04x\n", > ah->eep_ops->get_eeprom_ver(ah), > ah->eep_ops->get_eeprom_rev(ah)); > - return -EINVAL; > + return false; > } > > return true; -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 21+ messages in thread
* [ath9k-devel] [patch -next] ath9k: fix ath9k_hw_nvram_check_version() 2015-12-20 18:47 ` Joe Perches (?) @ 2015-12-20 19:00 ` Julia Lawall -1 siblings, 0 replies; 21+ messages in thread From: Julia Lawall @ 2015-12-20 19:00 UTC (permalink / raw) To: ath9k-devel On Sun, 20 Dec 2015, Joe Perches wrote: > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > There is a type bug so it always returns success. > > How many false positives do you have to sift > through to find this sort of error? The return type is thoughtfully bool, so it should be easy in this case. The function has a return -EINVAL and a return true, so even without the return type it would be locally apparent that there is an inconsistency. julia > > > +++ b/drivers/net/wireless/ath/ath9k/eeprom.c > > @@ -206,7 +206,7 @@ bool ath9k_hw_nvram_check_version(struct ath_hw *ah, int version, int minrev) > > ? ath_err(common, "Bad EEPROM VER 0x%04x or REV 0x%04x\n", > > ? ah->eep_ops->get_eeprom_ver(ah), > > ? ah->eep_ops->get_eeprom_rev(ah)); > > - return -EINVAL; > > + return false; > > ? } > > ? > > ? return true; > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2015-12-20 19:00 ` Julia Lawall 0 siblings, 0 replies; 21+ messages in thread From: Julia Lawall @ 2015-12-20 19:00 UTC (permalink / raw) To: Joe Perches Cc: Dan Carpenter, QCA ath9k Development, Martin Blumenstingl, Kalle Valo, linux-wireless, ath9k-devel, kernel-janitors [-- Attachment #1: Type: TEXT/PLAIN, Size: 1063 bytes --] On Sun, 20 Dec 2015, Joe Perches wrote: > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > There is a type bug so it always returns success. > > How many false positives do you have to sift > through to find this sort of error? The return type is thoughtfully bool, so it should be easy in this case. The function has a return -EINVAL and a return true, so even without the return type it would be locally apparent that there is an inconsistency. julia > > > +++ b/drivers/net/wireless/ath/ath9k/eeprom.c > > @@ -206,7 +206,7 @@ bool ath9k_hw_nvram_check_version(struct ath_hw *ah, int version, int minrev) > > ath_err(common, "Bad EEPROM VER 0x%04x or REV 0x%04x\n", > > ah->eep_ops->get_eeprom_ver(ah), > > ah->eep_ops->get_eeprom_rev(ah)); > > - return -EINVAL; > > + return false; > > } > > > > return true; > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2015-12-20 19:00 ` Julia Lawall 0 siblings, 0 replies; 21+ messages in thread From: Julia Lawall @ 2015-12-20 19:00 UTC (permalink / raw) To: Joe Perches Cc: Dan Carpenter, QCA ath9k Development, Martin Blumenstingl, Kalle Valo, linux-wireless, ath9k-devel, kernel-janitors [-- Attachment #1: Type: TEXT/PLAIN, Size: 1093 bytes --] On Sun, 20 Dec 2015, Joe Perches wrote: > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > There is a type bug so it always returns success. > > How many false positives do you have to sift > through to find this sort of error? The return type is thoughtfully bool, so it should be easy in this case. The function has a return -EINVAL and a return true, so even without the return type it would be locally apparent that there is an inconsistency. julia > > > +++ b/drivers/net/wireless/ath/ath9k/eeprom.c > > @@ -206,7 +206,7 @@ bool ath9k_hw_nvram_check_version(struct ath_hw *ah, int version, int minrev) > > ath_err(common, "Bad EEPROM VER 0x%04x or REV 0x%04x\n", > > ah->eep_ops->get_eeprom_ver(ah), > > ah->eep_ops->get_eeprom_rev(ah)); > > - return -EINVAL; > > + return false; > > } > > > > return true; > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 21+ messages in thread
* [ath9k-devel] [patch -next] ath9k: fix ath9k_hw_nvram_check_version() 2015-12-20 19:00 ` Julia Lawall (?) @ 2015-12-20 19:05 ` Joe Perches -1 siblings, 0 replies; 21+ messages in thread From: Joe Perches @ 2015-12-20 19:05 UTC (permalink / raw) To: ath9k-devel On Sun, 2015-12-20 at 20:00 +0100, Julia Lawall wrote: > On Sun, 20 Dec 2015, Joe Perches wrote: > > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > > There is a type bug so it always returns success. > >? > > How many false positives do you have to sift > > through to find this sort of error? > > The return type is thoughtfully bool, so it should be easy in this case.?? > The function has a return -EINVAL and a return true, so even without the? > return type it would be locally apparent that there is an inconsistency. True, -EINVAL is a non-bool constant, but bool returns can be a variable int. Dan, was the check any constant non-bool? ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2015-12-20 19:05 ` Joe Perches 0 siblings, 0 replies; 21+ messages in thread From: Joe Perches @ 2015-12-20 19:05 UTC (permalink / raw) To: Julia Lawall Cc: Dan Carpenter, QCA ath9k Development, Martin Blumenstingl, Kalle Valo, linux-wireless, ath9k-devel, kernel-janitors On Sun, 2015-12-20 at 20:00 +0100, Julia Lawall wrote: > On Sun, 20 Dec 2015, Joe Perches wrote: > > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > > There is a type bug so it always returns success. > > > > How many false positives do you have to sift > > through to find this sort of error? > > The return type is thoughtfully bool, so it should be easy in this case. > The function has a return -EINVAL and a return true, so even without the > return type it would be locally apparent that there is an inconsistency. True, -EINVAL is a non-bool constant, but bool returns can be a variable int. Dan, was the check any constant non-bool? ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2015-12-20 19:05 ` Joe Perches 0 siblings, 0 replies; 21+ messages in thread From: Joe Perches @ 2015-12-20 19:05 UTC (permalink / raw) To: Julia Lawall Cc: Dan Carpenter, QCA ath9k Development, Martin Blumenstingl, Kalle Valo, linux-wireless, ath9k-devel, kernel-janitors On Sun, 2015-12-20 at 20:00 +0100, Julia Lawall wrote: > On Sun, 20 Dec 2015, Joe Perches wrote: > > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > > There is a type bug so it always returns success. > > > > How many false positives do you have to sift > > through to find this sort of error? > > The return type is thoughtfully bool, so it should be easy in this case. > The function has a return -EINVAL and a return true, so even without the > return type it would be locally apparent that there is an inconsistency. True, -EINVAL is a non-bool constant, but bool returns can be a variable int. Dan, was the check any constant non-bool? -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 21+ messages in thread
* [ath9k-devel] [patch -next] ath9k: fix ath9k_hw_nvram_check_version() 2015-12-20 19:05 ` Joe Perches (?) @ 2015-12-20 20:33 ` Dan Carpenter -1 siblings, 0 replies; 21+ messages in thread From: Dan Carpenter @ 2015-12-20 20:33 UTC (permalink / raw) To: ath9k-devel On Sun, Dec 20, 2015 at 11:05:55AM -0800, Joe Perches wrote: > On Sun, 2015-12-20 at 20:00 +0100, Julia Lawall wrote: > > On Sun, 20 Dec 2015, Joe Perches wrote: > > > > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > > > There is a type bug so it always returns success. > > >? > > > How many false positives do you have to sift > > > through to find this sort of error? > > > > The return type is thoughtfully bool, so it should be easy in this case.?? > > The function has a return -EINVAL and a return true, so even without the? > > return type it would be locally apparent that there is an inconsistency. > > True, -EINVAL is a non-bool constant, but > bool returns can be a variable int. > > Dan, was the check any constant non-bool? This warning is for returning negative with unsigned types smaller than int. It's doing cross function flow analysis so it could warning about other things besides constants, but it's 90% constants. It warns about ds2482_w1_triplet() for example. There aren't many false positives. regards, dan carpenter ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2015-12-20 20:33 ` Dan Carpenter 0 siblings, 0 replies; 21+ messages in thread From: Dan Carpenter @ 2015-12-20 20:33 UTC (permalink / raw) To: Joe Perches Cc: Julia Lawall, QCA ath9k Development, Martin Blumenstingl, Kalle Valo, linux-wireless, ath9k-devel, kernel-janitors On Sun, Dec 20, 2015 at 11:05:55AM -0800, Joe Perches wrote: > On Sun, 2015-12-20 at 20:00 +0100, Julia Lawall wrote: > > On Sun, 20 Dec 2015, Joe Perches wrote: > > > > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > > > There is a type bug so it always returns success. > > > > > > How many false positives do you have to sift > > > through to find this sort of error? > > > > The return type is thoughtfully bool, so it should be easy in this case. > > The function has a return -EINVAL and a return true, so even without the > > return type it would be locally apparent that there is an inconsistency. > > True, -EINVAL is a non-bool constant, but > bool returns can be a variable int. > > Dan, was the check any constant non-bool? This warning is for returning negative with unsigned types smaller than int. It's doing cross function flow analysis so it could warning about other things besides constants, but it's 90% constants. It warns about ds2482_w1_triplet() for example. There aren't many false positives. regards, dan carpenter ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2015-12-20 20:33 ` Dan Carpenter 0 siblings, 0 replies; 21+ messages in thread From: Dan Carpenter @ 2015-12-20 20:33 UTC (permalink / raw) To: Joe Perches Cc: Julia Lawall, QCA ath9k Development, Martin Blumenstingl, Kalle Valo, linux-wireless, ath9k-devel, kernel-janitors On Sun, Dec 20, 2015 at 11:05:55AM -0800, Joe Perches wrote: > On Sun, 2015-12-20 at 20:00 +0100, Julia Lawall wrote: > > On Sun, 20 Dec 2015, Joe Perches wrote: > > > > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > > > There is a type bug so it always returns success. > > > > > > How many false positives do you have to sift > > > through to find this sort of error? > > > > The return type is thoughtfully bool, so it should be easy in this case. > > The function has a return -EINVAL and a return true, so even without the > > return type it would be locally apparent that there is an inconsistency. > > True, -EINVAL is a non-bool constant, but > bool returns can be a variable int. > > Dan, was the check any constant non-bool? This warning is for returning negative with unsigned types smaller than int. It's doing cross function flow analysis so it could warning about other things besides constants, but it's 90% constants. It warns about ds2482_w1_triplet() for example. There aren't many false positives. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 21+ messages in thread
* [ath9k-devel] [patch -next] ath9k: fix ath9k_hw_nvram_check_version() 2015-12-19 10:59 ` Dan Carpenter (?) @ 2016-01-07 13:05 ` Kalle Valo -1 siblings, 0 replies; 21+ messages in thread From: Kalle Valo @ 2016-01-07 13:05 UTC (permalink / raw) To: ath9k-devel Dan Carpenter <dan.carpenter@oracle.com> writes: > There is a type bug so it always returns success. > > Fixes: 6fa658fd5ab2 ('ath9k: Simplify and fix eeprom endianness swapping') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied to ath.git, thanks. -- Kalle Valo ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2016-01-07 13:05 ` Kalle Valo 0 siblings, 0 replies; 21+ messages in thread From: Kalle Valo @ 2016-01-07 13:05 UTC (permalink / raw) To: Dan Carpenter Cc: QCA ath9k Development, Martin Blumenstingl, linux-wireless, ath9k-devel, kernel-janitors Dan Carpenter <dan.carpenter@oracle.com> writes: > There is a type bug so it always returns success. > > Fixes: 6fa658fd5ab2 ('ath9k: Simplify and fix eeprom endianness swapping') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied to ath.git, thanks. -- Kalle Valo ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version() @ 2016-01-07 13:05 ` Kalle Valo 0 siblings, 0 replies; 21+ messages in thread From: Kalle Valo @ 2016-01-07 13:05 UTC (permalink / raw) To: Dan Carpenter Cc: QCA ath9k Development, Martin Blumenstingl, linux-wireless, ath9k-devel, kernel-janitors Dan Carpenter <dan.carpenter@oracle.com> writes: > There is a type bug so it always returns success. > > Fixes: 6fa658fd5ab2 ('ath9k: Simplify and fix eeprom endianness swapping') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied to ath.git, thanks. -- Kalle Valo ^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2016-01-07 13:05 UTC | newest] Thread overview: 21+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-12-19 10:59 [ath9k-devel] [patch -next] ath9k: fix ath9k_hw_nvram_check_version() Dan Carpenter 2015-12-19 10:59 ` Dan Carpenter 2015-12-19 10:59 ` Dan Carpenter 2015-12-19 11:12 ` [ath9k-devel] " Martin Blumenstingl 2015-12-19 11:12 ` Martin Blumenstingl 2015-12-19 11:12 ` Martin Blumenstingl 2015-12-20 18:47 ` [ath9k-devel] " Joe Perches 2015-12-20 18:47 ` Joe Perches 2015-12-20 18:47 ` Joe Perches 2015-12-20 19:00 ` [ath9k-devel] " Julia Lawall 2015-12-20 19:00 ` Julia Lawall 2015-12-20 19:00 ` Julia Lawall 2015-12-20 19:05 ` [ath9k-devel] " Joe Perches 2015-12-20 19:05 ` Joe Perches 2015-12-20 19:05 ` Joe Perches 2015-12-20 20:33 ` [ath9k-devel] " Dan Carpenter 2015-12-20 20:33 ` Dan Carpenter 2015-12-20 20:33 ` Dan Carpenter 2016-01-07 13:05 ` [ath9k-devel] " Kalle Valo 2016-01-07 13:05 ` Kalle Valo 2016-01-07 13:05 ` Kalle Valo
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.