From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Timur Tabi <timur@tabi.org>,
kernel-janitors@vger.kernel.org, Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ASoC: imx-pcm-dma: add NULL test
Date: Sun, 20 Dec 2015 23:34:32 -0800 [thread overview]
Message-ID: <20151221073431.GD3524@Asurada-CZ80> (raw)
In-Reply-To: <1450610153-7746-2-git-send-email-Julia.Lawall@lip6.fr>
On Sun, Dec 20, 2015 at 12:15:50PM +0100, Julia Lawall wrote:
> Add NULL test on call to devm_kzalloc.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x;
> @@
>
> * x = devm_kzalloc(...);
> ... when != x == NULL
> *x
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Thank you
>
> ---
> sound/soc/fsl/imx-pcm-dma.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/fsl/imx-pcm-dma.c b/sound/soc/fsl/imx-pcm-dma.c
> index 1fc01ed..f3d3d1f 100644
> --- a/sound/soc/fsl/imx-pcm-dma.c
> +++ b/sound/soc/fsl/imx-pcm-dma.c
> @@ -62,6 +62,8 @@ int imx_pcm_dma_init(struct platform_device *pdev, size_t size)
>
> config = devm_kzalloc(&pdev->dev,
> sizeof(struct snd_dmaengine_pcm_config), GFP_KERNEL);
> + if (!config)
> + return -ENOMEM;
> *config = imx_dmaengine_pcm_config;
> if (size)
> config->prealloc_buffer_size = size;
>
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Timur Tabi <timur@tabi.org>,
kernel-janitors@vger.kernel.org, Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ASoC: imx-pcm-dma: add NULL test
Date: Mon, 21 Dec 2015 07:34:32 +0000 [thread overview]
Message-ID: <20151221073431.GD3524@Asurada-CZ80> (raw)
In-Reply-To: <1450610153-7746-2-git-send-email-Julia.Lawall@lip6.fr>
On Sun, Dec 20, 2015 at 12:15:50PM +0100, Julia Lawall wrote:
> Add NULL test on call to devm_kzalloc.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x;
> @@
>
> * x = devm_kzalloc(...);
> ... when != x = NULL
> *x
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Thank you
>
> ---
> sound/soc/fsl/imx-pcm-dma.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/fsl/imx-pcm-dma.c b/sound/soc/fsl/imx-pcm-dma.c
> index 1fc01ed..f3d3d1f 100644
> --- a/sound/soc/fsl/imx-pcm-dma.c
> +++ b/sound/soc/fsl/imx-pcm-dma.c
> @@ -62,6 +62,8 @@ int imx_pcm_dma_init(struct platform_device *pdev, size_t size)
>
> config = devm_kzalloc(&pdev->dev,
> sizeof(struct snd_dmaengine_pcm_config), GFP_KERNEL);
> + if (!config)
> + return -ENOMEM;
> *config = imx_dmaengine_pcm_config;
> if (size)
> config->prealloc_buffer_size = size;
>
next prev parent reply other threads:[~2015-12-21 7:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 11:15 [PATCH 0/4] add NULL test Julia Lawall
2015-12-20 11:15 ` Julia Lawall
2015-12-20 11:15 ` [PATCH 1/4] ASoC: imx-pcm-dma: " Julia Lawall
2015-12-20 11:15 ` Julia Lawall
2015-12-21 7:34 ` Nicolin Chen [this message]
2015-12-21 7:34 ` Nicolin Chen
2015-12-23 0:08 ` Applied "ASoC: imx-pcm-dma: add NULL test" to the asoc tree Mark Brown
2015-12-20 11:15 ` [PATCH 2/4] ASoC: omap-hdmi-audio: add NULL test Julia Lawall
2015-12-20 11:15 ` Julia Lawall
2015-12-21 9:35 ` Peter Ujfalusi
2015-12-21 9:35 ` Peter Ujfalusi
2015-12-21 9:35 ` Peter Ujfalusi
2015-12-23 0:08 ` Applied "ASoC: omap-hdmi-audio: add NULL test" to the asoc tree Mark Brown
2015-12-20 11:15 ` [PATCH 3/4] s390/cio: add NULL test Julia Lawall
2015-12-20 11:15 ` Julia Lawall
2015-12-21 9:33 ` Heiko Carstens
2015-12-21 9:33 ` Heiko Carstens
2015-12-20 11:15 ` [PATCH 4/4] ASoC: Intel: " Julia Lawall
2015-12-20 11:15 ` Julia Lawall
2015-12-23 0:02 ` Mark Brown
2015-12-23 6:58 ` Julia Lawall
2015-12-23 6:58 ` Julia Lawall
2015-12-23 6:58 ` Julia Lawall
2015-12-23 0:08 ` Applied "ASoC: Intel: add NULL test" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221073431.GD3524@Asurada-CZ80 \
--to=nicoleotsuka@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.