All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] crypto: Fix typo in example
Date: Mon, 21 Dec 2015 16:12:17 +0000	[thread overview]
Message-ID: <20151221161216.GF5316@redhat.com> (raw)
In-Reply-To: <1450713257-17108-1-git-send-email-eblake@redhat.com>

On Mon, Dec 21, 2015 at 08:54:17AM -0700, Eric Blake wrote:
> The example code wouldn't even compile, since it did not use
> a consistent spelling for the Error ** parameter.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

> ---
>  include/crypto/tlssession.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/crypto/tlssession.h b/include/crypto/tlssession.h
> index b38fe69..d356a8d 100644
> --- a/include/crypto/tlssession.h
> +++ b/include/crypto/tlssession.h
> @@ -56,7 +56,7 @@
>   *
>   * static int mysock_run_tls(int sockfd,
>   *                           QCryptoTLSCreds *creds,
> - *                           Error *erp)
> + *                           Error *errp)
>   * {
>   *    QCryptoTLSSession *sess;
>   *

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] crypto: Fix typo in example
Date: Mon, 21 Dec 2015 16:12:17 +0000	[thread overview]
Message-ID: <20151221161216.GF5316@redhat.com> (raw)
In-Reply-To: <1450713257-17108-1-git-send-email-eblake@redhat.com>

On Mon, Dec 21, 2015 at 08:54:17AM -0700, Eric Blake wrote:
> The example code wouldn't even compile, since it did not use
> a consistent spelling for the Error ** parameter.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

> ---
>  include/crypto/tlssession.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/crypto/tlssession.h b/include/crypto/tlssession.h
> index b38fe69..d356a8d 100644
> --- a/include/crypto/tlssession.h
> +++ b/include/crypto/tlssession.h
> @@ -56,7 +56,7 @@
>   *
>   * static int mysock_run_tls(int sockfd,
>   *                           QCryptoTLSCreds *creds,
> - *                           Error *erp)
> + *                           Error *errp)
>   * {
>   *    QCryptoTLSSession *sess;
>   *

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

  reply	other threads:[~2015-12-21 16:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-21 15:54 [Qemu-trivial] [PATCH] crypto: Fix typo in example Eric Blake
2015-12-21 15:54 ` [Qemu-devel] " Eric Blake
2015-12-21 16:12 ` Daniel P. Berrange [this message]
2015-12-21 16:12   ` Daniel P. Berrange
2016-01-10 17:53 ` [Qemu-trivial] " Michael Tokarev
2016-01-10 17:53   ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151221161216.GF5316@redhat.com \
    --to=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.