From: Adam Barth <aurorean@gmail.com>
To: trivial@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH v2] lib: radix_tree: Fix error in docs about locks
Date: Mon, 21 Dec 2015 15:04:39 -0800 [thread overview]
Message-ID: <20151221230437.GA8021@deepzen> (raw)
This text refers to the "first 7 functions", which was correct when
written but became incorrect when Johannes Weiner added another function
to the list in 139e561660fe ("lib: radix_tree: tree node interface").
Remove the sentence because it doesn't add any additional information
and would need to be updated each time the list changes.
Signed-off-by: Adam Barth <aurorean@gmail.com>
---
Changes in v2:
- Removed the sentence entirely, as suggested by derRichard.
include/linux/radix-tree.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/linux/radix-tree.h b/include/linux/radix-tree.h
index 33170db..204aa02 100644
--- a/include/linux/radix-tree.h
+++ b/include/linux/radix-tree.h
@@ -154,10 +154,9 @@ do { \
* radix_tree_gang_lookup_tag_slot
* radix_tree_tagged
*
- * The first 7 functions are able to be called locklessly, using RCU. The
- * caller must ensure calls to these functions are made within rcu_read_lock()
- * regions. Other readers (lock-free or otherwise) and modifications may be
- * running concurrently.
+ * The caller must ensure calls to these functions (other than
+ * radix_tree_tagged) are made within rcu_read_lock() regions. Other readers
+ * (lock-free or otherwise) and modifications may be running concurrently.
*
* It is still required that the caller manage the synchronization and lifetimes
* of the items. So if RCU lock-free lookups are used, typically this would mean
--
1.9.1
reply other threads:[~2015-12-21 23:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221230437.GA8021@deepzen \
--to=aurorean@gmail.com \
--cc=20151221082344.GA2969@deepzen \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.