From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Ludovic Desroches <ludovic.desroches@atmel.com>
Cc: jic23@kernel.org, nicolas.ferre@atmel.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, plagnioj@jcrosoft.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver
Date: Wed, 23 Dec 2015 11:27:01 +0100 [thread overview]
Message-ID: <20151223102701.GH8623@piout.net> (raw)
In-Reply-To: <1450689852-22763-2-git-send-email-ludovic.desroches@atmel.com>
On 21/12/2015 at 10:24:08 +0100, Ludovic Desroches wrote :
> +++ b/Documentation/devicetree/bindings/iio/adc/at91_adc8xx.txt
> @@ -0,0 +1,27 @@
> +* AT91 SAMA5D2 Analog to Digital Converter (ADC)
> +
> +Required properties:
> + - compatible: Should be "atmel,sama5d2-adc".
> + - reg: Should contain ADC registers location and length.
> + - interrupts: Should contain the IRQ line for the ADC.
> + - clocks: phandles to clocks.
> + - clock-names: tuple listing clock names.
> + Required elements: "adc_clk", "adc_op_clk". "adc_clk" is the peripheral
> + clock, "adc_clk" is the sampling clock.
I think we should not have adc_op_clk but rather have a property like
vf610 has fsl,adck-max-frequency.
Even better, would be the ability to change it with
/sys/bus/iio/devices/iio:deviceX/sampling_frequency
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver
Date: Wed, 23 Dec 2015 11:27:01 +0100 [thread overview]
Message-ID: <20151223102701.GH8623@piout.net> (raw)
In-Reply-To: <1450689852-22763-2-git-send-email-ludovic.desroches@atmel.com>
On 21/12/2015 at 10:24:08 +0100, Ludovic Desroches wrote :
> +++ b/Documentation/devicetree/bindings/iio/adc/at91_adc8xx.txt
> @@ -0,0 +1,27 @@
> +* AT91 SAMA5D2 Analog to Digital Converter (ADC)
> +
> +Required properties:
> + - compatible: Should be "atmel,sama5d2-adc".
> + - reg: Should contain ADC registers location and length.
> + - interrupts: Should contain the IRQ line for the ADC.
> + - clocks: phandles to clocks.
> + - clock-names: tuple listing clock names.
> + Required elements: "adc_clk", "adc_op_clk". "adc_clk" is the peripheral
> + clock, "adc_clk" is the sampling clock.
I think we should not have adc_op_clk but rather have a property like
vf610 has fsl,adck-max-frequency.
Even better, would be the ability to change it with
/sys/bus/iio/devices/iio:deviceX/sampling_frequency
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Ludovic Desroches
<ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver
Date: Wed, 23 Dec 2015 11:27:01 +0100 [thread overview]
Message-ID: <20151223102701.GH8623@piout.net> (raw)
In-Reply-To: <1450689852-22763-2-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
On 21/12/2015 at 10:24:08 +0100, Ludovic Desroches wrote :
> +++ b/Documentation/devicetree/bindings/iio/adc/at91_adc8xx.txt
> @@ -0,0 +1,27 @@
> +* AT91 SAMA5D2 Analog to Digital Converter (ADC)
> +
> +Required properties:
> + - compatible: Should be "atmel,sama5d2-adc".
> + - reg: Should contain ADC registers location and length.
> + - interrupts: Should contain the IRQ line for the ADC.
> + - clocks: phandles to clocks.
> + - clock-names: tuple listing clock names.
> + Required elements: "adc_clk", "adc_op_clk". "adc_clk" is the peripheral
> + clock, "adc_clk" is the sampling clock.
I think we should not have adc_op_clk but rather have a property like
vf610 has fsl,adck-max-frequency.
Even better, would be the ability to change it with
/sys/bus/iio/devices/iio:deviceX/sampling_frequency
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-23 10:27 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 9:24 [PATCH 0/5] Introduce at91_adc8xx driver Ludovic Desroches
2015-12-21 9:24 ` Ludovic Desroches
2015-12-21 9:24 ` Ludovic Desroches
2015-12-21 9:24 ` [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver Ludovic Desroches
2015-12-21 9:24 ` Ludovic Desroches
2015-12-21 9:24 ` Ludovic Desroches
2015-12-21 9:38 ` Peter Meerwald-Stadler
2015-12-21 10:16 ` Ludovic Desroches
2015-12-21 10:25 ` Ludovic Desroches
2015-12-22 18:34 ` Jonathan Cameron
2015-12-22 18:34 ` Jonathan Cameron
2015-12-23 10:27 ` Ludovic Desroches
2015-12-23 10:27 ` Ludovic Desroches
2015-12-23 10:27 ` Ludovic Desroches
2015-12-23 10:48 ` Ludovic Desroches
2015-12-23 10:48 ` Ludovic Desroches
2015-12-23 10:48 ` Ludovic Desroches
2015-12-23 17:21 ` Jonathan Cameron
2015-12-23 17:21 ` Jonathan Cameron
2015-12-23 17:21 ` Jonathan Cameron
2016-01-05 13:18 ` Ludovic Desroches
2016-01-05 13:18 ` Ludovic Desroches
2016-01-05 13:18 ` Ludovic Desroches
2015-12-31 19:23 ` Jonathan Cameron
2015-12-31 19:23 ` Jonathan Cameron
2015-12-31 19:23 ` Jonathan Cameron
2015-12-23 0:51 ` Rob Herring
2015-12-23 0:51 ` Rob Herring
2015-12-23 0:51 ` Rob Herring
2015-12-23 10:29 ` Ludovic Desroches
2015-12-23 10:29 ` Ludovic Desroches
2015-12-23 10:29 ` Ludovic Desroches
2015-12-23 10:27 ` Alexandre Belloni [this message]
2015-12-23 10:27 ` Alexandre Belloni
2015-12-23 10:27 ` Alexandre Belloni
2015-12-21 9:24 ` [PATCH 2/5] MAINTAINERS: add entry for Atmel ADC 8xx driver Ludovic Desroches
2015-12-21 9:24 ` Ludovic Desroches
2015-12-21 9:24 ` Ludovic Desroches
2015-12-21 9:24 ` [PATCH 3/5] ARM: at91/dt: sama5d2: add adc device Ludovic Desroches
2015-12-21 9:24 ` Ludovic Desroches
2015-12-21 9:24 ` Ludovic Desroches
2015-12-21 9:24 ` [PATCH 4/5] ARM: at91/dt: sama5d2 Xplained: enable the " Ludovic Desroches
2015-12-21 9:24 ` Ludovic Desroches
2015-12-21 9:24 ` Ludovic Desroches
2015-12-21 9:24 ` [PATCH 5/5] ARM: at91/defconfig: add sama5d2 adc support in sama5_defconfig Ludovic Desroches
2015-12-21 9:24 ` Ludovic Desroches
2015-12-21 9:24 ` Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151223102701.GH8623@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.