* Re: designware i2c bus driver [not found] <CABTftiTOHfs_h9Kkb4=aA-bDKhWPxCaCZ2fRxAjHeitmz9pvsA@mail.gmail.com> @ 2015-12-23 7:45 ` Baruch Siach [not found] ` <CABTftiRXHG-1aJN9wE39-KGLw50sdo6FMjk2c7VVwG2BWNF33A@mail.gmail.com> 0 siblings, 1 reply; 2+ messages in thread From: Baruch Siach @ 2015-12-23 7:45 UTC (permalink / raw) To: Rolland Chau; +Cc: linux-i2c Hi Rolland, On Wed, Dec 23, 2015 at 02:56:20PM +0800, Rolland Chau wrote: > I found in i2c-designware-platdrv.c , the i2c retry time is not set, > and the default value is 0, so if I use in kernel mode, I can't set > the retry time. I want to konw why you don't initialize the value in > probe()? I don't see any retry handling in current driver code. What kernel version are you using? What retry value do you refer to? Adding linux-i2c mailing list to Cc. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <CABTftiRXHG-1aJN9wE39-KGLw50sdo6FMjk2c7VVwG2BWNF33A@mail.gmail.com>]
* Re: designware i2c bus driver [not found] ` <CABTftiRXHG-1aJN9wE39-KGLw50sdo6FMjk2c7VVwG2BWNF33A@mail.gmail.com> @ 2015-12-23 10:29 ` Baruch Siach 0 siblings, 0 replies; 2+ messages in thread From: Baruch Siach @ 2015-12-23 10:29 UTC (permalink / raw) To: Rolland Chau; +Cc: linux-i2c, Andy Shevchenko, Jarkko Nikula, Mika Westerberg Hi Rolland, On Wed, Dec 23, 2015 at 05:12:47PM +0800, Rolland Chau wrote: > 2015-12-23 15:45 GMT+08:00 Baruch Siach <baruch@tkos.co.il>: > > On Wed, Dec 23, 2015 at 02:56:20PM +0800, Rolland Chau wrote: > > > I found in i2c-designware-platdrv.c , the i2c retry time is not set, > > > and the default value is 0, so if I use in kernel mode, I can't set > > > the retry time. I want to konw why you don't initialize the value in > > > probe()? > > > > I don't see any retry handling in current driver code. What kernel version > > are > > you using? What retry value do you refer to? > > I2c_adapter.retries. It means retry times when i2c transfer failed. Right. Makes sense. As far as I can see current code retries the transfer only on Tx arbitration loss. I'll send a patch later if you don't beat me to it. > > Adding linux-i2c mailing list to Cc. > > I subscribe to linux-i2c, but there is no response. Adding i2c-designware-* maintainers to Cc as well. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-23 10:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CABTftiTOHfs_h9Kkb4=aA-bDKhWPxCaCZ2fRxAjHeitmz9pvsA@mail.gmail.com>
2015-12-23 7:45 ` designware i2c bus driver Baruch Siach
[not found] ` <CABTftiRXHG-1aJN9wE39-KGLw50sdo6FMjk2c7VVwG2BWNF33A@mail.gmail.com>
2015-12-23 10:29 ` Baruch Siach
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.