From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Uri Mashiach <uri.mashiach-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
Cc: Grygorii Strashko
<grygorii.strashko-l0cyMroinI0@public.gmane.org>,
Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
Igor Grinberg <grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>,
Eliad Peller <eliad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] wlcore/wl12xx: spi: add device tree support
Date: Wed, 23 Dec 2015 07:36:31 -0800 [thread overview]
Message-ID: <20151223153630.GK2793@atomide.com> (raw)
In-Reply-To: <567AB1CB.1050203-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
* Uri Mashiach <uri.mashiach-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org> [151223 06:38]:
> On 12/23/2015 12:25 PM, Grygorii Strashko wrote:
>
> >>+ that services interrupts for this device
> >>+- vwlan-supply : Point the node of the regulator that controls the wl1271 chip WLAN_EN pin
> >
> >Pls, use gpio if this is required just to toggle WLAN_EN pin.
> >
> >[ti,] power-gpio or en-gpio
> >
> >
>
> The controller's power might need toggling in some board implementation.
> Maybe GPIO and regulator should be implemented?
Yes a regulator for wlcore is best here because to properly control it
and the wait needed.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Uri Mashiach <uri.mashiach@compulab.co.il>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Kalle Valo <kvalo@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
bcousson@baylibre.com, Igor Grinberg <grinberg@compulab.co.il>,
Eliad Peller <eliad@wizery.com>,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] wlcore/wl12xx: spi: add device tree support
Date: Wed, 23 Dec 2015 07:36:31 -0800 [thread overview]
Message-ID: <20151223153630.GK2793@atomide.com> (raw)
In-Reply-To: <567AB1CB.1050203@compulab.co.il>
* Uri Mashiach <uri.mashiach@compulab.co.il> [151223 06:38]:
> On 12/23/2015 12:25 PM, Grygorii Strashko wrote:
>
> >>+ that services interrupts for this device
> >>+- vwlan-supply : Point the node of the regulator that controls the wl1271 chip WLAN_EN pin
> >
> >Pls, use gpio if this is required just to toggle WLAN_EN pin.
> >
> >[ti,] power-gpio or en-gpio
> >
> >
>
> The controller's power might need toggling in some board implementation.
> Maybe GPIO and regulator should be implemented?
Yes a regulator for wlcore is best here because to properly control it
and the wait needed.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] wlcore/wl12xx: spi: add device tree support
Date: Wed, 23 Dec 2015 07:36:31 -0800 [thread overview]
Message-ID: <20151223153630.GK2793@atomide.com> (raw)
In-Reply-To: <567AB1CB.1050203@compulab.co.il>
* Uri Mashiach <uri.mashiach@compulab.co.il> [151223 06:38]:
> On 12/23/2015 12:25 PM, Grygorii Strashko wrote:
>
> >>+ that services interrupts for this device
> >>+- vwlan-supply : Point the node of the regulator that controls the wl1271 chip WLAN_EN pin
> >
> >Pls, use gpio if this is required just to toggle WLAN_EN pin.
> >
> >[ti,] power-gpio or en-gpio
> >
> >
>
> The controller's power might need toggling in some board implementation.
> Maybe GPIO and regulator should be implemented?
Yes a regulator for wlcore is best here because to properly control it
and the wait needed.
Regards,
Tony
next prev parent reply other threads:[~2015-12-23 15:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 8:35 [PATCH 0/3] wlcore/wl12xx: spi: add wifi support to cm-t335 Uri Mashiach
2015-12-23 8:35 ` Uri Mashiach
2015-12-23 8:35 ` Uri Mashiach
[not found] ` <1450859744-9948-1-git-send-email-uri.mashiach-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-23 8:35 ` [PATCH 1/3] wlcore/wl12xx: spi: fix NULL pointer dereference (Oops) Uri Mashiach
2015-12-23 8:35 ` Uri Mashiach
2015-12-23 8:35 ` Uri Mashiach
[not found] ` <1450859744-9948-2-git-send-email-uri.mashiach-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-23 10:08 ` Grygorii Strashko
2015-12-23 10:08 ` Grygorii Strashko
2015-12-23 10:08 ` Grygorii Strashko
[not found] ` <567A7287.3010205-l0cyMroinI0@public.gmane.org>
2015-12-23 14:11 ` Uri Mashiach
2015-12-23 14:11 ` Uri Mashiach
2015-12-23 14:11 ` Uri Mashiach
2015-12-23 8:35 ` [PATCH 2/3] wlcore/wl12xx: spi: add device tree support Uri Mashiach
2015-12-23 8:35 ` Uri Mashiach
2015-12-23 8:35 ` Uri Mashiach
[not found] ` <1450859744-9948-3-git-send-email-uri.mashiach-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-23 10:25 ` Grygorii Strashko
2015-12-23 10:25 ` Grygorii Strashko
2015-12-23 10:25 ` Grygorii Strashko
[not found] ` <567A76B5.70605-l0cyMroinI0@public.gmane.org>
2015-12-23 14:38 ` Uri Mashiach
2015-12-23 14:38 ` Uri Mashiach
2015-12-23 14:38 ` Uri Mashiach
[not found] ` <567AB1CB.1050203-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-23 15:36 ` Tony Lindgren [this message]
2015-12-23 15:36 ` Tony Lindgren
2015-12-23 15:36 ` Tony Lindgren
2015-12-24 7:41 ` Uri Mashiach
2015-12-24 7:41 ` Uri Mashiach
2015-12-24 7:41 ` Uri Mashiach
2015-12-30 16:30 ` Rob Herring
2015-12-30 16:30 ` Rob Herring
2015-12-30 16:30 ` Rob Herring
2015-12-23 8:35 ` [PATCH 3/3] wlcore/wl12xx: spi: add wifi support to cm-t335 Uri Mashiach
2015-12-23 8:35 ` Uri Mashiach
2015-12-23 8:35 ` Uri Mashiach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151223153630.GK2793@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eliad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org \
--cc=grygorii.strashko-l0cyMroinI0@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=uri.mashiach-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.