From: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Ross Zwisler
<ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Daniel Wagner
<daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Dave Jones
<davej-rdkfGonbjUTCLXcRTR1eJlpr/1R2p/CL@public.gmane.org>,
kernel-team-b10kYP2dOMg@public.gmane.org,
Aleksa Sarai <cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>,
Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Subject: Re: [PATCH] cgroup: Fix uninitialized variable warning
Date: Wed, 23 Dec 2015 14:38:13 -0700 [thread overview]
Message-ID: <20151223213813.GA21287@linux.intel.com> (raw)
In-Reply-To: <20151223213519.GM5003-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
On Wed, Dec 23, 2015 at 04:35:19PM -0500, Tejun Heo wrote:
> Hello, Ross.
>
> On Wed, Dec 23, 2015 at 02:30:40PM -0700, Ross Zwisler wrote:
> > static int mem_cgroup_can_attach(struct cgroup_taskset *tset)
> > {
> > struct cgroup_subsys_state *css;
> > - struct mem_cgroup *memcg;
> > + struct mem_cgroup *memcg = NULL;
>
> It's one thing to add spurious init to shut up gcc
>
> > @@ -4805,7 +4805,7 @@ static int mem_cgroup_can_attach(struct cgroup_taskset *tset)
> > p = leader;
> > memcg = mem_cgroup_from_css(css);
> > }
> > - if (!p)
> > + if (!p || !memcg)
>
> and to another to add an additional processing on it.
Do you believe that the additional processing is incorrect? If somehow we
*do* get through the above loop without setting memcg, the next deref will
OOPs the kernel...
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Li Zefan <lizefan@huawei.com>,
Daniel Wagner <daniel.wagner@bmw-carit.de>,
Johannes Weiner <hannes@cmpxchg.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
Dave Jones <davej@codemonkey.org.uk>,
kernel-team@fb.com, Aleksa Sarai <cyphar@cyphar.com>,
Michal Hocko <mhocko@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH] cgroup: Fix uninitialized variable warning
Date: Wed, 23 Dec 2015 14:38:13 -0700 [thread overview]
Message-ID: <20151223213813.GA21287@linux.intel.com> (raw)
In-Reply-To: <20151223213519.GM5003@mtj.duckdns.org>
On Wed, Dec 23, 2015 at 04:35:19PM -0500, Tejun Heo wrote:
> Hello, Ross.
>
> On Wed, Dec 23, 2015 at 02:30:40PM -0700, Ross Zwisler wrote:
> > static int mem_cgroup_can_attach(struct cgroup_taskset *tset)
> > {
> > struct cgroup_subsys_state *css;
> > - struct mem_cgroup *memcg;
> > + struct mem_cgroup *memcg = NULL;
>
> It's one thing to add spurious init to shut up gcc
>
> > @@ -4805,7 +4805,7 @@ static int mem_cgroup_can_attach(struct cgroup_taskset *tset)
> > p = leader;
> > memcg = mem_cgroup_from_css(css);
> > }
> > - if (!p)
> > + if (!p || !memcg)
>
> and to another to add an additional processing on it.
Do you believe that the additional processing is incorrect? If somehow we
*do* get through the above loop without setting memcg, the next deref will
OOPs the kernel...
next prev parent reply other threads:[~2015-12-23 21:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 21:30 [PATCH] cgroup: Fix uninitialized variable warning Ross Zwisler
2015-12-23 21:30 ` Ross Zwisler
2015-12-23 21:35 ` Tejun Heo
[not found] ` <20151223213519.GM5003-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-12-23 21:38 ` Ross Zwisler [this message]
2015-12-23 21:38 ` Ross Zwisler
[not found] ` <20151223213813.GA21287-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-12-23 21:41 ` Tejun Heo
2015-12-23 21:41 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2015-12-23 21:53 Ross Zwisler
2015-12-23 21:53 ` Ross Zwisler
[not found] ` <1450907607-5060-1-git-send-email-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-12-28 15:45 ` Tejun Heo
2015-12-28 15:45 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151223213813.GA21287@linux.intel.com \
--to=ross.zwisler-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org \
--cc=daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org \
--cc=davej-rdkfGonbjUTCLXcRTR1eJlpr/1R2p/CL@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.